[kde-workspace] kwin/data/desktop: Move kwin/data to kwin/data/desktop so that I can add kwin/data/active.

[Martin Gräßlin]

Hi Lamarque,

I'm quite confused by your three commits [1, 2, 3]. Why are they needed? We 
nowhere in KWin have folder distinction for "desktop" and "active" and I do 
not like that at all.

Why did you push directly to master without consulting the KWin development 
team (no review request, no mail to mailing list, no ack in commits)?

We also had some discussions about the update scripts in the past for active 
and found a bug in one of the scripts. So in case you just found some issues 
it would have been better to report a bug to fix it properly.

Overall I find that pretty uncool :-(

Regards
Martin

[1]: http://commits.kde.org/kde-
workspace/652b2aae34e3fe7d4d532c5921236224f3fcb3d0
[2]: http://commits.kde.org/kde-
workspace/6fa8817b6dfd87cfff2d0491990fb4c4412cfc7d
[3]: http://commits.kde.org/kde-
workspace/1ba959870b1614e49ed804cbd2ef8b00daefbdf3

On Monday 23 April 2012 22:59:18 Lamarque V.  Souza wrote:
> Git commit 652b2aae34e3fe7d4d532c5921236224f3fcb3d0 by Lamarque V. Souza.
> Committed on 18/04/2012 at 13:59.
> Pushed by lvsouza into branch 'master'.
> 
> Move kwin/data to kwin/data/desktop so that I can add kwin/data/active.
> 
> R  +0    -0    kwin/data/desktop/CMakeLists.txt [from:
> kwin/data/CMakeLists.txt - 100% similarity] R  +0    -0   
> kwin/data/desktop/fsp_workarounds_1.kwinrules [from:
> kwin/data/fsp_workarounds_1.kwinrules - 100% similarity] R  +0    -0   
> kwin/data/desktop/kwin_fsp_workarounds_1.upd [from:
> kwin/data/kwin_fsp_workarounds_1.upd - 100% similarity] R  +0    -0   
> kwin/data/desktop/kwin_remove_delay_focus.sh [from:
> kwin/data/kwin_remove_delay_focus.sh - 100% similarity] R  +0    -0   
> kwin/data/desktop/kwin_remove_delay_focus.upd [from:
> kwin/data/kwin_remove_delay_focus.upd - 100% similarity] R  +0    -0   
> kwin/data/desktop/kwin_remove_effects.upd [from:
> kwin/data/kwin_remove_effects.upd - 100% similarity] R  +0    -0   
> kwin/data/desktop/kwin_update_tabbox_qml_settings.upd [from:
> kwin/data/kwin_update_tabbox_qml_settings.upd - 100% similarity] R  +0   
> -0    kwin/data/desktop/kwin_update_tabbox_settings.upd [from:
> kwin/data/kwin_update_tabbox_settings.upd - 100% similarity] R  +-    --   
> kwin/data/desktop/pop.wav [from: kwin/data/pop.wav - 100% similarity] R  +0
>    -0    kwin/data/desktop/update_default_rules.cpp [from:
> kwin/data/update_default_rules.cpp - 100% similarity] R  +0    -0   
> kwin/data/desktop/update_tabbox_qml_settings.cpp [from:
> kwin/data/update_tabbox_qml_settings.cpp - 100% similarity] R  +0    -0   
> kwin/data/desktop/update_tabbox_settings.cpp [from:
> kwin/data/update_tabbox_settings.cpp - 100% similarity]
> 
> http://commits.kde.org/kde-workspace/652b2aae34e3fe7d4d532c5921236224f3fcb3d
> 0
> 
> diff --git a/kwin/data/CMakeLists.txt b/kwin/data/desktop/CMakeLists.txt
> similarity index 100%
> rename from kwin/data/CMakeLists.txt
> rename to kwin/data/desktop/CMakeLists.txt
> diff --git a/kwin/data/fsp_workarounds_1.kwinrules
> b/kwin/data/desktop/fsp_workarounds_1.kwinrules similarity index 100%
> rename from kwin/data/fsp_workarounds_1.kwinrules
> rename to kwin/data/desktop/fsp_workarounds_1.kwinrules
> diff --git a/kwin/data/kwin_fsp_workarounds_1.upd
> b/kwin/data/desktop/kwin_fsp_workarounds_1.upd similarity index 100%
> rename from kwin/data/kwin_fsp_workarounds_1.upd
> rename to kwin/data/desktop/kwin_fsp_workarounds_1.upd
> diff --git a/kwin/data/kwin_remove_delay_focus.sh
> b/kwin/data/desktop/kwin_remove_delay_focus.sh similarity index 100%
> rename from kwin/data/kwin_remove_delay_focus.sh
> rename to kwin/data/desktop/kwin_remove_delay_focus.sh
> diff --git a/kwin/data/kwin_remove_delay_focus.upd
> b/kwin/data/desktop/kwin_remove_delay_focus.upd similarity index 100%
> rename from kwin/data/kwin_remove_delay_focus.upd
> rename to kwin/data/desktop/kwin_remove_delay_focus.upd
> diff --git a/kwin/data/kwin_remove_effects.upd
> b/kwin/data/desktop/kwin_remove_effects.upd similarity index 100%
> rename from kwin/data/kwin_remove_effects.upd
> rename to kwin/data/desktop/kwin_remove_effects.upd
> diff --git a/kwin/data/kwin_update_tabbox_qml_settings.upd
> b/kwin/data/desktop/kwin_update_tabbox_qml_settings.upd similarity index
> 100%
> rename from kwin/data/kwin_update_tabbox_qml_settings.upd
> rename to kwin/data/desktop/kwin_update_tabbox_qml_settings.upd
> diff --git a/kwin/data/kwin_update_tabbox_settings.upd
> b/kwin/data/desktop/kwin_update_tabbox_settings.upd similarity index 100%
> rename from kwin/data/kwin_update_tabbox_settings.upd
> rename to kwin/data/desktop/kwin_update_tabbox_settings.upd
> diff --git a/kwin/data/pop.wav b/kwin/data/desktop/pop.wav
> similarity index 100%
> rename from kwin/data/pop.wav
> rename to kwin/data/desktop/pop.wav
> diff --git a/kwin/data/update_default_rules.cpp
> b/kwin/data/desktop/update_default_rules.cpp similarity index 100%
> rename from kwin/data/update_default_rules.cpp
> rename to kwin/data/desktop/update_default_rules.cpp
> diff --git a/kwin/data/update_tabbox_qml_settings.cpp
> b/kwin/data/desktop/update_tabbox_qml_settings.cpp similarity index 100%
> rename from kwin/data/update_tabbox_qml_settings.cpp
> rename to kwin/data/desktop/update_tabbox_qml_settings.cpp
> diff --git a/kwin/data/update_tabbox_settings.cpp
> b/kwin/data/desktop/update_tabbox_settings.cpp similarity index 100%
> rename from kwin/data/update_tabbox_settings.cpp
> rename to kwin/data/desktop/update_tabbox_settings.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/active/attachments/20120423/31da148d/attachment.sig>