<br><br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Some comments:<br>
0001-Intendation-cleanup:<br>
Note that such a change makres merging with the original file from KHTML<br>
harder, but it's okay for me since it improves readabilty.</blockquote><div> <br>Hmm, I understand. Is it possible to patch KHTML code to change this (I know it's just a detail but I wouldn't want to debug this code ;)<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
0001-Zoom-actions-changes:<br>
* Are you sue the bool var m_zoomTextOnly is always initiated?</blockquote><div><br>No, I'm not sure, but all of the settings are initialized the same way as I see, so I assumed this is the working way. I don't know if this is a good, idea but we can move all bit fields to union with an int and init the whole union at once. But I'm not sure if it's necessary.<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
* "Zoom Normal" is not a very nice text IMHO. What about "Reset zoom"? Or what<br>
do you suggest?</blockquote><div> </div><div>"Reset Zoom" or "Zoom Reset" are good. I didn't gave much thought about the name.<br>
Maybe "Default Zoom", but reset is probably better. Is there a convention established in KDE? <br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
* Just thought about it: is it the usual way that the user sets an option for<br>
one tab, and it gets saved as a global setting? Probably you could add a new<br>
option in the HTML options, and respect that option? Though the issue would be<br>
that KHTML would not follow this setting... So not really sure how to handle<br>
that. Probably your way is the only really working way. Any thoughts, anyone?</blockquote><div> <br>FF have global setting as well, so it's not that bad ;) If we make this setting per tab how do we save this? per domain? I don't know how other people but I only use option to set text only zoom when I'm testing/writing the code, so it's not a hot feature anyway. ;)<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
0002-Code-cleanup:<br>
This patch makes merging really harder. I also like nice code styling a lot,<br>
but I'm not sure if it is worth for loosing automatic merging...</blockquote><div><br>Yes, now I understand why it looks how it looks. Now I see there is no point in style cleanup without cleanup upstream.<br><br></div>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
0003-Added-astyle-script-for-kdelibs-style.-Applyed-sctip.patch:<br>
Have you manually reviewed all changes? In some rare cases astyle styling is<br>
not the optimal thing.</blockquote><div><br>No I didn't, but good to know that astyle isn't perfect. Anyway, I can try to rewrite the script to force styling only on files that have no imporeted/merged code (but I'm not sure if it makes sense).<br>
</div><br>Best Regards,<br>Paweł<br></div><br>