[WebKit-devel] Review Request: Honour the "Open links in new tab instead of new window" option

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107238/#review22254
-----------------------------------------------------------


This review has been submitted with commit fe6c0f09de0cb550aafa9b2ad0c3d973a0e5a892 by Jonathan Marten to branch master.

- Commit Hook


On Nov. 7, 2012, 12:02 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107238/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2012, 12:02 p.m.)
> 
> 
> Review request for kwebkitpart.
> 
> 
> Description
> -------
> 
> If using the WebKit part as the default HTML engine in Konqueror, its "Open links in new tab instead of in new window" option appears to be ignored.  I'm not intimately familiar with the kwebkitpart code, but what appears to be happening is that it is setting the "action requested by user" flag to always false for any navigation request.  This then ignores the Konqueror setting in KonqMainWindow::slotCreateNewWindow().
> 
> Looking at the logic in NewWindowPage::acceptNavigationRequest(), the m_disableJSOpenwindowCheck appears to be a flag saying whether this page is being opened as a result of a JS popup.  I'm assuming, therefore, that the reverse of that is a normal user interaction, and "requested by user" should be set accordingly.
> 
> Should this also be done in NewWindowPage::slotLoadFinished()?
> 
> 
> This addresses bug 309649.
>     http://bugs.kde.org/show_bug.cgi?id=309649
> 
> 
> Diffs
> -----
> 
>   src/webpage.cpp 2f224dc 
> 
> Diff: http://git.reviewboard.kde.org/r/107238/diff/
> 
> 
> Testing
> -------
> 
> Built kwebitpart with this change, checked operation with the test case as described in the bug and other web browsing (including sites which open new windows and JS popups).  New windows and tabs are opened as expected.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/webkit-devel/attachments/20121120/0205b87e/attachment.html>