[kde] [Bug 481229] Segfault when adding new File Association

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=481229

Harald Sitter <sitter at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
                   |ma/kde-cli-tools/-/commit/c |ma/kde-cli-tools/-/commit/7
                   |099d4b08b5efd96e5748ba905fe |c0f78f045beea968ca7ebbd35b1
                   |2cddcada07fd                |d1414a22761d

--- Comment #3 from Harald Sitter <sitter at kde.org> ---
Git commit 7c0f78f045beea968ca7ebbd35b1d1414a22761d by Harald Sitter.
Committed on 12/02/2024 at 17:08.
Pushed by sitter into branch 'Plasma/6.0'.

keditfiletype: fix crash when adding apps to "empty" views

thou shalt not c-cast => let's dynamic cast, through dynamic cast we'll
notice that the items aren't actually what we thought they should be and
then we can skip them.

notably when there is no app association we insert a fake 'None' entry,
this entry is still present when updatePreferredServices runs but needs
skipping because it does not represent a service

I should note that the UX for the new-association use case is fairly
buggy still, but at least it doesn't crash


(cherry picked from commit c099d4b08b5efd96e5748ba905fe2cddcada07fd)

M  +10   -3    keditfiletype/kservicelistwidget.cpp

https://invent.kde.org/plasma/kde-cli-tools/-/commit/7c0f78f045beea968ca7ebbd35b1d1414a22761d

-- 
You are receiving this mail because:
You are the assignee for the bug.