[kdenetwork-filesharing] [Bug 475946] Share properties page shows incorrect, bogus error message

[Stefan Brüns]

https://bugs.kde.org/show_bug.cgi?id=475946

Stefan Brüns <stefan.bruens at rwth-aachen.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/netw
                   |                            |ork/kdenetwork-filesharing/
                   |                            |-/commit/456c127ee95b8be252
                   |                            |c28046f444091230b47b24
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #2 from Stefan Brüns <stefan.bruens at rwth-aachen.de> ---
Git commit 456c127ee95b8be252c28046f444091230b47b24 by Stefan Brüns.
Committed on 11/11/2023 at 00:25.
Pushed by bruns into branch 'master'.

Remove wrong group check from group manager

Samba allows any group name for usershares. As long as the user is part
of the group the group name does not affect the function of usershares
at all.

The "net" man page even spells out "serverops" as example, which is
currently not accepted.

The remaining checks when creating the group is still bogus, but is
quite limited in scope, and has no effect when the group already exists.

M  +2    -2    samba/filepropertiesplugin/authhelper.cpp
M  +0    -13   samba/filepropertiesplugin/groupmanager.cpp

https://invent.kde.org/network/kdenetwork-filesharing/-/commit/456c127ee95b8be252c28046f444091230b47b24

-- 
You are receiving this mail because:
You are the assignee for the bug.