[Breeze] [Bug 426651] New: KStyle Breeze uses a wrong KColorScheme for Button colors focus and hover

[Jaakko Kantojärvi]

https://bugs.kde.org/show_bug.cgi?id=426651

            Bug ID: 426651
           Summary: KStyle Breeze uses a wrong KColorScheme for Button
                    colors focus and hover
           Product: Breeze
           Version: 5.17.5
          Platform: Debian testing
                OS: Linux
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: QStyle
          Assignee: unassigned-bugs at kde.org
          Reporter: jaakko at n-1.fi
  Target Milestone: ---

SUMMARY

The KStyle Breeze uses the color set View for Button colors focus and hover,
when it should use color set Button instead.

The style uses helper functions [1] to retrieve focus and hover colors and uses
these for buttons too [2]. However, the functions use cached KStatefulBrush,
which is constructed using KColorScheme::View (i.e. not KColorScheme::Button)
[3].

Based on the KColosScheme API doc [4], it seems the Breeze should use the
different color set for these colors.

It's likely that there are other function rendering buttons. which use the
wrong brush too.

[1]:
https://invent.kde.org/plasma/breeze/-/blob/master/kstyle/breezehelper.h#L55
[2]:
https://invent.kde.org/plasma/breeze/-/blob/master/kstyle/breezehelper.cpp#L219 
[3]:
https://invent.kde.org/plasma/breeze/-/blob/master/kstyle/breezehelper.cpp#L42
[4]:
https://api.kde.org/frameworks/kconfigwidgets/html/classKColorScheme.html#a5b3eef45718f795b80ea24bf3b364b7d


STEPS TO REPRODUCE
1. Select Breeze application style and e.g. Breeze Dark color theme
2. Edit Focus Decoration and Hover Decoration for color set View (set something
wild)
3. Save and apply the new color scheme
4. Hover and focus some buttons


OBSERVED RESULT

Buttons use focus and hover colors from the View color set.


EXPECTED RESULT

Buttons would use the colors from the Button color set (which were not edited
by the reproduce step).


SOFTWARE/OS VERSIONS
Operating System: Debian GNU/Linux 
KDE Plasma Version: 5.17.5
KDE Frameworks Version: 5.70.0
Qt Version: 5.14.2
Kernel Version: 5.8.0-1-amd64
OS Type: 64-bit


ADDITIONAL INFORMATION

If someone can confirm that I'm not totally off with this, then I might look
into fixing this. However, I'm not sure about how much time I have or if I can
make the code good enough (I asumme the brush is cached for some reason).

-- 
You are receiving this mail because:
You are the assignee for the bug.