[drkonqi] [Bug 406748] Buttons are cut off while drkonqi generates a backtrace

Harald Sitter bugzilla_noreply at kde.org
Tue Jun 11 11:33:00 BST 2019


https://bugs.kde.org/show_bug.cgi?id=406748

Harald Sitter <sitter at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.16.1
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/drk
                   |                            |onqi/bf5d10ab09461516cd5230
                   |                            |c6dc12ec67e074c15d
             Status|REPORTED                    |RESOLVED

--- Comment #1 from Harald Sitter <sitter at kde.org> ---
Git commit bf5d10ab09461516cd5230c6dc12ec67e074c15d by Harald Sitter.
Committed on 11/06/2019 at 10:32.
Pushed by sitter into branch 'Plasma/5.16'.

use even more resizing

Summary:
since the widget by default has no strings in the designer ui file any
state change injects stuff in qlabels and changes the effective size hint.
to deal with this once and for all the three state changes now always
call a new adjustment helper.
the adjustment helper calls adjustSize iff the hintted dimensions are
larger than the effective one. this way we don't shrink the window
when the backtrace is reloaded, but always grow it if needed for the
backtraced state.

CHANGELOG: The Developer Information tab now correctly resizes to fit the
content
FIXED-IN: 5.16.1
BUGL 403408

Test Plan:
- no cut off widgets when going to dev info tab while bt is generated
- neither when the bt is loaded
- doesn't shrink when clicking reload

Reviewers: mart

Reviewed By: mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D21642

M  +22   -4    src/backtracewidget.cpp
M  +1    -0    src/backtracewidget.h

https://commits.kde.org/drkonqi/bf5d10ab09461516cd5230c6dc12ec67e074c15d

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Unassigned-bugs mailing list