[drkonqi] [Bug 409807] Some checkboxes and their labels are misaligned

Harald Sitter bugzilla_noreply at kde.org
Sat Jul 20 23:34:54 BST 2019


https://bugs.kde.org/show_bug.cgi?id=409807

Harald Sitter <sitter at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/drk
                   |                            |onqi/5a59721d7efe89adbfad2d
                   |                            |ec39878d65c2655228
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #2 from Harald Sitter <sitter at kde.org> ---
Git commit 5a59721d7efe89adbfad2dec39878d65c2655228 by Harald Sitter.
Committed on 20/07/2019 at 22:32.
Pushed by sitter into branch 'master'.

wrap the details example label+spacer in a container widget

Summary:
this way we can control both their visibility in a single call. with the
previous code we'd only set the label as hidden and leave a dangling
spacer to mess with the layout.

Test Plan:
- segv dolphin -> report -> layout shows example
- segv systemsettings5 -> report -> layout shows no example but is correctly
spaced

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22485

M  +2    -1    src/bugzillaintegration/reportassistantpages_base.cpp
M  +39   -37   src/bugzillaintegration/ui/assistantpage_bugawareness.ui

https://commits.kde.org/drkonqi/5a59721d7efe89adbfad2dec39878d65c2655228

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Unassigned-bugs mailing list