[drkonqi] [Bug 383530] DrKonqi has not all Distributions/Platforms that are present on bugs.kde.org site

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=383530

Harald Sitter <sitter at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/drk
                   |                            |onqi/bc83d5ba953bcbce90c72b
                   |                            |440173ed49513785c7
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Harald Sitter <sitter at kde.org> ---
Git commit bc83d5ba953bcbce90c72b440173ed49513785c7 by Harald Sitter.
Committed on 19/07/2019 at 09:23.
Pushed by sitter into branch 'master'.

pull platforms/distributions dynamically out of the bugzilla api

Summary:
this ensures that all known platforms are actually in the comobox and
reduces the amount of string duplication.

the new code gets the list of platforms from bugzilla and then either
attempts to select the one which was auto-detected by systeminformation
or recycle the one previously used.

setup is now triggered in the constructor. loading from the api is still
fairly cheap but even so takes longer than the hardcoded list, so
loading this on aboutToShow is fairly unattractive at this point.

the now useless members for combobox state tracking are gone entirely.
CHANGELOG: The list of available platforms is now always in sync with the list
on bugzilla itself

Test Plan:
list gets loaded as expected
list errors as expected when offline

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22492

M  +93   -70   src/bugzillaintegration/reportassistantpages_bugzilla.cpp
M  +5    -2    src/bugzillaintegration/reportassistantpages_bugzilla.h
M  +21   -3    src/bugzillaintegration/ui/assistantpage_bugzilla_information.ui

https://commits.kde.org/drkonqi/bc83d5ba953bcbce90c72b440173ed49513785c7

-- 
You are receiving this mail because:
You are the assignee for the bug.