[drkonqi] [Bug 202495] dr. konqui should autologin in bugs.kde.org

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=202495

Harald Sitter <sitter at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.16.3
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/drk
                   |                            |onqi/add2ad75e3625c5b0d772a
                   |                            |555ecff5aa8bde5c22
             Status|REPORTED                    |RESOLVED

--- Comment #6 from Harald Sitter <sitter at kde.org> ---
Git commit add2ad75e3625c5b0d772a555ecff5aa8bde5c22 by Harald Sitter.
Committed on 02/07/2019 at 11:27.
Pushed by sitter into branch 'Plasma/5.16'.

auto log in if username and password have been loaded from kwallet

Summary:
it's a bit moot to load the data from the wallet and then still have the
user manually click a log in button when we could just as well have tried
to log in using the stored credentials.

the new behavior is that the user goes through the bug reporting dialog,
and when showing the login page it will automatically try to login using
stored credentials. if the creds check out, the dialog automatically moves
on to the next page.

- page-validity is now in a helper canLogin function as it needs checking
  in two functions now (walletlogin and loginclick)
- the page now automatically goes into login state and attempts to log in
  using stored credentials

in the event that the credentials are wrong (e.g. password changed on
website) the page will enter error state saying the credentials are wrong.
when no credentials are in the wallet or the credentials are incomplete
(password remembering is off) no auto login happens.
FIXED-IN: 5.16.3
CHANGELOG: DrKonqi will now automatically log into bugs.kde.org when possible

Test Plan:
- have no credentials -> no auto login
- login manually and store credentials -> restart -> auto login happens
- change password on website -> restart -> auto login fails & error is shown

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22190

M  +23   -6    src/bugzillaintegration/reportassistantpages_bugzilla.cpp
M  +2    -0    src/bugzillaintegration/reportassistantpages_bugzilla.h

https://commits.kde.org/drkonqi/add2ad75e3625c5b0d772a555ecff5aa8bde5c22

-- 
You are receiving this mail because:
You are the assignee for the bug.