[frameworks-kdeclarative] [Bug 395510] Grid Layout KCMs: inline buttons are hard to see and aren't usable with touch

Nate Graham bugzilla_noreply at kde.org
Tue Feb 5 20:39:32 GMT 2019


https://bugs.kde.org/show_bug.cgi?id=395510

Nate Graham <nate at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/kde
                   |                            |clarative/6258f33fce3af55f7
                   |                            |cdd3b5487cd04d8e53c0b38
   Version Fixed In|                            |5.56
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from Nate Graham <nate at kde.org> ---
Git commit 6258f33fce3af55f7cdd3b5487cd04d8e53c0b38 by Nate Graham.
Committed on 05/02/2019 at 20:39.
Pushed by ngraham into branch 'master'.

[GridViewKCM] improve contrast and legibility for delegates' inline hover
buttons

Summary:
Right now the delegates' inline hover buttons can be very difficult to see,
because they're
(mostly) white and don't get much background contrast. A gradient appears on
the bottom of
the thumbnail on hover, which provides a bit of visual differentiation, but no
real contrast.

This patch improves the situation by using real buttons (with a built-in
background) instead
of toolbuttons.
FIXED-IN: 5.56

Test Plan:
{F6589836, autoplay=true}

{F6589841, autoplay=true}

Reviewers: #vdg, #plasma, broulik, GB_2, ndavis

Reviewed By: #vdg, GB_2, ndavis

Subscribers: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts,
GB_2, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D18649

M  +11   -27   src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

https://commits.kde.org/kdeclarative/6258f33fce3af55f7cdd3b5487cd04d8e53c0b38

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the Unassigned-bugs mailing list