[systemsettings] [Bug 350663] Changing default default web browser reverts after closing settings page

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=350663

Nate Graham <nate at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.12.8
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-desktop/26fb5ec20af6068
                   |                            |2561c7a9678506199966ef2c1
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Nate Graham <nate at kde.org> ---
Git commit 26fb5ec20af60682561c7a9678506199966ef2c1 by Nate Graham.
Committed on 27/11/2018 at 03:01.
Pushed by ngraham into branch 'Plasma/5.12'.

[Componentchooser KCM] Make default browser app choice work even when combobox
is not used

Summary:
FIXED-IN: 5.12.8

When choosing a default browser app using the app list combobox, the choice was
only being saved after the combobox was used, because its signal was connected
to an inline function that saved the choice, while the radio button that
enabled the combobox was not. As a result, if you clicked on that radio button
and didn't need to use the combobox because it was already showing your
preferred browser, that action was not actually getting saved.

This patch fixes the situation my moving the inline function into a real
explicit slot function and connecting the radio button to it as well.

Test Plan:
- Go to the component chooser KCM's default browser module
- Reset to defaults, then leave the KCM and open it again
- Click the {nav in the following application} radio button
- Do NOT touch the combobox
- Click {nav Apply}
- Leave the KCM and come back

With this patch, the radio button's state is preserved and the correct browser
is selected in the combobox.

Reviewers: #plasma, cfeck, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17181

M  +10   -7    kcms/componentchooser/componentchooserbrowser.cpp
M  +1    -0    kcms/componentchooser/componentchooserbrowser.h

https://commits.kde.org/plasma-desktop/26fb5ec20af60682561c7a9678506199966ef2c1

-- 
You are receiving this mail because:
You are the assignee for the bug.