[systemsettings] [Bug 394180] Broken "force fonts dpi" behaviour

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=394180

David Edmundson <kde at davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-desktop/b2694cfc64de7e6
                   |                            |a11fd5ba91f9bacb01b6ad9de

--- Comment #3 from David Edmundson <kde at davidedmundson.co.uk> ---
Git commit b2694cfc64de7e6a11fd5ba91f9bacb01b6ad9de by David Edmundson.
Committed on 23/05/2018 at 09:40.
Pushed by davidedmundson into branch 'Plasma/5.13'.

Fix Font KCM force font DPI checkbox

Summary:
Fixes numerous issues:

1) the default behaviour had changed. It should disable force font DPI,
not set it to 96
2) disabling didn't work, we'd set the value to 0, which would update
the spinbox, which has a minimum which sets the value to 96 (we were
warned of this with a binding loop error)
3) toggling the checkbox didn't enable the apply button

New code fixes that and is more declarative too.

Test Plan: Toggled, reset to defaults, restarted

Reviewers: #plasma, progwolff, broulik

Reviewed By: #plasma, progwolff, broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13051

M  +1    -1    kcms/fonts/fonts.cpp
M  +7    -10   kcms/fonts/package/contents/ui/main.qml

https://commits.kde.org/plasma-desktop/b2694cfc64de7e6a11fd5ba91f9bacb01b6ad9de

-- 
You are receiving this mail because:
You are on the CC list for the bug.