[systemsettings] [Bug 358254] Setting the toolbar font does nothing

[RJVB]

https://bugs.kde.org/show_bug.cgi?id=358254

RJVB <rjvbertin at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/osx
                   |sma-integration/86be8d49d89 |-integration/9dbb9fad5a5c06
                   |88fb6c35e847ed9e0aad3e85142 |67f187b132a6d69e94f3f77a51
                   |08                          |

--- Comment #8 from RJVB <rjvbertin at gmail.com> ---
Git commit 9dbb9fad5a5c0667f187b132a6d69e94f3f77a51 by R.J.V. Bertin.
Committed on 29/11/2017 at 22:11.
Pushed by rjvbb into branch 'qt590'.

Ignore the default stylename hint on Mac and
Allow to change toolbar font separately again

Summary:
The fonts KCM supports changing the toolbar font, but with the port to
QPA/Plasma 5 in aa16577f this stopped working and toolbars just used the
general font. This is fixed by setting QPlatformTheme's ToolButtonFont
to the toolbar font chosen. However, there are some caveats:

Default toolbar font size is 9, while the general font size is 10.
This would result in a sudden shrink in toolbar widths everywhere (or
worse for weird leftover settings users might have tried unsuccessfully).

In some places QToolButtons are used outside of toolbars, sometimes
right next to QPushButtons. As due to the bug both had the same font,
this might now lead to unexpected differences.

Therefore, to keep visual consistency with past Plasma 5 releases, let's
change the default toolbar font size to 10 and provide a kconf_update
script to copy the general font to the toolbar font once.
FIXED-IN: 5.11.0

Test Plan:
make install, run kconf_update: toolBarFont in kdeglobals gets updated
immediately

Change "Toolbar" font in "kcmshell5 fonts", start your favorite KDE
and Qt-only applications: toolbar font and/or font size changed
accordingly

Reviewers: #plasma, davidedmundson, fvogt

Reviewed By: #plasma, davidedmundson, fvogt

Subscribers: fvogt, davidedmundson, jensreuterberg, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6697
Cherry: picked from plasma-integration:86be8d49d8988fb6c35e847ed9e0aad3e8514208
Committed from host : Portia.local

M  +2    -1    src/platformtheme/kdeplatformtheme.cpp
M  +2    -1    src/platformtheme/kfontsettingsdatamac.mm
M  +1    -0    src/platformtheme/plintegration-cumpatch1.diff

https://commits.kde.org/osx-integration/9dbb9fad5a5c0667f187b132a6d69e94f3f77a51

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.