[systemsettings] [Bug 373628] systemsettings5 crashes when closing or going back

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=373628

--- Comment #63 from David Edmundson <kde at davidedmundson.co.uk> ---
Git commit 2601fa10725284feb5bcc78006250c0aa92f92dd by David Edmundson.
Committed on 10/02/2017 at 12:59.
Pushed by davidedmundson into branch 'Plasma/5.8'.

Fix crash in Screen Locker KCM on teardown

Summary:
As described in https://bugreports.qt.io/browse/QTBUG-57714  exposing a
QWidget as a context item to QtQuick can crash. Especially as the
engine's context property gets deleted whilst deleting the parent item.

This patch reworks the code so that exposed properties go through a
proxy QObject.

Test Plan:
Pressing back whilst in the screenlocker KCM used to crash every time,
now it doesn't.

Also changed the wallpaper type, new settings appeared, I went from flat
image to a specific wallpaper, and then locked my screen.

Reviewers: #plasma, graesslin

Reviewed By: #plasma, graesslin

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4535

M  +6    -1    kcm/kcm.cpp
M  +30   -3    kcm/kcm.h

https://commits.kde.org/kscreenlocker/2601fa10725284feb5bcc78006250c0aa92f92dd

-- 
You are receiving this mail because:
You are the assignee for the bug.