[kio] [Bug 314278] kio_thumbnail recompute unnecessary thumbnails for *.kra and *.ora

[Friedrich W. H. Kossebau]

https://bugs.kde.org/show_bug.cgi?id=314278

Friedrich W. H. Kossebau <kossebau at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDSINFO
                 CC|                            |kossebau at kde.org
         Resolution|---                         |WORKSFORME

--- Comment #1 from Friedrich W. H. Kossebau <kossebau at kde.org> ---
The calligra thumbnailing plugin should actually take the embedded thumbnails
out of the files, see CalligraCreator::create() in
https://projects.kde.org/projects/calligra/repository/revisions/master/entry/extras/thumbnail/calligracreator.cpp#L55

Just tested it with ora and kra files, and that also happens for me. The only
issue is that those thumbnails are then copied to the system thumbnail cache,
because there is no support for noting that thumbnails are already stored
embedded.

But there is a case even with embedded previews existing:
if the requested size is larger than the existing thumbnails,
!(thumbnail.width() >= width && thumbnail.height() >= height)
then a new preview is rendered.

You could test things like that: copy a few ora files to a new directory, then
start dolphin from the commandline, so you see also the output of
kio_thumbnail. Go to the directory with Dolphin, enable preview and check the
log: if you see just a few lines with
kio_thumbnail [...] KoStore::open: Opening for reading
"Thumbnails/thumbnail.png"
then the embedded preview is taken. Does that happen for you?

-- 
You are receiving this mail because:
You are the assignee for the bug.