[Bug 104693] the directories' names on root server are truncated

[Ralf Engels]

https://bugs.kde.org/show_bug.cgi?id=104693

Ralf Engels <ralf.engels at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.7
         Resolution|WORKSFORME                  |FIXED
      Latest Commit|                            |http://commits.kde.org/amar
                   |                            |ok/cba53ab9e64f80228b96d875
                   |                            |c9cf6141496493bc

--- Comment #2 from Ralf Engels <ralf.engels at nokia.com> ---
Git commit cba53ab9e64f80228b96d875c9cf6141496493bc by Ralf Engels.
Committed on 17/08/2012 at 13:33.
Pushed by rengels into branch 'master'.

Make Amarok compile and link with TagLib installed in $HOME

I installed TagLib 1.8-GIT in $HOME so I can try the new features (see also my
other review request #101598). $HOME/bin is in $PATH and thus "taglib-config"
returns all the right settings. Still Amarok did not compile. The reason is
that it adds the taglib include directory to the list of include directories,
but then still accesses the taglib headers with "#include <taglib/tstring.h>"
in some places (instead of using "#include <tstring.h>"). This is clearly
wrong, but coincidentally
works if taglib is installed in /usr. I fixed that.

Note: the taglib linking change was not included as discussed on reviewboard.

Courtesy: Mathias Stephan Panzenböck
FIXED-IN: 2.7

M  +1    -1    shared/tag_helpers/APETagHelper.h
M  +1    -1    shared/tag_helpers/ASFTagHelper.h
M  +4    -4    shared/tag_helpers/ID3v2TagHelper.cpp
M  +1    -1    shared/tag_helpers/ID3v2TagHelper.h
M  +1    -1    shared/tag_helpers/MP4TagHelper.h
M  +1    -1    shared/tag_helpers/StringHelper.h
M  +1    -1    shared/tag_helpers/VorbisCommentTagHelper.cpp
M  +2    -2    shared/tag_helpers/VorbisCommentTagHelper.h

http://commits.kde.org/amarok/cba53ab9e64f80228b96d875c9cf6141496493bc

-- 
You are receiving this mail because:
You are the assignee for the bug.