<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Am 13.09.2016 um 11:05 schrieb Shawn
McKenney:<br>
</div>
<blockquote
cite="mid:CAMpDnK1ujGzVChom55qcVFbMaPG40gZOY3W-3FtATodj3zALPw@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra">
<div class="gmail_quote">The question is if this is available
on all supported platforms (linux, windows, mac) and
distributions ? <br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF"> If the answer is yes, we do not
need any specific stuff on umbrello side. <br>
</div>
</blockquote>
<div><br>
</div>
<div>I think you are correct. I do have the dev packages,
but it looks like it is an upstream bug:</div>
<div><br>
</div>
<div> <a moz-do-not-send="true"
href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=819072">https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=819072</a></div>
<div><br>
</div>
<div>Debian/Ubuntu may still need:</div>
<div><br>
</div>
<div><font face="monospace, monospace" color="#073763">find_package(Clang)</font></div>
<div><br>
</div>
<div>in the CMakeLists.txt. Does that work for opensuse?</div>
</div>
</div>
</div>
</blockquote>
yes. With llvm 3.6 it prints something link ClangConfig.cmake not
found, but because it is not required is does not fail.<br>
<blockquote
cite="mid:CAMpDnK1ujGzVChom55qcVFbMaPG40gZOY3W-3FtATodj3zALPw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div><br>
</div>
<div>---</div>
<div><br>
</div>
<div>To get master to build on KDE neon,</div>
<div><br>
</div>
<div>1) I applied the fix found here:</div>
<div><br>
</div>
<div><a moz-do-not-send="true"
href="https://github.com/iovisor/bcc/issues/492">https://github.com/iovisor/bcc/issues/492</a><br>
</div>
<div><br>
</div>
<div>2) Added <font face="monospace, monospace">find_package(Clang)</font>
to <font face="monospace, monospace">unittests/CMakeLists.txt</font></div>
</div>
</div>
</div>
</blockquote>
On Windows builds using KDE/Emerge clang provides cmake support, so
find_package(Clang) is required too.<br>
<blockquote
cite="mid:CAMpDnK1ujGzVChom55qcVFbMaPG40gZOY3W-3FtATodj3zALPw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div><br>
</div>
<div>3) Set Clang_DIR and LLVM_DIR in my cmake config. Here
is my config line:</div>
<div><br>
</div>
<div><span style="font-family:monospace"><span
style="color:rgb(0,0,0)">cmake
-DCMAKE_INSTALL_PREFIX=${HOME}/install/umbrello
-DBUILD_KF5=On -DCMAKE_BUILD_TYPE=Debug
-DLLVM_DIR=/usr/share/llvm-3.</span><br>
8/cmake -DClang_DIR=/usr/lib/llvm-3.8/share/clang/cmake
../umbrello<br>
</span></div>
</div>
</div>
</div>
</blockquote>
I see. On opensuse and Windows (llvm 4.0.0svn) setting of
CLang_DIR or LLVM_DIR is not requried.<br>
<br>
Additional on Windows the following fragment is required below
find_package(CLang)<br>
<br>
if(CLANG_FOUND)<br>
include_directories(${CLANG_INCLUDE_DIRS})<br>
add_definitions(${CLANG_DEFINITIONS})<br>
endif()<br>
<br>
I'm going add this stuff to git master.<br>
<br>
<blockquote
cite="mid:CAMpDnK1ujGzVChom55qcVFbMaPG40gZOY3W-3FtATodj3zALPw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div><br>
</div>
<div>I have centos7 and ubuntu14.04 docker images that I
will use to test the build as well. I don't have access to
Mac or Windows at the moment. </div>
</div>
</div>
</div>
</blockquote>
for windows see above.<br>
<br>
<br>
> or should we call FindClang at a higher level so the vars are
available to others? I could drop it in the top-level cmake
directory.<br>
As long as we are using testcases only it should be in unittests to
reduce hidden interferences. Later with more experience and having
llvm support build into main umbrello we can move this up.<br>
<br>
Ralf <br>
<br>
</body>
</html>