<div dir="ltr"><div class="gmail_extra">I don't think closing a request is that necessary, but may be adding a comment whether it should be applied to master before or after release. In that respect, it would have been nice if github allowed you to add labels to your own pullrequests. (or perhaps a taglib admin setting)</div><div class="gmail_extra"><br></div><div class="gmail_extra">Sander</div><div class="gmail_extra"><br></div><div class="gmail_extra"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 23, 2015 at 1:45 PM, Tsuda Kageyu <span dir="ltr"><<a href="mailto:tsuda.kageyu@gmail.com" target="_blank">tsuda.kageyu@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi Sander,</div><div><br></div><div>First, I agree with you it's good to freeze the changes at a certain point or just now. Many people are awaiting the next release.<br></div><div><br></div><div>Certainly, I have been making a lot of pull requests that may delay the progress of the project. However, I don't think they have to necessarily merged into the next release. How about closing the non-urgent pull request for now? (Privately, I hope "length in milliseconds" feature be merged.)</div><div><br></div><div>Regards,<br></div><div><div>Kageyu</div></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">2015-06-24 3:14 GMT+09:00 Sander Jansen <span dir="ltr"><<a href="mailto:s.jansen@gmail.com" target="_blank">s.jansen@gmail.com</a>></span>:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div dir="ltr"><div class="gmail_extra"><span style="font-size:12.8000001907349px;white-space:nowrap"> Kageyu,</span><br></div><div class="gmail_extra"><span style="font-size:12.8000001907349px;white-space:nowrap"><br></span></div><div class="gmail_extra"><span style="font-size:12.8000001907349px;white-space:nowrap">I think your never ending stream of pull requests have some really nice changes, however it doesn't feel like it is getting us closer to any new release. </span></div><div class="gmail_extra"><span style="font-size:12.8000001907349px;white-space:nowrap">What's holding us back from releasing the current master branch? How about "feature / cleanup / refactor" freeze and just focus only on bugfixes (flac id3v1 comes to mind). </span></div><span><font color="#888888"><div class="gmail_extra"><span style="font-size:12.8000001907349px;white-space:nowrap"><br></span></div><div class="gmail_extra"><span style="font-size:12.8000001907349px;white-space:nowrap">Sander</span></div></font></span></div>
<br></div></div><span class="">_______________________________________________<br>
taglib-devel mailing list<br>
<a href="mailto:taglib-devel@kde.org" target="_blank">taglib-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/taglib-devel" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/taglib-devel</a><br>
<br></span></blockquote></div><br></div>
<br>_______________________________________________<br>
taglib-devel mailing list<br>
<a href="mailto:taglib-devel@kde.org">taglib-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/taglib-devel" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/taglib-devel</a><br>
<br></blockquote></div><br></div></div>