<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hallo Sebastian,<br>
<br>
you are absolutely right, thank you very much for finding this
bug. The same problem affected several other formats like Speex
and Opus, and in the case of the "removeUnsupportedProperties()"
function even some more.<br>
<br>
I have added a fix in the latest commit, it probably will be
included in taglib 1.9.<br>
<br>
Michael<br>
<br>
Am 31.12.2012 20:52, schrieb Sebastian Rachuj:<br>
</div>
<blockquote
cite="mid:trinity-72dafeb8-a1e6-4259-a617-1d63b0f861cf-1356983521613@3capp-webde-bs29"
type="cite">
<div style="font-family: Verdana;font-size: 12.0px;">
<div>Hello,<br>
</div>
<div><br>
</div>
<div>a program I wrote uses taglib to read the metadata of my
music files. It was working just fine until I tried it with an
Ogg FLAC file which resulted in a SIGSEGV. By using valgrind I
realized that the reason is a stack overflow. Unfortunately I
couldn't find a mistake in my code that could create such an
error. But when I was checking the sources of taglib, I found
that Taglib::Ogg::FLAC::File doesn't seem to overwrite the
ugly Taglib::File::properties, so that every call to
dynamic_cast<const Ogg::FLAC::File*
>(this)->properties(); ends again within the same
method.<br>
</div>
<div><br>
</div>
<div>I'm not sure if I understood the code correctly, but I
think it should just work to copy the code for "properties"
and "setProperties" used for vorbis to the flac code (see
attached patches).<br>
</div>
<div><br>
</div>
<div>Anyway thanks for reading my mail and for creating such a
useful library.<br>
</div>
<div><br>
</div>
<div>Best Regards<br>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
taglib-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:taglib-devel@kde.org">taglib-devel@kde.org</a>
<a class="moz-txt-link-freetext" href="https://mail.kde.org/mailman/listinfo/taglib-devel">https://mail.kde.org/mailman/listinfo/taglib-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>