<div dir="ltr">Forgot to send to the list...<br><br><div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Dudy Kohen</b> <span dir="ltr"><<a href="mailto:kohen.d@gmail.com">kohen.d@gmail.com</a>></span><br>
Date: Mon, Apr 13, 2009 at 11:02 AM<br>Subject: Re: C Bindings<br>To: Linus Walleij <<a href="mailto:linus.ml.walleij@gmail.com">linus.ml.walleij@gmail.com</a>><br><br><br><div dir="ltr"><div class="gmail_quote"><div class="im">
On Mon, Apr 13, 2009 at 2:31 AM, Linus Walleij <span dir="ltr"><<a href="mailto:linus.ml.walleij@gmail.com" target="_blank">linus.ml.walleij@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
2009/4/12 Dudy Kohen <<a href="mailto:kohen.d@gmail.com" target="_blank">kohen.d@gmail.com</a>>:<br>
<div><br>
> I implemented some more of the C binding. (now you can read and write any<br>
> string tag for id3v2, and USLT)<br>
<br>
</div>Cool!<br>
<div><br>
> Currently, my Lyrics set subroutine strips all the others from the<br>
> file, do you think I should add a boolean to control this behaviour?<br>
<br>
</div>All other Lyrics? Hm, one tag is one tag I guess... only one USLT<br>
frame and that's it. It should be the same behaviour for all string<br>
tags I think.<br>
<div></div></blockquote></div><div>USLT isn't your normal string frame, it has "description" and "language" fields that hardly anyone uses, and the specification says that you should have only one field with the same description and language. <br>
</div><div class="im"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><br>
> And I have a problem I encountered: I need the USLT frame with a null<br>
> terminator on-disk, I tried rendering it and resize the rendered<br>
> vector, and adding it as an unknown fame, but it deleted the null<br>
> terminator, I didn't see where an UnknownFrame is changing it's data,<br>
> could you point me in the right direction?<br>
<br>
</div>No idea, better ask on the mailinglist and post some code also I think...<br>
<font color="#888888"></font></blockquote></div><div>The if 1==1 is for debugging purposes, I intend to change it with an actual condition...<br><br> String s2(lyrics, unicodeStrings ? String::UTF8 : String::Latin1);<br>
s2.append(String(" ", unicodeStrings ? String::UTF8 : String::Latin1));<br>
uslt_frame->setText(s2);<br> TagLib::ByteVector buff(uslt_frame->render());<br> if (1==1) { <br> String::Type encoding=uslt_frame->textEncoding();<br> buff.data()[buff.size()-1]='\0';<br>
}<br> ID3v2::UnknownFrame *uf=new ID3v2::UnknownFrame(buff);<br> t->addFrame(uf);<br> delete (uslt_frame); <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<font color="#888888"><br>
Linus<br>
</font></blockquote></div><br></div>
</div><br></div>