<span class="gmail_quote"></span>So you know, there is an ID3v2 tag which is identical (minus the identifier) to the comments tag. If one were to copy/paste that the comment frame code, there would be MP3 id3 support, and for APE/Vorbis/etc arbitrary names could be chosen.
<br><br>Just my two cents.<span class="sg"><br><br>- Brian</span><br><span class="gmail_quote"><br>On 6/12/06, <b class="gmail_sendername">Dominik Karall</b> <<a href="mailto:dominik.karall@gmx.net" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
dominik.karall@gmx.net</a>> wrote:</span>
<br><div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><span class="e" id="q_10bd02c225615e23_2"><div>On Monday, 12. June 2006 23:13, Scott Wheeler wrote:
<br>> On Monday 12 June 2006 21:49, you wrote:
<br>> > hi wheeler!<br>> ><br>> > maybe you could add this patch to your taglib sources, this patch<br>> > adds support for lyrics to the whole taglib library.<br>> ><br>> > ID3v1: no lyrics support possible
<br>> > ID3v2: support as provided in specs<br>> > APE: added LYRICS tag (no lyrics support in specs, but a LYRICS<br>> > tag doesn't affect others)<br>> > XIPH: same as in APE<br>> ><br>> > thanks a lot!
<br>><br>> Unfortunately adding virtual methods to the base classes is not<br>> binary compatible, so there are parts of the patch that I can<br>> incorporate, but some of them will have to wait until the next
<br>> major version (2.0).<br>><br>> Two other notes:<br>><br>> - Generally it's preferable to send patches to the list rather than<br>> my personal address so that other people involved in / using TagLib
<br>> can see and potentially review them<br>><br>> - If you're generating patches, it's usually better to work with<br>> the TagLib version from Subversion since that's more up to date.<br>> There are instructions on the TagLib homepage for how to check out
<br>> the subversion sources.<br><br>Hi Scott!<br><br>Sorry, I wasn't sure if there is a mailinglist.<br>I will update the patch for current svn and remove the virtual methods<br>for the base class. Maybe I should divide the patch in separate diffs
<br>for each tag system..<br>I will send a patch to the ML the next days!<br><br>regards,<br>dominik<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
</blockquote></div></span></div></blockquote></div><br>