<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<p style="color: #777777;">
<a href="https://invent.kde.org/tfry">Thomas Friedrichsmeier</a>
commented:
</p>
<div style="">
<p dir="auto">Summary of critical comments raised and their status:</p>
<ul dir="auto">
<li>
<p><a href="https://marc.info/?l=kde-core-devel&m=153912336114603&w=2" rel="nofollow noreferrer noopener" target="_blank">https://marc.info/?l=kde-core-devel&m=153912336114603&w=2</a> (aacid):</p>
<ul>
<li>the i18n folder seems like from the past and something you should not need if in kde <br>
infrastructure. Could you delete it?</li>
<li>Also I'd suggest you compile enabling -DECM_ENABLE_SANITIZERS="address;undefined"
<ul>
<li>Thanks for the hint, did not know that switch. One effect of this is a lot of false positive "runtime errors", when casting a half-destroyed QObject* to its original (derived) type, in order to remove it from containers (e.g. a QMap of KActionCollection()s). Is there an elegant way around this?</li>
</ul>
</li>
<li>There's a few memory leaks (reported at exit) that you may want to have a look.
<ul>
<li>Most (but not all) are fixed, now.</li>
</ul>
</li>
<li>And there's also a few undefined behaviour warnings on exit, you've them marked as <br>
"known" things but it'd be good if you could find a way to fix them.</li>
<li>Your help menu is for some reason missing the Change Language option, i tried to do <br>
it a quick fix but could not, i would appreciate if you could find a way to only <br>
define the extra actions and not all of them (like we do for example in okular).</li>
</ul>
</li>
<li>
<p><a href="https://marc.info/?l=kde-core-devel&m=153916691226377&w=2" rel="nofollow noreferrer noopener" target="_blank">https://marc.info/?l=kde-core-devel&m=153916691226377&w=2</a> (jriddel)</p>
<ul>
<li>It installs two desktop files which creates duplicate menu entries /usr/share/applications/org.kde.rkward-open.desktop /usr/share/applications/org.kde.rkward.desktop
<ul>
<li>Completed following suggestions by Thomas Baumgart and Meik: <a href="https://marc.info/?l=kde-core-devel&m=153942961310071&w=2" rel="nofollow noreferrer noopener" target="_blank">https://marc.info/?l=kde-core-devel&m=153942961310071&w=2</a>
</li>
</ul>
</li>
<li>The .desktop files call it a "GUI for R" which is not a great description, everything in the menu is a GUI. I recommend "R Statistical Programming" or "IDE for R" maybe.
<ul>
<li>Suggestion by Meik: Statistics with R (<a href="https://marc.info/?l=kde-core-devel&m=153942595709279&w=2" rel="nofollow noreferrer noopener" target="_blank">https://marc.info/?l=kde-core-devel&m=153942595709279&w=2</a>)</li>
</ul>
</li>
<li>I tidied up the files with the icon licence as they could easily be lost.
<ul>
<li>Done by jriddel</li>
</ul>
</li>
<li>It depends on WebKit which is not supported, could this be ported to WebEngine?
<ul>
<li>Comment by Lisandro (<a href="https://marc.info/?l=kde-core-devel&m=154218478600505&w=2" rel="nofollow noreferrer noopener" target="_blank">https://marc.info/?l=kde-core-devel&m=154218478600505&w=2</a>)</li>
<li>Done in the meantime by supporting WebEngine, optionally (and by default)</li>
</ul>
</li>
<li>It's uncommon having debian/ packaging directly in the source and there's also debian-official/ which could get confusing and out-of-sync and messy. I recommend moving them to another archive.</li>
<li>Storing the packaging in KDE neon Git would be cool as we already have packaging for all the rest of KDE software. Using salsa.debian pkg-kde team would also make sense but would need different
permissions. Either way we should get this into Neon, give me a ping to sort that out.
<ul>
<li>Partially done</li>
</ul>
</li>
<li>Prelim. answer to jriddel: <a href="https://marc.info/?l=kde-core-devel&m=153918336832295&w=2" rel="nofollow noreferrer noopener" target="_blank">https://marc.info/?l=kde-core-devel&m=153918336832295&w=2</a>
</li>
</ul>
</li>
<li>
<p><a href="https://marc.info/?l=kde-core-devel&m=154118912915065&w=2" rel="nofollow noreferrer noopener" target="_blank">https://marc.info/?l=kde-core-devel&m=154118912915065&w=2</a> (jriddel)</p>
<ul>
<li>There's no appstream metainfo file nor product-screenshot <a href="https://community.kde.org/Guidelines_and_HOWTOs/AppStream" rel="nofollow noreferrer noopener" target="_blank">https://community.kde.org/Guidelines_and_HOWTOs/AppStream</a>
<ul>
<li>Done: Contributed by Meik and Yuri</li>
</ul>
</li>
</ul>
</li>
</ul>
</div>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
Reply to this email directly or <a href="https://invent.kde.org/education/rkward/-/issues/2#note_56280">view it on GitLab</a>.
<br>
You're receiving this email because of your account on invent.kde.org.
If you'd like to receive fewer emails, you can
<a href="https://invent.kde.org/-/sent_notifications/b408da1587edcc3939e8addf6e461d89/unsubscribe">unsubscribe</a>
from this thread or
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Issue","url":"https://invent.kde.org/education/rkward/-/issues/2#note_56280"}}</script>
</p>
</div>
</body>
</html>