<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116558/">https://git.reviewboard.kde.org/r/116558/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For the release time, I would like to give some feedback on how this patch can break things (given that we are already way pass freeze).
The first thing this patch does is adding two extra settings called "AccountId" and "AccountServices". By default these settings are empty and unless initialized to some value this patch will do nothing.
In the case that those settings are set, then we create "urls". This url have a type build in that indicates mostly from where the password is fetched. The url created by this patch have the type "accounts" and this patch will affect only the urls create by this patch. To put it short this patch does not affect the workflow of the code for urls (dav servers) that are not configured by this patch.
So, if we imagine that my patch is bugged to the point where it makes the resource crash, it won't affect other instances of the resource.</pre>
<br />
<p>- Àlex Fiestas</p>
<br />
<p>On March 6th, 2014, 7:55 p.m. UTC, Àlex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDEPIM, Release Team and Grégory Oestreicher.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated March 6, 2014, 7:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdepim-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If compiled with KAccounts support and configure to use it, the resource will fetch credentials and host using libaccounts in order to build the urls.
Support for "editing" is not done, that will be done in 4.14 since it requires better kaccounts-integration.
To the release team, I would like to add this change to 4.13, it won't do anything except compiled with libaccounts and even so only if the resource is configured to use it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>resources/dav/resource/CMakeLists.txt <span style="color: grey">(14675bc)</span></li>
<li>resources/dav/resource/davgroupwareresource.desktop <span style="color: grey">(2342a01)</span></li>
<li>resources/dav/resource/davgroupwareresource.kcfg <span style="color: grey">(2d25371)</span></li>
<li>resources/dav/resource/settings.h <span style="color: grey">(e264866)</span></li>
<li>resources/dav/resource/settings.cpp <span style="color: grey">(12f84cc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116558/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>