<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111947/">http://git.reviewboard.kde.org/r/111947/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can confirm that the new test fails without the patch and works with it. I can't assess the correctness of the code itself since my nepomuk-foo → 0
It'd be cool if someone else from nepomuk-land can try to review. If not I'll guess we'll have to trust Vishesh and commit it :-)</pre>
<br />
<p>- Albert</p>
<br />
<p>On August 8th, 2013, 7:05 p.m. UTC, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Release Team.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2013, 7:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Backup Statement Generator: statements without a datatype can be valid
In Nepomuk the nao:description is stored as an rdfs literal, which means
it doesn't have a datatype, but is supposed to have a language tag.
Since we don't store the language tag, it is just stored as a string.
This used to be considered invalid by the statement generator and
therefore the nao:description (dolphin comments) was never backed up
even though it was requested.
BUG: 323260
It's important to get this into 4.11 otherwise everyone will loose their comments on installing 4.11 as the migration is done through backup.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested by manually backing up a number of times.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=323260">323260</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/storage/backup/statementgenerator.cpp <span style="color: grey">(c3b5985)</span></li>
<li>autotests/test/backuptests.cpp <span style="color: grey">(7284dd6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111947/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>