<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111768/">http://git.reviewboard.kde.org/r/111768/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit e352d07f33207959bdc13352cedd4322eb107a7e by Àlex Fiestas to branch KDE/4.11.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 1st, 2013, 7:47 p.m. UTC, Àlex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Release Team, Solid and Dario Freddi.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2013, 7:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In 4.11 we are able to detect if an action is supported or not, and if it is not we simply unload it.
That new behavior makes the notification "Action not found" deprecated since now it is totally possible that a profile tries to load an unsupported action such DimDisplay on most workstations.
In Powerdevil2/Plasma2/Whatev perhaps we should remove the action from the config, but I'm not sure because an action might be supported during a period of time, for example when plugging a keyboard that support backlight, so it looks to me that we need something more dyamic.
Release team: This removes a line from the catalog.
https://bugs.kde.org/show_bug.cgi?id=321508
https://bugs.kde.org/show_bug.cgi?id=302846</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Notification is not emit anymore.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>powerdevil/daemon/powerdevilcore.cpp <span style="color: grey">(6874feb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111768/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>