<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107536/">http://git.reviewboard.kde.org/r/107536/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Off-topic: This patch reminds me that this ext serial port usage should msot likely be gone altogether in the near future in favour of QtSerialPort we developed for Qt4 and Qt5 in open, but that is for later.</pre>
<br />
<p>- Laszlo</p>
<br />
<p>On November 30th, 2012, 6:29 p.m., Pino Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdewin, Marble and Release Team.</div>
<div>By Pino Toscano.</div>
<p style="color: grey;"><i>Updated Nov. 30, 2012, 6:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Instead of embedding an (old) copy of the QextSerialPort library, find for an external one; only if found enable the reading from TTY, which is otherwise disabled (leaving its configuration tab disabled).
The drop of the internal QextSerialPort should also fix all the portability issues, since the plugin itself does not use any OS-dependent API, and it is then reenabled unconditionally.
Hence, bug 241125 should now be fixed, and bug 237931 and bug 242039 should not happen anymore.
@release-team: yes, I know this would introduce a new optional dependency, but on the other hand a copy of a 3rd party library would go away. Would this be acceptable at this point?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The Aprs plugin compiles fine with and without an external QextSerialPort library.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=241125">241125</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindQextSerialPort.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/CMakeLists.txt <span style="color: grey">(d82293ee782e735ff1c90e6e13d330fb7cf8563c)</span></li>
<li>src/plugins/render/aprs/AprsPlugin.cpp <span style="color: grey">(f406cec2ad665977830416aa7f5df59851a5e430)</span></li>
<li>src/plugins/render/aprs/AprsTTY.cpp <span style="color: grey">(c65ac38b24269b608c8f3ea1452b670f9422174d)</span></li>
<li>src/plugins/render/aprs/CMakeLists.txt <span style="color: grey">(fb6ef13c80568a72a5bfcf8a2e675b969238b9f6)</span></li>
<li>src/plugins/render/aprs/aprsconfig.h.in <span style="color: grey">(d0e6b5c4ce36080dc0e59422529c55728ff04b3a)</span></li>
<li>src/plugins/render/aprs/posix_qextserialport.cpp <span style="color: grey">(118843f02a5c62fd708b9157e59a039dff06e238)</span></li>
<li>src/plugins/render/aprs/qextserialport.h <span style="color: grey">(457d831cffc4ae8c43ac7db2d85a20546eb65044)</span></li>
<li>src/plugins/render/aprs/qextserialport.cpp <span style="color: grey">(790e5a2701ba1291a645c4fd4b09a8a1c55d7541)</span></li>
<li>src/plugins/render/aprs/qextserialport_global.h <span style="color: grey">(013a6dcd4ecab97425b1286139af4f0e911c38c9)</span></li>
<li>src/plugins/render/aprs/win_qextserialport.cpp <span style="color: grey">(5f21d7302e61b50825f79a68b352d5b9544b3fa3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107536/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>