Hey Sebastian <br><br><div class="gmail_quote">On Wed, Jul 13, 2011 at 8:05 PM, Sebastian Kügler <span dir="ltr"><<a href="mailto:sebas@kde.org">sebas@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi Vishesh,<br>
<div class="im"><br>
On Wednesday, July 13, 2011 16:20:01 Vishesh Handa wrote:<br>
> I'm a Nepomuk developer. I'm requesting permission to backport a large<br>
> number commits in kde-runtime.<br>
><br>
> I created a branch called 'nepomuk/mergerRefactoring', that optimized and<br>
> fixed certain bugs in the ResourceMerger. The ResourceMerger is used when<br>
> large amounts of data are pushed in Nepomuk, eg - Strigi indexing. The<br>
> branch refactors the code and remove a TransactionModel, which makes the<br>
> code faster. Additionally it includes unit tests + optimizations + fixes<br>
> for the unit tests. None of these commits are extremely important, but<br>
> they would be nice to have in 4.7. May I backport them?<br>
<br>
</div>Passing more unittests seems like a good idea, making real-world usage more<br>
likely. (And easier to catch regressions). I do have to admit that<br>
"refactoring" doesn't exactly sounds like post-RC material.<br></blockquote><div><br>I had to refactor the code in order to get the unit tests to pass. The earlier design was a remnant of my gsoc design from summer 2010.<br>
<br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im"><br>
> There is one commit ( 7414a3c38b29cb4b2c37457ca8bd1e894aab57c5 ), that I do<br>
> need to push. Indexing is broken in rc2, and the commit fixes it. It has<br>
> been tested thoroughly by me, and some people in open-suse.<br>
<br>
</div>This one should go in for sure.<br></blockquote><div><br>I'll backport it tonight. ( + its unit test )<br> <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im"><br>
> I was informed, that the new policy for bugs is that they should be<br>
> committed to the 4.7 branch, and then the 4.7 branch should be merged into<br>
> master. If that is the case, then most of these commits should go into 4.7,<br>
> as merging 4.7 -> master currently creates a number of conflicts.<br>
<br>
</div>Doesn't really matter at this point. IIRC, this policy is there as general<br>
recommendation to do fixes in -stable and forwardport to master. Which way<br>
your specific changes should be merged, I don't really care. (But maybe others<br>
have good reason to do.)<br>
<div class="im"><br>
> Additionally, I've been working on fixing a class called the<br>
> ResourceWatcher, which is our new API for monitoring changes in Nepomuk.<br>
> The class was added just in time for the feature freeze, and is quite<br>
> buggy. No one uses the ResourceWatcher right now. However, the telepathy<br>
> team need the ResourceWatcher as do the PIM folks. The current mechanism<br>
> for monitoring changes is not convenient, and slows down the entire<br>
> system. Would it be okay to backport those changes as well?<br>
<br>
</div>I think so, yes. It's of little use if it's broken, and the risk of<br>
regressions is low.<br>
<div class="im"><br>
> I know I'm asking for a lot, but all of these changes qualify as bug fixes.<br>
<br>
</div>I'd say if you don't get vetoed within 2 days, please backport the changes you<br>
propose.<br>
<br>
Thanks for working on making Nepomuk rock, btw :)<br></blockquote><div><br>:)<br> <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<font color="#888888">--<br>
sebas<br>
<br>
<a href="http://www.kde.org" target="_blank">http://www.kde.org</a> | <a href="http://vizZzion.org" target="_blank">http://vizZzion.org</a> | GPG Key ID: 9119 0EF9<br>
_______________________________________________<br>
release-team mailing list<br>
<a href="mailto:release-team@kde.org">release-team@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/release-team" target="_blank">https://mail.kde.org/mailman/listinfo/release-team</a><br>
</font></blockquote></div><br><br clear="all"><br>-- <br><font color="#999999">Vishesh Handa</font><br>