Should I wait for more approvals or can I commit it?<div><br></div><div>Thanks<br clear="all">--Marty<br>
<br><br><div class="gmail_quote">On Mon, Jun 6, 2011 at 21:03, Olivier Goffart <span dir="ltr"><<a href="mailto:ogoffart@kde.org">ogoffart@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
No objections from me.<br>
<br>
Le Monday 06 June 2011, Martin Klapetek a écrit :<br>
<div><div></div><div class="h5">> Hi KDE Release team!<br>
><br>
> I'd like to ask for an exception for a small patch adding a nice (and<br>
> important) feature into KNotify. Let me explain - currently you can set<br>
> only one icon for all your notification events. But if you have events<br>
> like error and info, one icon is just not enough. So this patch allows you<br>
> to set an icon per defined event. For example, in KDE-Telepathy, we aim<br>
> for deep system integration and this patch is really important for us, so<br>
> we can use different icons per event as we have several different events,<br>
> info, error and warning. With the desktop integration in mind, it makes<br>
> perfect sense to not use any generic Telepathy icon, but rather a special<br>
> icon for all the events. And I'd like to get this patch in for KDE 4.7,<br>
> because otherwise we could start using this as soon as January, which is a<br>
> bit unfortunate. The patch itself is backwards compatible, so totally<br>
> nothing would be broken and everyone would only gain. It was reviewed and<br>
> approved (see [0]).<br>
><br>
> So, I'm kindly asking you for an exception to let this patch in for 4.7.<br>
> Would that please be possible?<br>
><br>
> Thanks,<br>
> --Marty<br>
><br>
> [0] - <a href="https://git.reviewboard.kde.org/r/101470/" target="_blank">https://git.reviewboard.kde.org/r/101470/</a><br>
<br>
</div></div></blockquote></div><br></div>