From lbeltrame at kde.org Fri Dec 2 14:36:59 2016 From: lbeltrame at kde.org (Luca Beltrame) Date: Fri, 2 Dec 2016 15:36:59 +0100 Subject: Wrong version in RC tarball filenames (16.11.80 vs 16.11.90) Message-ID: <20161202153644.47ac1380@giskard.marionegri.it> The tarballs up at http://download.kde.org/unstable/applications/16.11.90/src/ contain 16.11.80 as version in their filename as opposed to 16.11.90, although the content is correct. This kind of broke packaging scripts. ;) Would it be possible to respin them with the right file name? -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: Firma digitale OpenPGP URL: From aacid at kde.org Fri Dec 2 14:48:55 2016 From: aacid at kde.org (Albert Astals Cid) Date: Fri, 2 Dec 2016 14:48:55 +0000 (UTC) Subject: Wrong version in RC tarball filenames (16.11.80 vs 16.11.90) In-Reply-To: <20161202153644.47ac1380@giskard.marionegri.it> References: <20161202153644.47ac1380@giskard.marionegri.it> Message-ID: <835099421.8640086.1480690135072@mail.yahoo.com> boo me. I've deleted the files now, will regenerate them later today. ----- Mensaje original ----- De: Luca Beltrame Para: release-team at kde.org Enviado: Viernes 2 de diciembre de 2016 15:36 Asunto: Wrong version in RC tarball filenames (16.11.80 vs 16.11.90) The tarballs up at http://download.kde.org/unstable/applications/16.11.90/src/ contain 16.11.80 as version in their filename as opposed to 16.11.90, although the content is correct. This kind of broke packaging scripts. ;) Would it be possible to respin them with the right file name? From aacid at kde.org Fri Dec 2 18:10:02 2016 From: aacid at kde.org (Albert Astals Cid) Date: Fri, 02 Dec 2016 19:10:02 +0100 Subject: Wrong version in RC tarball filenames (16.11.80 vs 16.11.90) In-Reply-To: <835099421.8640086.1480690135072@mail.yahoo.com> References: <20161202153644.47ac1380@giskard.marionegri.it> <835099421.8640086.1480690135072@mail.yahoo.com> Message-ID: <1579769.hPILyGbsBs@xps> El divendres, 2 de desembre de 2016, a les 14:48:55 CET, Albert Astals Cid va escriure: > boo me. > > I've deleted the files now, will regenerate them later today. Ok, new sources are up. Note they are new, not just renamed. (in case any commit actually happened) Cheers, Albert > > > > ----- Mensaje original ----- > De: Luca Beltrame > Para: release-team at kde.org > Enviado: Viernes 2 de diciembre de 2016 15:36 > Asunto: Wrong version in RC tarball filenames (16.11.80 vs 16.11.90) > > The tarballs up at > http://download.kde.org/unstable/applications/16.11.90/src/ contain > 16.11.80 as version in their filename as opposed to 16.11.90, although > the content is correct. > > This kind of broke packaging scripts. ;) Would it be possible to respin > them with the right file name? From aacid at kde.org Fri Dec 2 18:23:53 2016 From: aacid at kde.org (Albert Astals Cid) Date: Fri, 02 Dec 2016 18:23:53 +0000 Subject: www/sites/www Message-ID: SVN commit 1476142 by aacid: KDE Applications 16.12 Release Candidate CCMAIL: release-team at kde.org A announcements/announce-applications-16.12-rc.php M +3 -3 announcements/index.php M +6 -6 index.php A info/applications-16.11.90.php A info/source-applications-16.11.90.inc --- trunk/www/sites/www/announcements/index.php #1476141:1476142 @@ -11,10 +11,10 @@

- -Tuesday, 22 November 2016 - Plasma 5.8.4 + +2nd December 2016 - KDE Applications 16.12 Release Candidate released
-"KDE Ships Plasma 5.8.4." +"KDE Ships Applications 16.12 Release Candidate."

Tuesday, 22 November 2016 - Plasma 5.8.4 --- trunk/www/sites/www/index.php #1476141:1476142 @@ -46,10 +46,14 @@

Latest Announcements

-

KDE Releases Applications 16.12 Beta
-Friday, 18 November, 2016. KDE ships KDE Applications 16.12 Beta. +

KDE Releases Applications 16.12 Release Candidate
+Friday, 2 December, 2016. KDE ships KDE Applications 16.12 Release Candidate.

+

KDE Plasma 5.8.4 Released
+Tuesday, 22 November 2016. Plasma 5.8.4 release. +

+

KDE Releases Frameworks 5.28.0
Tuesday, 15 November, 2016. KDE ships monthly release of KDE Frameworks 5, our modular Qt libraries.

@@ -58,10 +62,6 @@ Thursday, 10 November, 2016. KDE ships KDE Applications 16.08.3.

-

KDE Plasma 5.8.4 Released
-Tuesday, 22 November 2016. Plasma 5.8.4 release. -

- View more announcements...

Application Spotlight

From arojas at archlinux.org Fri Dec 2 21:54:48 2016 From: arojas at archlinux.org (Antonio Rojas) Date: Fri, 2 Dec 2016 21:54:48 +0000 (UTC) Subject: www/sites/www References: Message-ID: El Fri, 02 Dec 2016 18:23:53 +0000, Albert Astals Cid escribió: > SVN commit 1476142 by aacid: > > KDE Applications 16.12 Release Candidate > > CCMAIL: release-team at kde.org There is a dependency freeze break in messagelib, caused by this commit https://cgit.kde.org/messagelib.git/commit/?id=532c1daf21edbd433ec993f73d5e3c98e30dc11a This adds #include , which is in gpgme 1.8 but not in 1.7.1 This effectively raises the gpgme dependency to 1.8, although cmake only searches for 1.7.1 From aacid at kde.org Fri Dec 2 23:25:33 2016 From: aacid at kde.org (Albert Astals Cid) Date: Sat, 03 Dec 2016 00:25:33 +0100 Subject: Dependency freeze broken in messagelib - was - Re: www/sites/www In-Reply-To: References: Message-ID: <67333177.ml74R0moHP@xps> Sandro, can you please fix this? Cheers, Albert El divendres, 2 de desembre de 2016, a les 21:54:48 CET, Antonio Rojas va escriure: > El Fri, 02 Dec 2016 18:23:53 +0000, Albert Astals Cid escribió: > > SVN commit 1476142 by aacid: > > > > KDE Applications 16.12 Release Candidate > > > > CCMAIL: release-team at kde.org > > There is a dependency freeze break in messagelib, caused by this commit > > https://cgit.kde.org/messagelib.git/commit/?id=532c1daf21edbd433ec993f73d5e3 > c98e30dc11a > > This adds #include , which is in gpgme 1.8 but not > in 1.7.1 > > This effectively raises the gpgme dependency to 1.8, although cmake only > searches for 1.7.1 From arojas at archlinux.org Sat Dec 3 00:33:17 2016 From: arojas at archlinux.org (Antonio Rojas) Date: Sat, 3 Dec 2016 00:33:17 +0000 (UTC) Subject: www/sites/www References: Message-ID: El Fri, 02 Dec 2016 18:23:53 +0000, Albert Astals Cid escribió: > SVN commit 1476142 by aacid: > > KDE Applications 16.12 Release Candidate > > CCMAIL: release-team at kde.org l10n-nn and l10n-sr fail to build: ---- CMake Error at 4/nn/data/CMakeLists.txt:1 (add_subdirectory): add_subdirectory given source "kdeedu" which is not an existing directory. ---- CMake Error at 5/sr/data/CMakeLists.txt:1 (add_subdirectory): The source directory /build/kde-l10n/src/kde-l10n-sr-16.11.90/5/sr/data/_custominstall does not contain a CMakeLists.txt file. From bcooksley at kde.org Sat Dec 3 10:41:06 2016 From: bcooksley at kde.org (Ben Cooksley) Date: Sat, 03 Dec 2016 10:41:06 +0000 Subject: [sysadmin/repo-metadata] projects/frameworks/prison: Move Prison to Frameworks. Message-ID: Git commit 53be28ae533973c04e381b314e4030af4157427e by Ben Cooksley. Committed on 03/12/2016 at 10:40. Pushed by bcooksley into branch 'master'. Move Prison to Frameworks. Last minute moves just before a release aren't ideal... CCMAIL: release-team at kde.org CCMAIL: kde-frameworks-devel at kde.org Ref T4801 R +0 -0 projects/frameworks/prison/i18n.json [from: projects/kdesupport/prison/i18n.json - 100% similarity] R +1 -1 projects/frameworks/prison/metadata.yaml [from: projects/kdesupport/prison/metadata.yaml - 090% similarity] https://commits.kde.org/sysadmin/repo-metadata/53be28ae533973c04e381b314e4030af4157427e diff --git a/projects/kdesupport/prison/i18n.json b/projects/frameworks/prison/i18n.json similarity index 100% rename from projects/kdesupport/prison/i18n.json rename to projects/frameworks/prison/i18n.json diff --git a/projects/kdesupport/prison/metadata.yaml b/projects/frameworks/prison/metadata.yaml similarity index 90% rename from projects/kdesupport/prison/metadata.yaml rename to projects/frameworks/prison/metadata.yaml index 82f53ae..a9676f1 100644 --- a/projects/kdesupport/prison/metadata.yaml +++ b/projects/frameworks/prison/metadata.yaml @@ -6,7 +6,7 @@ members: - displayname: Sune Vuorela username: sune name: Barcode library -projectpath: kdesupport/prison +projectpath: frameworks/prison repoactive: true repopath: prison type: module From mail at sandroknauss.de Sat Dec 3 10:52:06 2016 From: mail at sandroknauss.de (Sandro =?ISO-8859-1?Q?Knau=DF?=) Date: Sat, 03 Dec 2016 11:52:06 +0100 Subject: Dependency freeze broken in messagelib - was - Re: www/sites/www In-Reply-To: <67333177.ml74R0moHP@xps> References: <67333177.ml74R0moHP@xps> Message-ID: <2939634.W3QXXdrrUc@tuxin> Hey, Sorry picked the wrong header, but it is now fixed in: messagelib:e978f4d266846c74200424149214b968789f0485 Best regards, sandro -- Am Samstag, 3. Dezember 2016, 00:25:33 CET schrieb Albert Astals Cid: > Sandro, can you please fix this? > > Cheers, > Albert -- Ich habe meinen Schlüssel gewechselt / I've switched my GnuPG key: http://sandroknauss.de/files/transition2015.asc Mein (neuer) öffentlicher Schlüssel / My (new) public key: E68031D299A6527C Fingerabdruck / Fingerprint: D256 4951 1272 8840 BB5E 99F2 E680 31D2 99A6 527C Runterladen z.B. bei/ Get it e.g. here: pool.sks-keyservers.net, ... -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: This is a digitally signed message part. URL: From aacid at kde.org Sat Dec 3 11:25:28 2016 From: aacid at kde.org (Albert Astals Cid) Date: Sat, 03 Dec 2016 12:25:28 +0100 Subject: Dependency freeze broken in messagelib - was - Re: www/sites/www In-Reply-To: <2939634.W3QXXdrrUc@tuxin> References: <67333177.ml74R0moHP@xps> <2939634.W3QXXdrrUc@tuxin> Message-ID: <4833251.0oJiJ680T2@xps> Since the RC tarballs are already out in the public can't re-spin them so I'll make sure this goes in for the final release. Cheers, Albert El dissabte, 3 de desembre de 2016, a les 11:52:06 CET, Sandro Knauß va escriure: > Hey, > > Sorry picked the wrong header, but it is now fixed in: > messagelib:e978f4d266846c74200424149214b968789f0485 > > Best regards, > > sandro > > -- > > Am Samstag, 3. Dezember 2016, 00:25:33 CET schrieb Albert Astals Cid: > > Sandro, can you please fix this? > > > > Cheers, > > > > Albert From aacid at kde.org Sat Dec 3 11:43:14 2016 From: aacid at kde.org (Albert Astals Cid) Date: Sat, 03 Dec 2016 12:43:14 +0100 Subject: stable sr l10n-kf5 fails to cmake - was - Re: www/sites/www In-Reply-To: References: Message-ID: <2216718.WIo3RoWTLX@xps> El dissabte, 3 de desembre de 2016, a les 0:33:17 CET, Antonio Rojas va escriure: > El Fri, 02 Dec 2016 18:23:53 +0000, Albert Astals Cid escribió: > > SVN commit 1476142 by aacid: > > > > KDE Applications 16.12 Release Candidate > > > > CCMAIL: release-team at kde.org > > l10n-nn and l10n-sr fail to build: > > ---- > > CMake Error at 4/nn/data/CMakeLists.txt:1 (add_subdirectory): > add_subdirectory given source "kdeedu" which is not an existing directory. Fixed this. > > ---- > > CMake Error at 5/sr/data/CMakeLists.txt:1 (add_subdirectory): > The source directory > > /build/kde-l10n/src/kde-l10n-sr-16.11.90/5/sr/data/_custominstall > > does not contain a CMakeLists.txt file. Chusslove, can you please fix this. ./scripts/autogen.sh sr cd sr cmake . fails. You need to either: * Add a dummy CMakeLists.txt file * Go back to the previous situation those files where not in a folder * Somehow teach autogen.sh about folders it has to ignore (that seems less desirable tbh). Cheers, Albert From caslav.ilic at gmx.net Sat Dec 3 12:16:16 2016 From: caslav.ilic at gmx.net (Chusslove Illich) Date: Sat, 3 Dec 2016 13:16:16 +0100 Subject: stable sr l10n-kf5 fails to cmake - was - Re: www/sites/www In-Reply-To: <2216718.WIo3RoWTLX@xps> References: <2216718.WIo3RoWTLX@xps> Message-ID: >> [: Antonio Rojas :] >> CMake Error at 5/sr/data/CMakeLists.txt:1 (add_subdirectory): >> The source directory >> >> /build/kde-l10n/src/kde-l10n-sr-16.11.90/5/sr/data/_custominstall >> >> does not contain a CMakeLists.txt file. > > [: Albert Astals Cid :] > You need to either: > * Add a dummy CMakeLists.txt file > * Go back to the previous situation those files where not in a folder > * Somehow teach autogen.sh about folders it has to ignore (that seems > less desirable tbh). Sorry for the trouble. I moved these custom install files to a subdirectory, because Luigi needed some way of recognizing them for making applications translation tarballs. Adding dummy CMakeLists.txt doesn't work, because autogen.sh deletes it at this depth (it preserves them only one level below). The needed change to scripts/autogen.sh is small though, what do you say about it? Index: scripts/autogen.sh =================================================================== --- scripts/autogen.sh (revision 1476293) +++ scripts/autogen.sh (working copy) @@ -184,7 +184,7 @@ # remove old CMakeLists.txt rm -f $dir/data/CMakeLists.txt; echo "add_subdirectory(data)" >> $dir/CMakeLists.txt - dirs=`cd $dir/data && find * -maxdepth 0 -type d -not -empty | fgrep -v .svn` + dirs=`cd $dir/data && find * -maxdepth 0 -type d -not -empty | fgrep -v .svn | fgrep -v _custominstall` for dir2 in $dirs; do echo "add_subdirectory($dir2)" >> $dir/data/CMakeLists.txt rm -f $dir/data/$dir2/CMakeLists.txt; -- Chusslove Illich (Часлав Илић) -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 163 bytes Desc: OpenPGP digital signature URL: From faure at kde.org Sat Dec 3 23:37:52 2016 From: faure at kde.org (David Faure) Date: Sun, 04 Dec 2016 00:37:52 +0100 Subject: KDE Frameworks 5.29.0 Message-ID: <1544539.SQJqS6oqim@linux-t46v.suse> Dear packagers, KDE Frameworks 5.29.0 has been uploaded to the usual place. New framework: prison Public release next Saturday. Thanks for the packaging work! -- David Faure, faure at kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 -------------- next part -------------- attica v5.29.0-rc1 eadb08ebd9a1379d6f187e9f6bb53b8767579f0c a195e8ef4ae8dfb586c3c0a012797f5d4c358bdf3dde9c4eee10f07330c62af6 sources/attica-5.29.0.tar.xz baloo v5.29.0-rc1 4e6f46b027ebdd431ca37710f2d59e59fafa55df 76c0079d965b9a095a396b0e46e257de4458a2288922527a231aa38aad05f81b sources/baloo-5.29.0.tar.xz bluez-qt v5.29.0-rc1 0608df50e5214fb609a9fc9f69d4d350555ede6c 6f8fc96f2b0961d2516b94fc90728674e97d93e9e78db9e13538f76a37823697 sources/bluez-qt-5.29.0.tar.xz breeze-icons v5.29.0-rc1 70ebc5e478e9287e9d98b645b509349cd36fa4d4 0bad6cad78f948fd73fc89ae2566b59b6859a752e95eb348ce735408d4bffbae sources/breeze-icons-5.29.0.tar.xz extra-cmake-modules v5.29.0-rc1 1c59dc9c440c206c96dff2d18cdedc607c110d0a 48f76e626e2235bd4b64aeea9bbbcb803eb8966a6d020d0ab8ddbe81930e98d8 sources/extra-cmake-modules-5.29.0.tar.xz frameworkintegration v5.29.0-rc1 712389978ded8b4d9310c0758fef3d5319ca4abd ebb89e4b236163c067402cf78d67cddc443ef4fda0778001980948efc3cf5a52 sources/frameworkintegration-5.29.0.tar.xz kactivities v5.29.0-rc1 579ce0a74f3067f1d35f846549a0c81af09b3e5e 39cb0d7e9e64fe50ac935549b4c495ed02d7bb1397b176ab3b60bb6c3ec7d7d6 sources/kactivities-5.29.0.tar.xz kactivities-stats v5.29.0-rc1 4c32e2ab615f8cb0cc37ee4ccd106417631d7275 0041d3586645376481c4c832f8a86ed494ab64479d3227c4b98ad57fd3ad9d99 sources/kactivities-stats-5.29.0.tar.xz kapidox v5.29.0-rc1 074dcc25de80fabf6efa5daffd8c395cf6d4723b 17d6152b3dbf02c094288d58f50d8a764546de191031855b0d352c3f479592a0 sources/kapidox-5.29.0.tar.xz karchive v5.29.0-rc1 80521c729b686ab847d70b0c8fc7a77e85fc733d 9091bba1683eefcae6e27ecce6c7236ac792c173d3efa15f255e5890909c2986 sources/karchive-5.29.0.tar.xz kauth v5.29.0-rc1 f52b8a9423f0dfc4271168237caa0144f40259f0 f2c51dfb42196fe5d604883c9f28bda7fd3f40d308144f521f4090a941c2091d sources/kauth-5.29.0.tar.xz kbookmarks v5.29.0-rc1 a6223ec4afc93f13b33d4ff900eab5b00139cf58 71a9126427ac7ebfce98458c2f8d6fe954537e6b81b409e26f0d1ec7be8effc6 sources/kbookmarks-5.29.0.tar.xz kcmutils v5.29.0-rc1 5730e9b0a892bd289d151be901e7d004dbf56238 02a761033f043ee43b2874b335a40fc4ac7b35a68b723ce29057b71bb2ad36f2 sources/kcmutils-5.29.0.tar.xz kcodecs v5.29.0-rc1 13be02265f35c907f606e3550be89f059f4fa19d a757e0298574c143b3cac9054ebe50e43fc6b14986728c2e640cba993457294e sources/kcodecs-5.29.0.tar.xz kcompletion v5.29.0-rc1 00bfb5110ca7b269fce6f05b6f8c44dc9c284437 6b1acf683de6d4b3ec36f7ddc270cd639268d25bb53217c83c9088a55f695ec0 sources/kcompletion-5.29.0.tar.xz kconfig v5.29.0-rc1 ec878f00744bf4a7238d9efaf25c542c72dd299b d268b793638512f73aadcf51348fa3b96bc7b9e383e8c0fbb46429277831e30a sources/kconfig-5.29.0.tar.xz kconfigwidgets v5.29.0-rc1 bf0f4c0e1506ead39bd69dfa89f1df5d4802ea7e ca9580a1079adcc9f95907ea9355ee9b2ceaf001e7620005d2d0b1f1dd245e75 sources/kconfigwidgets-5.29.0.tar.xz kcoreaddons v5.29.0-rc1 3c4930282783032cc46e05ef465153bb73e3778e e28b39fada9b19b03c7c79fc7ac337c1b943b33dbb40967a5cc7ba9f314cb3f6 sources/kcoreaddons-5.29.0.tar.xz kcrash v5.29.0-rc1 8096172ff7642e4d27203d6ad3286dba167403eb 3bdb5421b0909fa4e0d7bfb8bba708f9b95c4edf9ca1580aac8229512c49e224 sources/kcrash-5.29.0.tar.xz kdbusaddons v5.29.0-rc1 580a04d196528b968e03f8b83de11397ed392518 122c23842dccbba8e50dd5639a19df0373bc8217ce5a853c3e8db33a414b3a96 sources/kdbusaddons-5.29.0.tar.xz kdeclarative v5.29.0-rc1 3f0ed24efabcb3fba69549598027794f30b7f2ed 0333fe53eb0f75a027b2cd432c8a310abe6b93efba269440e2fba893da42254e sources/kdeclarative-5.29.0.tar.xz kded v5.29.0-rc1 6424a068f81f705fb1fb920be40ae9cdb93659a3 eb22398682d8eda2686352c1b7657749e4f1aaf9c5c3eb01a304822a8f3a5224 sources/kded-5.29.0.tar.xz kdelibs4support v5.29.0-rc1 cc38afe9f146c1f3cbaa8d33d016b6d0029bdfc2 80bef7ca0e194e844c4e872b05ac56d15ddc83d9a273f4daf9b961e6a0ad12d7 sources/portingAids/kdelibs4support-5.29.0.tar.xz kdesignerplugin v5.29.0-rc1 8b48e42f3f53ec174c1d141982839e132c7472c7 cf0b6ad6d996ff460447c83d382188c10eb01a9ff1e8532866e13050f389a807 sources/kdesignerplugin-5.29.0.tar.xz kdesu v5.29.0-rc1 6f3a7fa7cdd0075d4d16e4d44439aed370e84d45 854cce99c3cac9ca28fd3f7c74b39b7af9d88f63b82c021398819888b4767dd2 sources/kdesu-5.29.0.tar.xz kdewebkit v5.29.0-rc1 b77d0fc1285ad169ebc8e042c4652a09c0b03971 40e37e5c6436c6a930b12c538bfcb9c4734c60718f17732d0276d858640ce475 sources/kdewebkit-5.29.0.tar.xz kdnssd v5.29.0-rc1 f301a6f94d523e4ff9d32ce571fef04fe96bd4db 4aee47cb9229302e9075159654859ed0e2342952b5d880c0163e0ef26cf9e3ad sources/kdnssd-5.29.0.tar.xz kdoctools v5.29.0-rc1 486bdacbeabecc7c8b01f4fac23199447d4f45d1 60badcc58d9d79514fdc1061704e7999021d5cfcdb2b1201ad846f2508fba37d sources/kdoctools-5.29.0.tar.xz kemoticons v5.29.0-rc1 f17fce865fabf6b7b86dc9d80280bbeb1208a890 6a29ae178ffdf8c17877bdb001914fc7a6b55199e92e17971e0bfbd91524b577 sources/kemoticons-5.29.0.tar.xz kfilemetadata v5.29.0-rc1 da6ec983e96c71c0ec3174c23a466b8bccf477b0 821df076d1fce4ac7dac067703e3c2ab885676a68e34f36140b10e58ec7b91c2 sources/kfilemetadata-5.29.0.tar.xz kglobalaccel v5.29.0-rc1 b4669af0febf0e8d6315df293de342b4d44de228 5fb143c4cf71f19ea0a145a2d4d80c98dfb437739bc03d6d3ef1b16a3bb75573 sources/kglobalaccel-5.29.0.tar.xz kguiaddons v5.29.0-rc1 212b96d4160af865d6551655ea963229c2b72366 f3906d76b48660ab685caf06a71d9bd4d716a8875dc0973157f577632601f8b1 sources/kguiaddons-5.29.0.tar.xz khtml v5.29.0-rc1 4ef0aff413f021793b87613a38ffc9c7852bda2a dbe7511be3efa00914e523fac828da7df9292c715f942f1ab4c8206f4bbf30e7 sources/portingAids/khtml-5.29.0.tar.xz ki18n v5.29.0-rc1 78c2fd674036cd262955640d2713549177d3d980 a72e87759f50d3e39ba6cc5bca1a16725609d14cfa8055a2db22dd14b1c79670 sources/ki18n-5.29.0.tar.xz kiconthemes v5.29.0-rc1 ed86cb778bea5fb7348f7aa080ef49725ade2f25 b01cd2eb5a7e2cfdf611e343bbbfdacdcd98c47904a132ba9a0bd65dcf36b225 sources/kiconthemes-5.29.0.tar.xz kidletime v5.29.0-rc1 61cd59118c08dd822f4e1a2b4d97b345fa1213d3 3d66400e008d20d2c2710caebf8a2d6f94197c11643c5df713b95889467cd95a sources/kidletime-5.29.0.tar.xz kimageformats v5.29.0-rc1 e18f6346332029b5fee9f47631db7f7106f181b5 aa9fab34f7e564cc7a5334ef4b9d775452873cd23495279ad8d7b68f0855050d sources/kimageformats-5.29.0.tar.xz kinit v5.29.0-rc1 d2018c22df0b4f4da382775452515267d27cc3bd d6d85684c5b0e0afb73082efb6e8cdd4b07a2461d74348bcfde2e42769431033 sources/kinit-5.29.0.tar.xz kio v5.29.0-rc1 d299415b4a468dc3875c2bba69951c154587bc0f fe3029a5d3d99dc24731669a3e663962d79c2d3f358f76750a3f94c877b615ad sources/kio-5.29.0.tar.xz kitemmodels v5.29.0-rc1 f334239512f783e5fec611b98c6a62e3fb302432 83779f373340bf474017f8b8c654190ef03d275c99ceb04bfd13fa3d614842eb sources/kitemmodels-5.29.0.tar.xz kitemviews v5.29.0-rc1 e453498299aa20bb397462bd3d10ce816cbdef89 70dffefe04badc6e0ed7c2bc8009cc6a987c6c511d6e700c60efa688adcfe2a0 sources/kitemviews-5.29.0.tar.xz kjobwidgets v5.29.0-rc1 2540c769feda2e4355ebfa17f4bbfd367456fccc c8ee18380c1cae2ab48f007d10b4e85625bf7a2f2d5dba834f4f0bf0bb1e356a sources/kjobwidgets-5.29.0.tar.xz kjs v5.29.0-rc1 eeaed1a80b20fb128825d03c165d7344aee516f8 f340ded15b4e98070a04008456a8b135c0a2966f827fe1e17193306b3db5d4a4 sources/portingAids/kjs-5.29.0.tar.xz kjsembed v5.29.0-rc1 a4524fd7375361200b0ab1854c64ccca06decd96 2705a70b2de07adc88163c0510c890f991ef8691453eb93c51ce1012b3bab7bc sources/portingAids/kjsembed-5.29.0.tar.xz kmediaplayer v5.29.0-rc1 5013bdf4d08aa96700e1c5a2efa629aaba7b6b7a 5c41999a0cd1a78f76322dac39ee70196693fc7be546a0110bc4018684df4643 sources/portingAids/kmediaplayer-5.29.0.tar.xz knewstuff v5.29.0-rc1 f1e48eeb020addb03f7e5ecc2bf01d1516ae78ed 8165785151bb8cce05e43d306b2bbe0bf4a8eb81940c999b5a14901bdabdd3b1 sources/knewstuff-5.29.0.tar.xz knotifications v5.29.0-rc1 3330b3c572b5a3c5bb8c6f01aa8b0a1d6bb79c2a 68a4feb7a504bd3f1f7301bec9541e6dff52d801ae74274ec091a373c5d1662d sources/knotifications-5.29.0.tar.xz knotifyconfig v5.29.0-rc1 377953b73c5fc635cf22bd47779e18d2a9073c05 9cb4a084a5a136397de695a1dc64430ef2cc321ba11e449b604b84e59e104bcd sources/knotifyconfig-5.29.0.tar.xz kpackage v5.29.0-rc1 a87c425dc6ca3e4b2f03e014e4b0776844cdf82b daa12adaba53c707f087351935f3ef4207e1b26e3343c41ab2a6750f96e3ffc1 sources/kpackage-5.29.0.tar.xz kparts v5.29.0-rc1 d010cba3a50bd27eccf804d32e0dee2bd8417f78 61c3fed62a6830191e9d7b23be40814e7de2b48c2ab3f40f919eeb86cb57372b sources/kparts-5.29.0.tar.xz kpeople v5.29.0-rc1 594d4270568958da2aa92850fb39dd4740fffa02 e869dd6080ea619d641e9b1c50ffec320fb8164ba87c518e4b49c4858b044ba7 sources/kpeople-5.29.0.tar.xz kplotting v5.29.0-rc1 a1b48883435522a6c69a5c2633ac4e6fd7ac3473 0b0ff1734b377de4e8eb08bab466363cb0ba3fde6bfb05afd27d4b178b0bdf1f sources/kplotting-5.29.0.tar.xz kpty v5.29.0-rc1 82fb6ab7be7c5baec5c4b4140eb8da878eac2e7e f1c077b1c15fb7182c1272fd311ee5c51bf8de149b7f63ddcce4a557c6c36821 sources/kpty-5.29.0.tar.xz kross v5.29.0-rc1 279f2e7d03589df9edf74aac3eed06687c92dab0 1b886258b219b494c86c6add8a8b4bd17d2a9f3a17ad2375f026a1b1a3a9d7e0 sources/portingAids/kross-5.29.0.tar.xz krunner v5.29.0-rc1 ab4888dd531fb14ab5461726f5cac572162892d4 1d8fa44211300c28471098fa97f987899858343845be79bfb966049586a05fce sources/krunner-5.29.0.tar.xz kservice v5.29.0-rc1 13da7b320228eb38b15801b214ae058c50be0dd9 8796ff345f09ac422abbc752b441ceee2f6113a591e68e7c10e4a2cad9838010 sources/kservice-5.29.0.tar.xz ktexteditor v5.29.0-rc1 4a74a65bebd55e62d7bb8082ad2cea897d090ff7 5ab58db532955e762ef8698a075bd44fbb39dd8136f037484edbf7854cfa79a6 sources/ktexteditor-5.29.0.tar.xz ktextwidgets v5.29.0-rc1 933b02793648f6f0f685c2fe6c40b333cd25ced4 47fcec17d6d1d7f9b55e776e8ae0abd55b16de78f74424e7ea5c842ca6623c86 sources/ktextwidgets-5.29.0.tar.xz kunitconversion v5.29.0-rc1 76a983c18ddd46e6ee1df44c001e9f1f685579b0 67dfa40e9e362834a2c711c7b87ebfe0d7268bdcc9c056584728c21bf9e8f5ef sources/kunitconversion-5.29.0.tar.xz kwallet v5.29.0-rc1 696e7bd8600f5d908275054b8021f04f90a2651b 81f1d7593857e6b05614cab1fc11e9f6ce34cd0272773e8ddde2aff33eb24c96 sources/kwallet-5.29.0.tar.xz kwayland v5.29.0-rc1 6ac406d03c8f33cfa98d1c0160ffeec1ec375d0e e957dcbf32fe2c846ea11d82ece7519b7a513eaa9eb8021befa2c690ded9e957 sources/kwayland-5.29.0.tar.xz kwidgetsaddons v5.29.0-rc1 2812831f55c91026d2d6fc1f3c220a1f15c85936 4d0c209fae36f0342aeae4f3d2f402a89566eab1cee0afa5e612c88ae5d01ba6 sources/kwidgetsaddons-5.29.0.tar.xz kwindowsystem v5.29.0-rc1 28d7a1e708574710459c9146d83e0f94842d7149 361eebfebc753019d3b507c5b758dfb878c032b41c9062930bc46239618e7fa5 sources/kwindowsystem-5.29.0.tar.xz kxmlgui v5.29.0-rc1 19689d14bd0eda2966baee01e0a0a128c2d71a93 00bf6c5fad99162e9367d5125aa684a26db7fc9c83fcd44e2e824a547c8405c1 sources/kxmlgui-5.29.0.tar.xz kxmlrpcclient v5.29.0-rc1 af937c692cf9740be95f6dde46ce876dcdfc3581 629dc2d17b1e4f89fe0074010dc8b4c53269f9be426e432826b23c0a5a243c27 sources/kxmlrpcclient-5.29.0.tar.xz modemmanager-qt v5.29.0-rc1 40c6bcc95cf92775c6ee264ff20efd1a960d39b6 2def2b5b63d8a703c5d02c8c276717aeaaba1e326963cf1e2a50f58e32a63522 sources/modemmanager-qt-5.29.0.tar.xz networkmanager-qt v5.29.0-rc1 a15b12574fd887b3eef326d2c3fc5395dccbeb29 6a595c36cdb93c33398cbc3b76613aace64c0106ed08b88d25a8d0fbc0f6a24e sources/networkmanager-qt-5.29.0.tar.xz oxygen-icons5 v5.29.0-rc1 9ccf79d20eef9e2d089ce641d812a6c34471a994 933c226ba028578a67da4091e70990abb06831b665ee0fe6aef137fb1ded32c9 sources/oxygen-icons5-5.29.0.tar.xz plasma-framework v5.29.0-rc1 0db679218fe905c060d0d1de3036ee480bb39822 303b65207bd3fae01ff89cd521f7b58141c0ab0bc672d8d0acc5d4fd4a0c64b0 sources/plasma-framework-5.29.0.tar.xz prison v5.29.0-rc1 ce95eab9a2e525f9fd59abb93f976f03a0579573 f4e4d5badd8bbefb0e78f27640d80453e475a710a866339dd165c2dec37c8741 sources/prison-5.29.0.tar.xz solid v5.29.0-rc1 997f2752b2d47ce3b8b293fa7ad9ac870e96ffb1 3371263a1e66d3f82e933d876577444886fd781f0056440b946b84901576c907 sources/solid-5.29.0.tar.xz sonnet v5.29.0-rc1 4319dfc3a6b15c5d3cf9077ff819fbd604fee3c9 20358de0d45387f44260c3e6f8df012d661b4446293cbb3823c978e3a8766965 sources/sonnet-5.29.0.tar.xz syntax-highlighting v5.29.0-rc1 edeeeb8a872eade6c96c948296f123ef82f60dae cbcca052a1ad79b4d1ed1209d6f8e9ba0c3812dc158b26c4a8232a8d879c7839 sources/syntax-highlighting-5.29.0.tar.xz threadweaver v5.29.0-rc1 fcb7374df312f84efebb081e345e7cd1f7179de8 e60982c55c6d31a47e3072e21caaedaa6d9df1d37f96a00071c350f29bc9896a sources/threadweaver-5.29.0.tar.xz From lueck at hube-lueck.de Sun Dec 4 11:28:50 2016 From: lueck at hube-lueck.de (Burkhard =?ISO-8859-1?Q?L=FCck?=) Date: Sun, 04 Dec 2016 12:28:50 +0100 Subject: RFC: Move kommander, kcoloredit, kfax + kiconedit to unmaintained Message-ID: <3141097.NPuCCy7GC8@tuxedo> kommander: * add_definitions(-DQT3_SUPPORT -DQT3_SUPPORT_WARNINGS) in CMakeLists.txt, see https://cgit.kde.org/kommander.git/tree/CMakeLists.txt * last non maintenance commit from 2010, see https://cgit.kde.org/ kommander.git/log/ * subdirs editor, examples, pluginmanager, working not build kcoloredit: * last non maintenance commit from 2010, see https://cgit.kde.org/ kcoloredit.git/log/ * no debian package, see https://packages.debian.org/search? keywords=kcoloredit&searchon=names&suite=all§ion=all kiconedit: * last non maintenance commit 9 years ago, see https://websvn.kde.org/trunk/ extragear/graphics/kiconedit/ * no debian package, see https://packages.debian.org/search? keywords=kiconedit&searchon=names&suite=all§ion=all kfax: * add_definitions (-DQT3_SUPPORT -DQT3_SUPPORT_WARNINGS) in CMakeLists.txt, see https://websvn.kde.org/trunk/extragear/graphics/kfax/CMakeLists.txt? revision=1188173&view=markup * last non maintenance commit 9 years ago, see https://websvn.kde.org/trunk/ extragear/graphics/kfax/ * no debian package, see https://packages.debian.org/search? keywords=kfax&searchon=names&suite=all§ion=all -- Burkhard Lück From hrvoje.senjan at gmail.com Sun Dec 4 22:42:44 2016 From: hrvoje.senjan at gmail.com (=?utf-8?B?xaF1bXNraQ==?=) Date: Sun, 04 Dec 2016 23:42:44 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: <1544539.SQJqS6oqim@linux-t46v.suse> References: <1544539.SQJqS6oqim@linux-t46v.suse> Message-ID: <2073109.QVV9MSHRA6@shumarija> On nedjelja, 4. prosinca 2016. 00:37:52 CET David Faure wrote: > Dear packagers, > > KDE Frameworks 5.29.0 has been uploaded to the usual place. > > New framework: prison > > Public release next Saturday. > > Thanks for the packaging work! kconfig (r129382) breaks compilation of kdevplatform: http://paste.opensuse.org/82016854 Cheers, Hrvoje From bcooksley at kde.org Sun Dec 4 23:06:41 2016 From: bcooksley at kde.org (Ben Cooksley) Date: Mon, 5 Dec 2016 12:06:41 +1300 Subject: RFC: Move kommander, kcoloredit, kfax + kiconedit to unmaintained In-Reply-To: <3141097.NPuCCy7GC8@tuxedo> References: <3141097.NPuCCy7GC8@tuxedo> Message-ID: On Mon, Dec 5, 2016 at 12:28 AM, Burkhard Lück wrote: > kommander: > > * add_definitions(-DQT3_SUPPORT -DQT3_SUPPORT_WARNINGS) in CMakeLists.txt, see > https://cgit.kde.org/kommander.git/tree/CMakeLists.txt > > * last non maintenance commit from 2010, see https://cgit.kde.org/ > kommander.git/log/ > > * subdirs editor, examples, pluginmanager, working not build > > kcoloredit: > > * last non maintenance commit from 2010, see https://cgit.kde.org/ > kcoloredit.git/log/ > > * no debian package, see https://packages.debian.org/search? > keywords=kcoloredit&searchon=names&suite=all§ion=all > > kiconedit: > > * last non maintenance commit 9 years ago, see https://websvn.kde.org/trunk/ > extragear/graphics/kiconedit/ > > * no debian package, see https://packages.debian.org/search? > keywords=kiconedit&searchon=names&suite=all§ion=all > > kfax: > > * add_definitions (-DQT3_SUPPORT -DQT3_SUPPORT_WARNINGS) in CMakeLists.txt, > see https://websvn.kde.org/trunk/extragear/graphics/kfax/CMakeLists.txt? > revision=1188173&view=markup > > * last non maintenance commit 9 years ago, see https://websvn.kde.org/trunk/ > extragear/graphics/kfax/ > > * no debian package, see https://packages.debian.org/search? > keywords=kfax&searchon=names&suite=all§ion=all +1 to all of these moves from my perspective. > > -- > Burkhard Lück > Regards, Ben Cooksley KDE Sysadmin From faure at kde.org Mon Dec 5 08:08:52 2016 From: faure at kde.org (David Faure) Date: Mon, 05 Dec 2016 09:08:52 +0100 Subject: RFC: Move kommander, kcoloredit, kfax + kiconedit to unmaintained In-Reply-To: References: <3141097.NPuCCy7GC8@tuxedo> Message-ID: <2555358.xzfsuUi6TR@linux-t46v.suse> On lundi 5 décembre 2016 12:06:41 CET Ben Cooksley wrote: > On Mon, Dec 5, 2016 at 12:28 AM, Burkhard Lück wrote: > > kommander: > > > > * add_definitions(-DQT3_SUPPORT -DQT3_SUPPORT_WARNINGS) in CMakeLists.txt, > > see https://cgit.kde.org/kommander.git/tree/CMakeLists.txt > > > > * last non maintenance commit from 2010, see https://cgit.kde.org/ > > kommander.git/log/ > > > > * subdirs editor, examples, pluginmanager, working not build > > > > kcoloredit: > > > > * last non maintenance commit from 2010, see https://cgit.kde.org/ > > kcoloredit.git/log/ > > > > * no debian package, see https://packages.debian.org/search? > > keywords=kcoloredit&searchon=names&suite=all§ion=all > > > > kiconedit: > > > > * last non maintenance commit 9 years ago, see > > https://websvn.kde.org/trunk/ extragear/graphics/kiconedit/ > > > > * no debian package, see https://packages.debian.org/search? > > keywords=kiconedit&searchon=names&suite=all§ion=all > > > > kfax: > > > > * add_definitions (-DQT3_SUPPORT -DQT3_SUPPORT_WARNINGS) in > > CMakeLists.txt, > > see https://websvn.kde.org/trunk/extragear/graphics/kfax/CMakeLists.txt? > > revision=1188173&view=markup > > > > * last non maintenance commit 9 years ago, see > > https://websvn.kde.org/trunk/ extragear/graphics/kfax/ > > > > * no debian package, see https://packages.debian.org/search? > > keywords=kfax&searchon=names&suite=all§ion=all > > +1 to all of these moves from my perspective. Makes sense to me too. - kiconedit is superseded by kolourpaint, - kcoloredit is new to me, who needs to manage color palettes? Well, maybe graphists, it would be interesting to get feedback from one. Is there a KDE ML where we can ask? If it's useful, maybe someone will step up to maintain it. - kfax was useful ... a long time ago ;) - (never used kommander) -- David Faure, faure at kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 From faure at kde.org Mon Dec 5 08:20:03 2016 From: faure at kde.org (David Faure) Date: Mon, 05 Dec 2016 09:20:03 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: <2073109.QVV9MSHRA6@shumarija> References: <1544539.SQJqS6oqim@linux-t46v.suse> <2073109.QVV9MSHRA6@shumarija> Message-ID: <3087301.6OpjFanbeG@linux-t46v.suse> On dimanche 4 décembre 2016 23:42:44 CET šumski wrote: > On nedjelja, 4. prosinca 2016. 00:37:52 CET David Faure wrote: > > Dear packagers, > > > > KDE Frameworks 5.29.0 has been uploaded to the usual place. > > > > New framework: prison > > > > Public release next Saturday. > > > > Thanks for the packaging work! > > kconfig (r129382) breaks compilation of kdevplatform: > http://paste.opensuse.org/82016854 Indeed (but it's not the change from RR 129382, it's commit cd4e650 from https://phabricator.kde.org/D3386 Seems to come from Inherits=BaseClass while BaseClass doesn't use arg="true". Here's a testcase for the kconfig unittests. Martin, can you take a look? -- David Faure, faure at kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 -------------- next part -------------- A non-text attachment was scrubbed... Name: kconfig_testcase.diff Type: text/x-patch Size: 1617 bytes Desc: not available URL: From aacid at kde.org Mon Dec 5 11:45:54 2016 From: aacid at kde.org (Albert Astals Cid) Date: Mon, 05 Dec 2016 12:45:54 +0100 Subject: stable sr l10n-kf5 fails to cmake - was - Re: www/sites/www In-Reply-To: References: <2216718.WIo3RoWTLX@xps> Message-ID: <1528811.gPJu0U3Scj@xps> El dissabte, 3 de desembre de 2016, a les 13:16:16 CET, Chusslove Illich va escriure: > >> [: Antonio Rojas :] > >> > >> CMake Error at 5/sr/data/CMakeLists.txt:1 (add_subdirectory): > >> The source directory > >> > >> /build/kde-l10n/src/kde-l10n-sr-16.11.90/5/sr/data/_custominstall > >> > >> does not contain a CMakeLists.txt file. > > > > [: Albert Astals Cid :] > > You need to either: > > * Add a dummy CMakeLists.txt file > > * Go back to the previous situation those files where not in a folder > > * Somehow teach autogen.sh about folders it has to ignore (that seems > > less desirable tbh). > > Sorry for the trouble. I moved these custom install files to a > subdirectory, because Luigi needed some way of recognizing them for > making applications translation tarballs. Adding dummy CMakeLists.txt > doesn't work, because autogen.sh deletes it at this depth (it preserves > them only one level below). The needed change to scripts/autogen.sh is > small though, what do you say about it? Seems very hardcoded/specific tbh. If we're going to go the hardcoding way we may even "properly document somewhere" that every folder starting with _ will be ignored or something? Cheers, Albert > > Index: scripts/autogen.sh > =================================================================== > --- scripts/autogen.sh (revision 1476293) > +++ scripts/autogen.sh (working copy) > @@ -184,7 +184,7 @@ > # remove old CMakeLists.txt > rm -f $dir/data/CMakeLists.txt; > echo "add_subdirectory(data)" >> $dir/CMakeLists.txt > - dirs=`cd $dir/data && find * -maxdepth 0 -type d -not -empty | > fgrep -v .svn` + dirs=`cd $dir/data && find * -maxdepth 0 -type d > -not -empty | fgrep -v .svn | fgrep -v _custominstall` for dir2 in $dirs; > do > echo "add_subdirectory($dir2)" >> $dir/data/CMakeLists.txt > rm -f $dir/data/$dir2/CMakeLists.txt; From luigi.toscano at tiscali.it Mon Dec 5 14:20:40 2016 From: luigi.toscano at tiscali.it (Luigi Toscano) Date: Mon, 05 Dec 2016 15:20:40 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: <1544539.SQJqS6oqim@linux-t46v.suse> References: <1544539.SQJqS6oqim@linux-t46v.suse> Message-ID: <2237656.arXacNC6VM@whitebase.usersys.redhat.com> On Sunday, 4 December 2016 00:37:52 CET you wrote: > Dear packagers, > > KDE Frameworks 5.29.0 has been uploaded to the usual place. > > New framework: prison > > Public release next Saturday. > As reported on IRC, the tarball (and the tag) of kdelibs4support contains unrelated translations. The reported error is: pkg-static: kf5-kdelibs4support-5.29.0 conflicts with kf5-kio-5.29.0 (installs files into the same place). Problematic file: /usr/local/share/doc/HTML/ca/ kcontrol5/cache/index.cache.bz2 but I think it applies for all languages, and not only for kcontrol5/cache. That file should be only in kio. Ciao -- Luigi From jr at jriddell.org Mon Dec 5 15:41:39 2016 From: jr at jriddell.org (Jonathan Riddell) Date: Mon, 5 Dec 2016 15:41:39 +0000 Subject: KDE Frameworks 5.29.0 In-Reply-To: <3087301.6OpjFanbeG@linux-t46v.suse> References: <1544539.SQJqS6oqim@linux-t46v.suse> <2073109.QVV9MSHRA6@shumarija> <3087301.6OpjFanbeG@linux-t46v.suse> Message-ID: On 5 December 2016 at 08:20, David Faure wrote: > On dimanche 4 décembre 2016 23:42:44 CET šumski wrote: >> On nedjelja, 4. prosinca 2016. 00:37:52 CET David Faure wrote: >> > Dear packagers, >> > >> > KDE Frameworks 5.29.0 has been uploaded to the usual place. >> > >> > New framework: prison >> > >> > Public release next Saturday. >> > >> > Thanks for the packaging work! >> >> kconfig (r129382) breaks compilation of kdevplatform: >> http://paste.opensuse.org/82016854 > > Indeed (but it's not the change from RR 129382, it's commit cd4e650 from > https://phabricator.kde.org/D3386 Looks to now be fixed on the kdevplatform side http://build.neon.kde.org/view/1%20stable%20%E2%9A%9B%20git%20stable/job/xenial_stable_kde-std_kdevplatform/ Jonathan From mgraesslin at kde.org Mon Dec 5 17:40:46 2016 From: mgraesslin at kde.org (=?UTF-8?Q?Martin_Gr=C3=A4=C3=9Flin?=) Date: Mon, 05 Dec 2016 18:40:46 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: <3087301.6OpjFanbeG@linux-t46v.suse> References: <1544539.SQJqS6oqim@linux-t46v.suse> <2073109.QVV9MSHRA6@shumarija> <3087301.6OpjFanbeG@linux-t46v.suse> Message-ID: Am 2016-12-05 09:20, schrieb David Faure: > On dimanche 4 décembre 2016 23:42:44 CET šumski wrote: >> On nedjelja, 4. prosinca 2016. 00:37:52 CET David Faure wrote: >> > Dear packagers, >> > >> > KDE Frameworks 5.29.0 has been uploaded to the usual place. >> > >> > New framework: prison >> > >> > Public release next Saturday. >> > >> > Thanks for the packaging work! >> >> kconfig (r129382) breaks compilation of kdevplatform: >> http://paste.opensuse.org/82016854 > > Indeed (but it's not the change from RR 129382, it's commit cd4e650 > from > https://phabricator.kde.org/D3386 > > Seems to come from Inherits=BaseClass while BaseClass doesn't use > arg="true". > > Here's a testcase for the kconfig unittests. Martin, can you take a > look? The earliest I can have a look is probably on Friday, I'm sorry. My suggestion is to revert my two commits and I'll redo for next frameworks. Cheers Martin From faure at kde.org Wed Dec 7 09:08:18 2016 From: faure at kde.org (David Faure) Date: Wed, 07 Dec 2016 10:08:18 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: References: <1544539.SQJqS6oqim@linux-t46v.suse> <3087301.6OpjFanbeG@linux-t46v.suse> Message-ID: <2628105.TNu1ETs8t9@linux-t46v.suse> On lundi 5 décembre 2016 18:40:46 CET Martin Gräßlin wrote: > Am 2016-12-05 09:20, schrieb David Faure: > > On dimanche 4 décembre 2016 23:42:44 CET šumski wrote: > >> On nedjelja, 4. prosinca 2016. 00:37:52 CET David Faure wrote: > >> > Dear packagers, > >> > > >> > KDE Frameworks 5.29.0 has been uploaded to the usual place. > >> > > >> > New framework: prison > >> > > >> > Public release next Saturday. > >> > > >> > Thanks for the packaging work! > >> > >> kconfig (r129382) breaks compilation of kdevplatform: > >> http://paste.opensuse.org/82016854 > > > > Indeed (but it's not the change from RR 129382, it's commit cd4e650 > > from > > https://phabricator.kde.org/D3386 > > > > Seems to come from Inherits=BaseClass while BaseClass doesn't use > > arg="true". > > > > Here's a testcase for the kconfig unittests. Martin, can you take a > > look? > > The earliest I can have a look is probably on Friday, I'm sorry. > > My suggestion is to revert my two commits and I'll redo for next > frameworks. OK, done. New git tag and tarball: kconfig v5.29.0-rc2 47f7e954a58ba5538d055e2f75e483cade48ee8a d6c12e0908de1b91529de15e75a52c9974685c91b423d5b5abeb06f261d0fa47 sources/kconfig-5.29.0.tar.xz -- David Faure, faure at kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 From aacid at kde.org Wed Dec 7 19:10:40 2016 From: aacid at kde.org (Albert Astals Cid) Date: Wed, 07 Dec 2016 20:10:40 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: <2628105.TNu1ETs8t9@linux-t46v.suse> References: <1544539.SQJqS6oqim@linux-t46v.suse> <2628105.TNu1ETs8t9@linux-t46v.suse> Message-ID: <1620708.GjgYUAm3I3@xps> El dimecres, 7 de desembre de 2016, a les 10:08:18 CET, David Faure va escriure: > On lundi 5 décembre 2016 18:40:46 CET Martin Gräßlin wrote: > > Am 2016-12-05 09:20, schrieb David Faure: > > > On dimanche 4 décembre 2016 23:42:44 CET šumski wrote: > > >> On nedjelja, 4. prosinca 2016. 00:37:52 CET David Faure wrote: > > >> > Dear packagers, > > >> > > > >> > KDE Frameworks 5.29.0 has been uploaded to the usual place. > > >> > > > >> > New framework: prison > > >> > > > >> > Public release next Saturday. > > >> > > > >> > Thanks for the packaging work! > > >> > > >> kconfig (r129382) breaks compilation of kdevplatform: > > >> http://paste.opensuse.org/82016854 > > > > > > Indeed (but it's not the change from RR 129382, it's commit cd4e650 > > > from > > > https://phabricator.kde.org/D3386 > > > > > > Seems to come from Inherits=BaseClass while BaseClass doesn't use > > > arg="true". > > > > > > Here's a testcase for the kconfig unittests. Martin, can you take a > > > look? > > > > The earliest I can have a look is probably on Friday, I'm sorry. > > > > My suggestion is to revert my two commits and I'll redo for next > > frameworks. > > OK, done. New git tag and tarball: > > kconfig v5.29.0-rc2 > 47f7e954a58ba5538d055e2f75e483cade48ee8a > d6c12e0908de1b91529de15e75a52c9974685c91b423d5b5abeb06f261d0fa47 > sources/kconfig-5.29.0.tar.xz Acoording to kfunk the thing that broke kdevplatform wasn't really kconfigs fault but a side effect of kdevplatform code not being very good. I haven't read any of the diffs so i can't comment if this should be reverted or not, but just bringing in some of the IRC context i read. Cheers, Albert From kfunk at kde.org Wed Dec 7 20:06:11 2016 From: kfunk at kde.org (Kevin Funk) Date: Wed, 07 Dec 2016 21:06:11 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: <1620708.GjgYUAm3I3@xps> References: <1544539.SQJqS6oqim@linux-t46v.suse> <2628105.TNu1ETs8t9@linux-t46v.suse> <1620708.GjgYUAm3I3@xps> Message-ID: <2755539.WWBhE4bsgl@kerberos> On Wednesday, 7 December 2016 20:10:40 CET Albert Astals Cid wrote: > El dimecres, 7 de desembre de 2016, a les 10:08:18 CET, David Faure va > > escriure: > > On lundi 5 décembre 2016 18:40:46 CET Martin Gräßlin wrote: > > > Am 2016-12-05 09:20, schrieb David Faure: > > > > On dimanche 4 décembre 2016 23:42:44 CET šumski wrote: > > > >> On nedjelja, 4. prosinca 2016. 00:37:52 CET David Faure wrote: > > > >> > Dear packagers, > > > >> > > > > >> > KDE Frameworks 5.29.0 has been uploaded to the usual place. > > > >> > > > > >> > New framework: prison > > > >> > > > > >> > Public release next Saturday. > > > >> > > > > >> > Thanks for the packaging work! > > > >> > > > >> kconfig (r129382) breaks compilation of kdevplatform: > > > >> http://paste.opensuse.org/82016854 > > > > > > > > Indeed (but it's not the change from RR 129382, it's commit cd4e650 > > > > from > > > > https://phabricator.kde.org/D3386 > > > > > > > > Seems to come from Inherits=BaseClass while BaseClass doesn't use > > > > arg="true". > > > > > > > > Here's a testcase for the kconfig unittests. Martin, can you take a > > > > look? > > > > > > The earliest I can have a look is probably on Friday, I'm sorry. > > > > > > My suggestion is to revert my two commits and I'll redo for next > > > frameworks. > > > > OK, done. New git tag and tarball: > > > > kconfig v5.29.0-rc2 > > 47f7e954a58ba5538d055e2f75e483cade48ee8a > > d6c12e0908de1b91529de15e75a52c9974685c91b423d5b5abeb06f261d0fa47 > > sources/kconfig-5.29.0.tar.xz > > Acoording to kfunk the thing that broke kdevplatform wasn't really kconfigs > fault but a side effect of kdevplatform code not being very good. Heya, the patch restoring the kdevplatform build with KF5 5.29: https://cgit.kde.org/kdevplatform.git/commit/? id=e84645d1694bdad7f179cd41babce723fe07aa63 The code in kdevplatform is a bit special, it's probably the only place in whole KDE which broke due to the recent changes in kconfig. I don't see an easy migration path, even if you introduce said change in a later kconfig release. I don't mind if you leave kconfig as-is. But that's probably something for dfaure to decide. Cheers, Kevin > I haven't read any of the diffs so i can't comment if this should be > reverted or not, but just bringing in some of the IRC context i read. > > Cheers, > Albert -- Kevin Funk | kfunk at kde.org | http://kfunk.org -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 163 bytes Desc: This is a digitally signed message part. URL: From faure at kde.org Thu Dec 8 08:32:13 2016 From: faure at kde.org (David Faure) Date: Thu, 08 Dec 2016 09:32:13 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: <2755539.WWBhE4bsgl@kerberos> References: <1544539.SQJqS6oqim@linux-t46v.suse> <1620708.GjgYUAm3I3@xps> <2755539.WWBhE4bsgl@kerberos> Message-ID: <3829392.sfYuVvfz2T@linux-t46v.suse> On mercredi 7 décembre 2016 21:06:11 CET Kevin Funk wrote: > On Wednesday, 7 December 2016 20:10:40 CET Albert Astals Cid wrote: > > El dimecres, 7 de desembre de 2016, a les 10:08:18 CET, David Faure va > > > > escriure: > > > On lundi 5 décembre 2016 18:40:46 CET Martin Gräßlin wrote: > > > > Am 2016-12-05 09:20, schrieb David Faure: > > > > > On dimanche 4 décembre 2016 23:42:44 CET šumski wrote: > > > > >> On nedjelja, 4. prosinca 2016. 00:37:52 CET David Faure wrote: > > > > >> > Dear packagers, > > > > >> > > > > > >> > KDE Frameworks 5.29.0 has been uploaded to the usual place. > > > > >> > > > > > >> > New framework: prison > > > > >> > > > > > >> > Public release next Saturday. > > > > >> > > > > > >> > Thanks for the packaging work! > > > > >> > > > > >> kconfig (r129382) breaks compilation of kdevplatform: > > > > >> http://paste.opensuse.org/82016854 > > > > > > > > > > Indeed (but it's not the change from RR 129382, it's commit cd4e650 > > > > > from > > > > > https://phabricator.kde.org/D3386 > > > > > > > > > > Seems to come from Inherits=BaseClass while BaseClass doesn't use > > > > > arg="true". > > > > > > > > > > Here's a testcase for the kconfig unittests. Martin, can you take a > > > > > look? > > > > > > > > The earliest I can have a look is probably on Friday, I'm sorry. > > > > > > > > My suggestion is to revert my two commits and I'll redo for next > > > > frameworks. > > > > > > OK, done. New git tag and tarball: > > > > > > kconfig v5.29.0-rc2 > > > 47f7e954a58ba5538d055e2f75e483cade48ee8a > > > d6c12e0908de1b91529de15e75a52c9974685c91b423d5b5abeb06f261d0fa47 > > > sources/kconfig-5.29.0.tar.xz > > > > Acoording to kfunk the thing that broke kdevplatform wasn't really > > kconfigs > > fault but a side effect of kdevplatform code not being very good. > > Heya, > > the patch restoring the kdevplatform build with KF5 5.29: > https://cgit.kde.org/kdevplatform.git/commit/? > id=e84645d1694bdad7f179cd41babce723fe07aa63 > > The code in kdevplatform is a bit special, it's probably the only place in > whole KDE which broke due to the recent changes in kconfig. I don't see an > easy migration path, even if you introduce said change in a later kconfig > release. > > I don't mind if you leave kconfig as-is. But that's probably something for > dfaure to decide. Well, the change to kdevplatform isn't released yet, so kconfig 5.29-rc1 would break compilation of the current kdevplatform releases. Also, the fact that I'm able to write a kconfig unittest that doesn't compile tells me that something isn't right with these kconfig changes --- unless it can be proven that what I'm doing in that new test is not meaningful and is (now) forbidden, in which case it should at least be documented. This is certainly worth another month of careful thinking rather than rushing this into 5.29 now that it proved to be not 100% perfect. (I don't know enough about kconfig_compiler semantics to judge myself whether the testcase I wrote should work, or should be documented as broken). -- David Faure, faure at kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 From bgupta at kde.org Thu Dec 8 11:19:57 2016 From: bgupta at kde.org (Boudhayan Gupta) Date: Thu, 8 Dec 2016 16:49:57 +0530 Subject: Backporting Wayland support patches into Spectacle/16.12 In-Reply-To: <1775936.BxM6uUNv1A@xps> References: <1775936.BxM6uUNv1A@xps> Message-ID: I can confirm that on master nothing is broken. CC-ing the whole thing to release-team. On 5 December 2016 at 17:03, Albert Astals Cid wrote: > El diumenge, 4 de desembre de 2016, a les 10:25:49 CET, Boudhayan Gupta va > escriure: >> Hi Albert, > > I sincerely prefer you didn't ask me. We have a release-team mailing list to > discuss release stuff like this. > > But the answer is very simple, is it a bugfix? And if it is, how confident are > you that you're not brekaing things that work? > > Cheers, > Albert > >> >> Martin has been kind enough to introduce support for screen-shooting >> in Wayland to Spectacle. Unfortunately, it landed after 16.12 was >> branched out. >> >> I'd like to backport those patches into 16.12 so that when Plasma 5.9 >> comes out in January, Spectacle is good and ready with preliminary >> screenshooting support. >> >> Can I? >> >> -- Boudhayan > > From aacid at kde.org Thu Dec 8 23:27:01 2016 From: aacid at kde.org (Albert Astals Cid) Date: Fri, 09 Dec 2016 00:27:01 +0100 Subject: Backporting Wayland support patches into Spectacle/16.12 In-Reply-To: References: <1775936.BxM6uUNv1A@xps> Message-ID: <1925595.ACimKHJQmT@xps> El dijous, 8 de desembre de 2016, a les 16:49:57 CET, Boudhayan Gupta va escriure: > I can confirm that on master nothing is broken. > > CC-ing the whole thing to release-team. I already told you, if it's a bugfix, why have you not commited it? Unless you bring new dependencies or new strings, why do you need permission to commit a bugfix to a stable branch? Cheers, Albert > > On 5 December 2016 at 17:03, Albert Astals Cid wrote: > > El diumenge, 4 de desembre de 2016, a les 10:25:49 CET, Boudhayan Gupta va > > > > escriure: > >> Hi Albert, > > > > I sincerely prefer you didn't ask me. We have a release-team mailing list > > to discuss release stuff like this. > > > > But the answer is very simple, is it a bugfix? And if it is, how confident > > are you that you're not brekaing things that work? > > > > Cheers, > > > > Albert > >> > >> Martin has been kind enough to introduce support for screen-shooting > >> in Wayland to Spectacle. Unfortunately, it landed after 16.12 was > >> branched out. > >> > >> I'd like to backport those patches into 16.12 so that when Plasma 5.9 > >> comes out in January, Spectacle is good and ready with preliminary > >> screenshooting support. > >> > >> Can I? > >> > >> -- Boudhayan From aacid at kde.org Fri Dec 9 11:18:19 2016 From: aacid at kde.org (Albert Astals Cid) Date: Fri, 09 Dec 2016 12:18:19 +0100 Subject: KDE Applications 16.12.0 packages available for packagers Message-ID: <1540435.zciKPnytZj@xps> At the usual location. Haven't had time to compile yet, will start now. REVISIONS_AND_HASHES file at https://paste.kde.org/paclv5d4w Public release next week thursday. Cheers, Albert From luigi.toscano at tiscali.it Fri Dec 9 21:59:29 2016 From: luigi.toscano at tiscali.it (Luigi Toscano) Date: Fri, 9 Dec 2016 22:59:29 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: <2237656.arXacNC6VM@whitebase.usersys.redhat.com> References: <1544539.SQJqS6oqim@linux-t46v.suse> <2237656.arXacNC6VM@whitebase.usersys.redhat.com> Message-ID: <584B2941.7080905@tiscali.it> Luigi Toscano ha scritto: > On Sunday, 4 December 2016 00:37:52 CET you wrote: >> Dear packagers, >> >> KDE Frameworks 5.29.0 has been uploaded to the usual place. >> >> New framework: prison >> >> Public release next Saturday. >> > > As reported on IRC, the tarball (and the tag) of kdelibs4support contains > unrelated translations. > > The reported error is: > pkg-static: kf5-kdelibs4support-5.29.0 conflicts with kf5-kio-5.29.0 (installs > files into the same place). Problematic file: /usr/local/share/doc/HTML/ca/ > kcontrol5/cache/index.cache.bz2 > > but I think it applies for all languages, and not only for kcontrol5/cache. > That file should be only in kio. Please remember to fix it before the release tomorrow. -- Luigi From aacid at kde.org Fri Dec 9 22:08:43 2016 From: aacid at kde.org (Albert Astals Cid) Date: Fri, 09 Dec 2016 23:08:43 +0100 Subject: new okular tarball - was - Re: KDE Applications 16.12.0 packages available for packagers In-Reply-To: <1540435.zciKPnytZj@xps> References: <1540435.zciKPnytZj@xps> Message-ID: <1631422.1o9Ao3v5de@xps> El divendres, 9 de desembre de 2016, a les 12:18:19 CET, Albert Astals Cid va escriure: > At the usual location. > > Haven't had time to compile yet, will start now. > > REVISIONS_AND_HASHES file at https://paste.kde.org/paclv5d4w > > Public release next week thursday. I fucked up with the okular versioning, new tarball is up. okular Applications/16.12 a3e0e630e27a3bab3325540cb42829ac254b5d81 6dd55badaa1dbdacd5bc412a2f34c5f027e51873c89166a6f8c6015608120f29 sources/okular-16.12.0.tar.xz Cheers, Albert > > Cheers, > Albert From mgraesslin at kde.org Sat Dec 10 08:52:06 2016 From: mgraesslin at kde.org (Martin Graesslin) Date: Sat, 10 Dec 2016 09:52:06 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: <3829392.sfYuVvfz2T@linux-t46v.suse> References: <1544539.SQJqS6oqim@linux-t46v.suse> <2755539.WWBhE4bsgl@kerberos> <3829392.sfYuVvfz2T@linux-t46v.suse> Message-ID: <1973112.fCljAcmqW1@martin-desktop> On Thursday, December 8, 2016 9:32:13 AM CET David Faure wrote: > On mercredi 7 décembre 2016 21:06:11 CET Kevin Funk wrote: > > On Wednesday, 7 December 2016 20:10:40 CET Albert Astals Cid wrote: > > > El dimecres, 7 de desembre de 2016, a les 10:08:18 CET, David Faure va > > > > > > escriure: > > > > On lundi 5 décembre 2016 18:40:46 CET Martin Gräßlin wrote: > > > > > Am 2016-12-05 09:20, schrieb David Faure: > > > > > > On dimanche 4 décembre 2016 23:42:44 CET šumski wrote: > > > > > >> On nedjelja, 4. prosinca 2016. 00:37:52 CET David Faure wrote: > > > > > >> > Dear packagers, > > > > > >> > > > > > > >> > KDE Frameworks 5.29.0 has been uploaded to the usual place. > > > > > >> > > > > > > >> > New framework: prison > > > > > >> > > > > > > >> > Public release next Saturday. > > > > > >> > > > > > > >> > Thanks for the packaging work! > > > > > >> > > > > > >> kconfig (r129382) breaks compilation of kdevplatform: > > > > > >> http://paste.opensuse.org/82016854 > > > > > > > > > > > > Indeed (but it's not the change from RR 129382, it's commit > > > > > > cd4e650 > > > > > > from > > > > > > https://phabricator.kde.org/D3386 > > > > > > > > > > > > Seems to come from Inherits=BaseClass while BaseClass doesn't use > > > > > > arg="true". > > > > > > > > > > > > Here's a testcase for the kconfig unittests. Martin, can you take > > > > > > a > > > > > > look? > > > > > > > > > > The earliest I can have a look is probably on Friday, I'm sorry. > > > > > > > > > > My suggestion is to revert my two commits and I'll redo for next > > > > > frameworks. > > > > > > > > OK, done. New git tag and tarball: > > > > > > > > kconfig v5.29.0-rc2 > > > > 47f7e954a58ba5538d055e2f75e483cade48ee8a > > > > d6c12e0908de1b91529de15e75a52c9974685c91b423d5b5abeb06f261d0fa47 > > > > sources/kconfig-5.29.0.tar.xz > > > > > > Acoording to kfunk the thing that broke kdevplatform wasn't really > > > kconfigs > > > fault but a side effect of kdevplatform code not being very good. > > > > Heya, > > > > the patch restoring the kdevplatform build with KF5 5.29: > > https://cgit.kde.org/kdevplatform.git/commit/? > > > > id=e84645d1694bdad7f179cd41babce723fe07aa63 > > > > The code in kdevplatform is a bit special, it's probably the only place in > > whole KDE which broke due to the recent changes in kconfig. I don't see an > > easy migration path, even if you introduce said change in a later kconfig > > release. > > > > I don't mind if you leave kconfig as-is. But that's probably something for > > dfaure to decide. > > Well, the change to kdevplatform isn't released yet, so kconfig 5.29-rc1 > would break compilation of the current kdevplatform releases. > > Also, the fact that I'm able to write a kconfig unittest that doesn't > compile tells me that something isn't right with these kconfig changes --- > unless it can be proven that what I'm doing in that new test is not > meaningful and is (now) forbidden, in which case it should at least be > documented. This is certainly worth another month of careful thinking > rather than rushing this into 5.29 now that it proved to be not 100% > perfect. I investigated and can prove now that the test is not meaningful: it doesn't compile on master either. See https://paste.kde.org/po6oahg5p The problem is the "Inherits" - it doesn't really specify the conditions. All we have in the documentation is "Class the generated class inherits from. This class must inherit KConfigSkeleton." But inheriting from KConfigSkeleton is not enough as the test case and the kdevelop example shows. It must have the same ctors as KConfigSkeleton available for the inheriting class. That's the problem with the autotest and the problem with kdevelop's case. There the ctor existed, but was private instead of public. Given that I think my change can go in, but we also should specify more clearly the Inherits requirements. Cheers Martin -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 195 bytes Desc: This is a digitally signed message part. URL: From tcberner at freebsd.org Sat Dec 10 12:03:56 2016 From: tcberner at freebsd.org (Tobias C. Berner) Date: Sat, 10 Dec 2016 13:03:56 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: <1973112.fCljAcmqW1@martin-desktop> References: <1544539.SQJqS6oqim@linux-t46v.suse> <2755539.WWBhE4bsgl@kerberos> <3829392.sfYuVvfz2T@linux-t46v.suse> <1973112.fCljAcmqW1@martin-desktop> Message-ID: Hi there There are still conflicts with the localization files, for example: pkg-static: nb-kde5-l10n-16.12.0 conflicts with kf5-ki18n-5.29.0 (installs files into the same place). Problematic file: /usr/local/share/locale/nb/LC_SCRIPTS/ki18n5/ki18n5.js I think the one between kdelibs4support and kio is also not yet fixed: pkg-static: kf5-kdelibs4support-5.29.0 conflicts with kf5-kio-5.29.0 (installs files into the same place). Problematic file: /usr/local/share/doc/HTML/ca/kcontrol5/cache/index.cache.bz2 mfg Tobias On 10 December 2016 at 09:52, Martin Graesslin wrote: > On Thursday, December 8, 2016 9:32:13 AM CET David Faure wrote: > > On mercredi 7 décembre 2016 21:06:11 CET Kevin Funk wrote: > > > On Wednesday, 7 December 2016 20:10:40 CET Albert Astals Cid wrote: > > > > El dimecres, 7 de desembre de 2016, a les 10:08:18 CET, David Faure > va > > > > > > > > escriure: > > > > > On lundi 5 décembre 2016 18:40:46 CET Martin Gräßlin wrote: > > > > > > Am 2016-12-05 09:20, schrieb David Faure: > > > > > > > On dimanche 4 décembre 2016 23:42:44 CET šumski wrote: > > > > > > >> On nedjelja, 4. prosinca 2016. 00:37:52 CET David Faure wrote: > > > > > > >> > Dear packagers, > > > > > > >> > > > > > > > >> > KDE Frameworks 5.29.0 has been uploaded to the usual place. > > > > > > >> > > > > > > > >> > New framework: prison > > > > > > >> > > > > > > > >> > Public release next Saturday. > > > > > > >> > > > > > > > >> > Thanks for the packaging work! > > > > > > >> > > > > > > >> kconfig (r129382) breaks compilation of kdevplatform: > > > > > > >> http://paste.opensuse.org/82016854 > > > > > > > > > > > > > > Indeed (but it's not the change from RR 129382, it's commit > > > > > > > cd4e650 > > > > > > > from > > > > > > > https://phabricator.kde.org/D3386 > > > > > > > > > > > > > > Seems to come from Inherits=BaseClass while BaseClass doesn't > use > > > > > > > arg="true". > > > > > > > > > > > > > > Here's a testcase for the kconfig unittests. Martin, can you > take > > > > > > > a > > > > > > > look? > > > > > > > > > > > > The earliest I can have a look is probably on Friday, I'm sorry. > > > > > > > > > > > > My suggestion is to revert my two commits and I'll redo for next > > > > > > frameworks. > > > > > > > > > > OK, done. New git tag and tarball: > > > > > > > > > > kconfig v5.29.0-rc2 > > > > > 47f7e954a58ba5538d055e2f75e483cade48ee8a > > > > > d6c12e0908de1b91529de15e75a52c9974685c91b423d5b5abeb06f261d0fa47 > > > > > sources/kconfig-5.29.0.tar.xz > > > > > > > > Acoording to kfunk the thing that broke kdevplatform wasn't really > > > > kconfigs > > > > fault but a side effect of kdevplatform code not being very good. > > > > > > Heya, > > > > > > the patch restoring the kdevplatform build with KF5 5.29: > > > https://cgit.kde.org/kdevplatform.git/commit/? > > > > > > id=e84645d1694bdad7f179cd41babce723fe07aa63 > > > > > > The code in kdevplatform is a bit special, it's probably the only > place in > > > whole KDE which broke due to the recent changes in kconfig. I don't > see an > > > easy migration path, even if you introduce said change in a later > kconfig > > > release. > > > > > > I don't mind if you leave kconfig as-is. But that's probably something > for > > > dfaure to decide. > > > > Well, the change to kdevplatform isn't released yet, so kconfig 5.29-rc1 > > would break compilation of the current kdevplatform releases. > > > > Also, the fact that I'm able to write a kconfig unittest that doesn't > > compile tells me that something isn't right with these kconfig changes > --- > > unless it can be proven that what I'm doing in that new test is not > > meaningful and is (now) forbidden, in which case it should at least be > > documented. This is certainly worth another month of careful thinking > > rather than rushing this into 5.29 now that it proved to be not 100% > > perfect. > > I investigated and can prove now that the test is not meaningful: it > doesn't > compile on master either. See https://paste.kde.org/po6oahg5p > > The problem is the "Inherits" - it doesn't really specify the conditions. > All > we have in the documentation is "Class the generated class inherits from. > This > class must inherit KConfigSkeleton." > > But inheriting from KConfigSkeleton is not enough as the test case and the > kdevelop example shows. It must have the same ctors as KConfigSkeleton > available for the inheriting class. That's the problem with the autotest > and > the problem with kdevelop's case. There the ctor existed, but was private > instead of public. > > Given that I think my change can go in, but we also should specify more > clearly the Inherits requirements. > > Cheers > Martin -------------- next part -------------- An HTML attachment was scrubbed... URL: From faure at kde.org Sat Dec 10 14:47:56 2016 From: faure at kde.org (David Faure) Date: Sat, 10 Dec 2016 15:47:56 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: <1973112.fCljAcmqW1@martin-desktop> References: <1544539.SQJqS6oqim@linux-t46v.suse> <3829392.sfYuVvfz2T@linux-t46v.suse> <1973112.fCljAcmqW1@martin-desktop> Message-ID: <4631355.CXWDN97hSM@linux-t46v.suse> On samedi 10 décembre 2016 09:52:06 CET Martin Graesslin wrote: > On Thursday, December 8, 2016 9:32:13 AM CET David Faure wrote: > > On mercredi 7 décembre 2016 21:06:11 CET Kevin Funk wrote: > > > On Wednesday, 7 December 2016 20:10:40 CET Albert Astals Cid wrote: > > > > El dimecres, 7 de desembre de 2016, a les 10:08:18 CET, David Faure va > > > > > > > > escriure: > > > > > On lundi 5 décembre 2016 18:40:46 CET Martin Gräßlin wrote: > > > > > > Am 2016-12-05 09:20, schrieb David Faure: > > > > > > > On dimanche 4 décembre 2016 23:42:44 CET šumski wrote: > > > > > > >> On nedjelja, 4. prosinca 2016. 00:37:52 CET David Faure wrote: > > > > > > >> > Dear packagers, > > > > > > >> > > > > > > > >> > KDE Frameworks 5.29.0 has been uploaded to the usual place. > > > > > > >> > > > > > > > >> > New framework: prison > > > > > > >> > > > > > > > >> > Public release next Saturday. > > > > > > >> > > > > > > > >> > Thanks for the packaging work! > > > > > > >> > > > > > > >> kconfig (r129382) breaks compilation of kdevplatform: > > > > > > >> http://paste.opensuse.org/82016854 > > > > > > > > > > > > > > Indeed (but it's not the change from RR 129382, it's commit > > > > > > > cd4e650 > > > > > > > from > > > > > > > https://phabricator.kde.org/D3386 > > > > > > > > > > > > > > Seems to come from Inherits=BaseClass while BaseClass doesn't > > > > > > > use > > > > > > > arg="true". > > > > > > > > > > > > > > Here's a testcase for the kconfig unittests. Martin, can you > > > > > > > take > > > > > > > a > > > > > > > look? > > > > > > > > > > > > The earliest I can have a look is probably on Friday, I'm sorry. > > > > > > > > > > > > My suggestion is to revert my two commits and I'll redo for next > > > > > > frameworks. > > > > > > > > > > OK, done. New git tag and tarball: > > > > > > > > > > kconfig v5.29.0-rc2 > > > > > 47f7e954a58ba5538d055e2f75e483cade48ee8a > > > > > d6c12e0908de1b91529de15e75a52c9974685c91b423d5b5abeb06f261d0fa47 > > > > > sources/kconfig-5.29.0.tar.xz > > > > > > > > Acoording to kfunk the thing that broke kdevplatform wasn't really > > > > kconfigs > > > > fault but a side effect of kdevplatform code not being very good. > > > > > > Heya, > > > > > > the patch restoring the kdevplatform build with KF5 5.29: > > > https://cgit.kde.org/kdevplatform.git/commit/? > > > > > > id=e84645d1694bdad7f179cd41babce723fe07aa63 > > > > > > The code in kdevplatform is a bit special, it's probably the only place > > > in > > > whole KDE which broke due to the recent changes in kconfig. I don't see > > > an > > > easy migration path, even if you introduce said change in a later > > > kconfig > > > release. > > > > > > I don't mind if you leave kconfig as-is. But that's probably something > > > for > > > dfaure to decide. > > > > Well, the change to kdevplatform isn't released yet, so kconfig 5.29-rc1 > > would break compilation of the current kdevplatform releases. > > > > Also, the fact that I'm able to write a kconfig unittest that doesn't > > compile tells me that something isn't right with these kconfig changes --- > > unless it can be proven that what I'm doing in that new test is not > > meaningful and is (now) forbidden, in which case it should at least be > > documented. This is certainly worth another month of careful thinking > > rather than rushing this into 5.29 now that it proved to be not 100% > > perfect. > > I investigated and can prove now that the test is not meaningful: it doesn't > compile on master either. See https://paste.kde.org/po6oahg5p Well, that only means my testcase is not good (sorry about that). KDevelop *did* compile, so clearly my testcase failed to emulate exactly what happened in kdevelop. > The problem is the "Inherits" - it doesn't really specify the conditions. > All we have in the documentation is "Class the generated class inherits > from. This class must inherit KConfigSkeleton." I see. > But inheriting from KConfigSkeleton is not enough as the test case and the > kdevelop example shows. It must have the same ctors as KConfigSkeleton > available for the inheriting class. This makes sense. But adding a new constructor to KConfigSkeleton cannot mean that suddenly the requirement on base classes used by Inherits changes to include a new constructor - that would make it a source incompatible change. So the requirement has to be more precise than "do whatever KConfigSkeleton does", which is not a fixed requirement (it can change over time). Instead the requirement has to be "you need a constructor that takes a QString" or whatever the requirement actually is. > That's the problem with the autotest and > the problem with kdevelop's case. There the ctor existed, but was private > instead of public. Yes, because it was not needed before. That's what I mean by this change being source incompatible. > Given that I think my change can go in, but we also should specify more > clearly the Inherits requirements. It's still a SIC. Which is only acceptable if what KDevelop was doing made no sense at all (e.g. broken behaviour at runtime). But from your description, it sounds to me like it did make sense, it's just that the change suddenly raises the requirements for base classes... Maybe InheritsV2 is needed (or the same idea with a better name). I.e. explicitly activating the new feature by saying "yes, my base class obeys version 2 of the requirement, go ahead". -- David Faure, faure at kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 From faure at kde.org Sat Dec 10 15:01:37 2016 From: faure at kde.org (David Faure) Date: Sat, 10 Dec 2016 16:01:37 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: <584B2941.7080905@tiscali.it> References: <1544539.SQJqS6oqim@linux-t46v.suse> <2237656.arXacNC6VM@whitebase.usersys.redhat.com> <584B2941.7080905@tiscali.it> Message-ID: <3890180.xYV6u6aW0s@linux-t46v.suse> On vendredi 9 décembre 2016 22:59:29 CET Luigi Toscano wrote: > Luigi Toscano ha scritto: > > On Sunday, 4 December 2016 00:37:52 CET you wrote: > >> Dear packagers, > >> > >> KDE Frameworks 5.29.0 has been uploaded to the usual place. > >> > >> New framework: prison > >> > >> Public release next Saturday. > > > > As reported on IRC, the tarball (and the tag) of kdelibs4support contains > > unrelated translations. > > > > The reported error is: > > pkg-static: kf5-kdelibs4support-5.29.0 conflicts with kf5-kio-5.29.0 > > (installs files into the same place). Problematic file: > > /usr/local/share/doc/HTML/ca/ kcontrol5/cache/index.cache.bz2 > > > > but I think it applies for all languages, and not only for > > kcontrol5/cache. > > That file should be only in kio. > > Please remember to fix it before the release tomorrow. Hmm yes, it seems nobody else is going to do it... OK, clearly the problem is that make_rc_tag.sh does this: for docsubdir_it in $checkout/docs/*; do [...] local docsubdir=`basename $docsubdir_it` [...] cp -a $docdir/$docsubdir $destdir/docs/ so it copies the entire set of kcontrol5 translated docbooks, now that the docbooks have been moved into a kcontrol5 subdir (Burkhard, commit e0c3945 in kio). I was hoping for a flat directory structure but it seems this isn't desired. I'll try modifying the script to run a recursive search on *.docbook and copy individual files over instead... -- David Faure, faure at kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 From lueck at hube-lueck.de Sat Dec 10 15:16:03 2016 From: lueck at hube-lueck.de (Burkhard =?ISO-8859-1?Q?L=FCck?=) Date: Sat, 10 Dec 2016 16:16:03 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: <3890180.xYV6u6aW0s@linux-t46v.suse> References: <1544539.SQJqS6oqim@linux-t46v.suse> <584B2941.7080905@tiscali.it> <3890180.xYV6u6aW0s@linux-t46v.suse> Message-ID: <9964872.qtyFLgfE60@tuxedo> Am Samstag, 10. Dezember 2016, 16:01:37 CET schrieb David Faure: > so it copies the entire set of kcontrol5 translated docbooks, now that the > docbooks have been moved into a kcontrol5 subdir (Burkhard, commit e0c3945 > in kio). We use the kcontrol5 subdir to generate the correct install paths for all translated docbooks via l10n-kf5/scripts/autogen.sh. -- Burkhard Lück From faure at kde.org Sat Dec 10 15:41:35 2016 From: faure at kde.org (David Faure) Date: Sat, 10 Dec 2016 16:41:35 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: References: <1544539.SQJqS6oqim@linux-t46v.suse> <1973112.fCljAcmqW1@martin-desktop> Message-ID: <6073286.fmjoNZ1Hx2@linux-t46v.suse> On samedi 10 décembre 2016 13:03:56 CET Tobias C. Berner wrote: > Hi there > > There are still conflicts with the localization files, for example: > > pkg-static: nb-kde5-l10n-16.12.0 conflicts with kf5-ki18n-5.29.0 (installs > files into the same place). Problematic file: > /usr/local/share/locale/nb/LC_SCRIPTS/ki18n5/ki18n5.js Isn't that bug in the -kde5-l10n-16.12 packages ? I'm pretty sure that it's on purpose that ki18n5/ki18n5.js is part of the ki18n5 package. The Applications release is supposed to skip anything related to frameworks, which this clearly is: l10n//scripts/frameworks/ki18n5/ > I think the one between kdelibs4support and kio is also not yet fixed: > > pkg-static: kf5-kdelibs4support-5.29.0 conflicts with kf5-kio-5.29.0 > (installs files into the same place). Problematic file: > /usr/local/share/doc/HTML/ca/kcontrol5/cache/index.cache.bz2 Fixed now. kio v5.29.0-rc2 a4d6b9d1533283c527a829a82c26934d94d23572 52ce0e402a466a82480ee6edeaeae36bdc3b254aece3210dd4273a2b57955c6b sources/kio-5.29.0.tar.xz kdelibs4support v5.29.0-rc2 991bf6e4990c9d87f2ae21a64e90b41693bae3be e1c3640bbcbd622ce65f88017976beeaddca2f17bf9a0314ec2d8fe91fa731f2 sources/portingAids/kdelibs4support-5.29.0.tar.xz IMHO this makes KF 5.29.0 ready for release, unless you guys find more conflicts. -- David Faure, faure at kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 From mgraesslin at kde.org Sat Dec 10 18:49:07 2016 From: mgraesslin at kde.org (Martin Graesslin) Date: Sat, 10 Dec 2016 19:49:07 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: <4631355.CXWDN97hSM@linux-t46v.suse> References: <1544539.SQJqS6oqim@linux-t46v.suse> <1973112.fCljAcmqW1@martin-desktop> <4631355.CXWDN97hSM@linux-t46v.suse> Message-ID: <2313305.ybl2eqJXEk@martin-desktop> On Saturday, December 10, 2016 3:47:56 PM CET David Faure wrote: > On samedi 10 décembre 2016 09:52:06 CET Martin Graesslin wrote: > > On Thursday, December 8, 2016 9:32:13 AM CET David Faure wrote: > > > On mercredi 7 décembre 2016 21:06:11 CET Kevin Funk wrote: > > > > On Wednesday, 7 December 2016 20:10:40 CET Albert Astals Cid wrote: > > > > > El dimecres, 7 de desembre de 2016, a les 10:08:18 CET, David Faure > > > > > va > > > > > > > > > > escriure: > > > > > > On lundi 5 décembre 2016 18:40:46 CET Martin Gräßlin wrote: > > > > > > > Am 2016-12-05 09:20, schrieb David Faure: > > > > > > > > On dimanche 4 décembre 2016 23:42:44 CET šumski wrote: > > > > > > > >> On nedjelja, 4. prosinca 2016. 00:37:52 CET David Faure wrote: > > > > > > > >> > Dear packagers, > > > > > > > >> > > > > > > > > >> > KDE Frameworks 5.29.0 has been uploaded to the usual place. > > > > > > > >> > > > > > > > > >> > New framework: prison > > > > > > > >> > > > > > > > > >> > Public release next Saturday. > > > > > > > >> > > > > > > > > >> > Thanks for the packaging work! > > > > > > > >> > > > > > > > >> kconfig (r129382) breaks compilation of kdevplatform: > > > > > > > >> http://paste.opensuse.org/82016854 > > > > > > > > > > > > > > > > Indeed (but it's not the change from RR 129382, it's commit > > > > > > > > cd4e650 > > > > > > > > from > > > > > > > > https://phabricator.kde.org/D3386 > > > > > > > > > > > > > > > > Seems to come from Inherits=BaseClass while BaseClass doesn't > > > > > > > > use > > > > > > > > arg="true". > > > > > > > > > > > > > > > > Here's a testcase for the kconfig unittests. Martin, can you > > > > > > > > take > > > > > > > > a > > > > > > > > look? > > > > > > > > > > > > > > The earliest I can have a look is probably on Friday, I'm sorry. > > > > > > > > > > > > > > My suggestion is to revert my two commits and I'll redo for next > > > > > > > frameworks. > > > > > > > > > > > > OK, done. New git tag and tarball: > > > > > > > > > > > > kconfig v5.29.0-rc2 > > > > > > 47f7e954a58ba5538d055e2f75e483cade48ee8a > > > > > > d6c12e0908de1b91529de15e75a52c9974685c91b423d5b5abeb06f261d0fa47 > > > > > > sources/kconfig-5.29.0.tar.xz > > > > > > > > > > Acoording to kfunk the thing that broke kdevplatform wasn't really > > > > > kconfigs > > > > > fault but a side effect of kdevplatform code not being very good. > > > > > > > > Heya, > > > > > > > > the patch restoring the kdevplatform build with KF5 5.29: > > > > https://cgit.kde.org/kdevplatform.git/commit/? > > > > > > > > id=e84645d1694bdad7f179cd41babce723fe07aa63 > > > > > > > > The code in kdevplatform is a bit special, it's probably the only > > > > place > > > > in > > > > whole KDE which broke due to the recent changes in kconfig. I don't > > > > see > > > > an > > > > easy migration path, even if you introduce said change in a later > > > > kconfig > > > > release. > > > > > > > > I don't mind if you leave kconfig as-is. But that's probably something > > > > for > > > > dfaure to decide. > > > > > > Well, the change to kdevplatform isn't released yet, so kconfig 5.29-rc1 > > > would break compilation of the current kdevplatform releases. > > > > > > Also, the fact that I'm able to write a kconfig unittest that doesn't > > > compile tells me that something isn't right with these kconfig changes > > > --- > > > unless it can be proven that what I'm doing in that new test is not > > > meaningful and is (now) forbidden, in which case it should at least be > > > documented. This is certainly worth another month of careful thinking > > > rather than rushing this into 5.29 now that it proved to be not 100% > > > perfect. > > > > I investigated and can prove now that the test is not meaningful: it > > doesn't compile on master either. See https://paste.kde.org/po6oahg5p > > Well, that only means my testcase is not good (sorry about that). > KDevelop *did* compile, so clearly my testcase failed to emulate exactly > what happened in kdevelop. > > > The problem is the "Inherits" - it doesn't really specify the conditions. > > All we have in the documentation is "Class the generated class inherits > > from. This class must inherit KConfigSkeleton." > > I see. > > > But inheriting from KConfigSkeleton is not enough as the test case and the > > kdevelop example shows. It must have the same ctors as KConfigSkeleton > > available for the inheriting class. > > This makes sense. But adding a new constructor to KConfigSkeleton cannot > mean that suddenly the requirement on base classes used by Inherits changes > to include a new constructor - that would make it a source incompatible > change. > > So the requirement has to be more precise than "do whatever KConfigSkeleton > does", which is not a fixed requirement (it can change over time). > > Instead the requirement has to be "you need a constructor that takes a > QString" or whatever the requirement actually is. I just created a phab request to update the documentation about that: https:// phabricator.kde.org/D3636 > > > That's the problem with the autotest and > > the problem with kdevelop's case. There the ctor existed, but was private > > instead of public. > > Yes, because it was not needed before. That's what I mean by this change > being source incompatible. > > > Given that I think my change can go in, but we also should specify more > > clearly the Inherits requirements. > > It's still a SIC. Which is only acceptable if what KDevelop was doing made > no sense at all (e.g. broken behaviour at runtime). But from your > description, it sounds to me like it did make sense, it's just that the > change suddenly raises the requirements for base classes... The code generated didn't match the description of what it would generate. To quote: "The \ tag may contain either the "name" attribute, which should be the name of the configuration file described, or the "arg" attribute, which, if set to "true", will allow you to pass the KSharedConfig::Ptr object to use." We have here the condition of arg="true" and the generated code did not follow that. If Singleton=true was set in kcfgc an incorrect ctor taking a QString as argument is generated. That is what my change addresses. So yes, anybody who used that was depending on a bug of kconfig compiler. One can argue that my change breaks SIC and I won't deny it. But the usage of the behavior was wrong. I can do a special casing for the (incorrect) kdevelop case to provide SIC, but it will mean that we get another incorrect code compilation. The special casing would have to be: * arg=true * Singleton=true * Inherits=true -> preserve old behavior. I doubt that we win anything by that except of making the code more complex and the behavior seemingly more random. So from my point of view breaking the incorrect behavior could be acceptable here. For reference I attached the relevant kcfg, kcfgc and generated files. I leave the decision to you. I don't mind doing the special casing, so if told I'll add it. Cheers Martin -------------- next part -------------- A non-text attachment was scrubbed... Name: projectfiltersettings.kcfg Type: application/xml Size: 386 bytes Desc: not available URL: -------------- next part -------------- File=projectfiltersettings.kcfg ClassName=ProjectFilterSettings Singleton=true UseEnumTypes=true SetUserTexts=true ItemAccessors=true Inherits=KDevelop::ProjectConfigSkeleton IncludeFiles=project/projectconfigskeleton.h -------------- next part -------------- A non-text attachment was scrubbed... Name: projectfiltersettings.cpp Type: text/x-c++src Size: 1327 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: projectfiltersettings.h Type: text/x-chdr Size: 657 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 195 bytes Desc: This is a digitally signed message part. URL: From faure at kde.org Sat Dec 10 20:10:29 2016 From: faure at kde.org (David Faure) Date: Sat, 10 Dec 2016 21:10:29 +0100 Subject: kconfig_compiler (Re: KDE Frameworks 5.29.0) In-Reply-To: <2313305.ybl2eqJXEk@martin-desktop> References: <1544539.SQJqS6oqim@linux-t46v.suse> <4631355.CXWDN97hSM@linux-t46v.suse> <2313305.ybl2eqJXEk@martin-desktop> Message-ID: <98762080.QIbLjeVbFo@linux-t46v.suse> On samedi 10 décembre 2016 19:49:07 CET Martin Graesslin wrote: > To quote: "The \ tag may contain either the "name" attribute, > which should be the name of the configuration file described, or the "arg" > attribute, which, if set to "true", will allow you to pass the > KSharedConfig::Ptr object to use." > > We have here the condition of arg="true" and the generated code did not > follow that. If Singleton=true was set in kcfgc an incorrect ctor taking a > QString as argument is generated. That is what my change addresses. > > So yes, anybody who used that was depending on a bug of kconfig compiler. OK, then that's a good reason for a bugfix indeed, even SIC. > One can argue that my change breaks SIC and I won't deny it. But the usage > of the behavior was wrong. > > I can do a special casing for the (incorrect) kdevelop case to provide SIC, > but it will mean that we get another incorrect code compilation. The special > casing would have to be: > * arg=true > * Singleton=true > * Inherits=true > -> preserve old behavior. I doubt that we win anything by that except of > making the code more complex and the behavior seemingly more random. Right, that doesn't sound good long term. > So from my point of view breaking the incorrect behavior could be acceptable > here. Yes, but after the next kdevplatform release, then, to avoid breaking compilation of released code. Is the kdevplatform bugfix getting into the final 16.12 release? If I read https://community.kde.org/Schedules/Applications/16.12_Release_Schedule correctly, there's still time to sneak it in if needed, before Dec 15. Then we can re-apply the kconfig patch for KF 5.30 (January). > I leave the decision to you. At this point it's actually a decision for the kconfig maintainer, Matthew Dawson. My job is to ensure the KF5 releases are SC/BC, which in this case can be reduced to "a SIC bugfix is acceptable if we leave time for kdevplatform to get a new release which won't be hit by this". -- David Faure, faure at kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 From nicolas.alvarez at gmail.com Sat Dec 10 20:17:10 2016 From: nicolas.alvarez at gmail.com (=?utf-8?Q?Nicol=C3=A1s_Alvarez?=) Date: Sat, 10 Dec 2016 17:17:10 -0300 Subject: kconfig_compiler (Re: KDE Frameworks 5.29.0) In-Reply-To: <98762080.QIbLjeVbFo@linux-t46v.suse> References: <1544539.SQJqS6oqim@linux-t46v.suse> <4631355.CXWDN97hSM@linux-t46v.suse> <2313305.ybl2eqJXEk@martin-desktop> <98762080.QIbLjeVbFo@linux-t46v.suse> Message-ID: <84FC09ED-CCAA-4074-96A7-29081EA698C5@gmail.com> > El 10 dic 2016, a las 17:10, David Faure escribió: > >> On samedi 10 décembre 2016 19:49:07 CET Martin Graesslin wrote: >> So from my point of view breaking the incorrect behavior could be acceptable >> here. > > Yes, but after the next kdevplatform release, then, to avoid breaking > compilation of released code. > > Is the kdevplatform bugfix getting into the final 16.12 release? > If I read > https://community.kde.org/Schedules/Applications/16.12_Release_Schedule > correctly, there's still time to sneak it in if needed, before Dec 15. KDevPlatform and KDevelop are extragear ;) The fix is already in the 5.0 branch, I guess we could release a v5.0.4 soon if needed. -- Nicolás From luigi.toscano at tiscali.it Sun Dec 11 17:11:25 2016 From: luigi.toscano at tiscali.it (Luigi Toscano) Date: Sun, 11 Dec 2016 18:11:25 +0100 Subject: Applications 16.12: fix for audiocd-kio translations Message-ID: <584D88BD.6030602@tiscali.it> Hi, I fixed the translations for audiocd-kio: https://commits.kde.org/audiocd-kio/3c56cb0a133f61a6cfbb034ab3eb483783c33740 Can this be included in the tarball? I added CCMAIL: release-team@ to the commit but I think that the attachment was too big. The commits add a new Messages.sh in the Applications/16.12 which extracts a new message, but it was an existing strings, so this does not break the string freeze. Ciao -- Luigi From null at kde.org Sun Dec 11 16:16:58 2016 From: null at kde.org (Luigi Toscano) Date: Sun, 11 Dec 2016 16:16:58 +0000 Subject: [audiocd-kio/Applications/16.12] /: Reenable translations after the KF5 port Message-ID: Git commit 3c56cb0a133f61a6cfbb034ab3eb483783c33740 by Luigi Toscano. Committed on 11/12/2016 at 16:16. Pushed by ltoscano into branch 'Applications/16.12'. Reenable translations after the KF5 port - explicitly link to KI18n; - set the application domain for the application (kio) and the libraries (plugins, kcm); - use ki18n_wrap_ui instead of qt5_wrap_ui to enable translations for UI files; - extract the message of the lame plugin (existing strings but not extracted for translation), fix a porting TODO. CCMAIL: release-team at kde.org CCMAIL: xiangzhai83 at gmail.com M +1 -0 CMakeLists.txt M +2 -0 audiocd.cpp M +4 -1 kcmaudiocd/CMakeLists.txt M +1 -1 kcmaudiocd/kcmaudiocd.cpp M +4 -1 plugins/flac/CMakeLists.txt A +3 -0 plugins/flac/Messages.sh M +0 -2 plugins/flac/encoderflac.cpp M +4 -1 plugins/lame/CMakeLists.txt M +4 -1 plugins/vorbis/CMakeLists.txt https://commits.kde.org/audiocd-kio/3c56cb0a133f61a6cfbb034ab3eb483783c33740 diff --git a/CMakeLists.txt b/CMakeLists.txt index baf25d8..292a6ff 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -14,6 +14,7 @@ set(KF5_DEP_VERSION "5.24.0") # handled by release scripts find_package(KF5 ${KF5_DEP_VERSION} REQUIRED COMPONENTS Config KDELibs4Support + I18n DocTools KIO CompactDisc diff --git a/audiocd.cpp b/audiocd.cpp index a20e79f..926308d 100644 --- a/audiocd.cpp +++ b/audiocd.cpp @@ -55,6 +55,7 @@ extern "C" #include #include #include +#include // CDDB #include #include @@ -67,6 +68,7 @@ using namespace AudioCD; int kdemain(int argc, char ** argv) { + KLocalizedString::setApplicationDomain("kio_audiocd"); // KApplication uses libkcddb which needs a valid kapp pointer // GUIenabled must be true as libkcddb sometimes wants to communicate // with the user diff --git a/kcmaudiocd/CMakeLists.txt b/kcmaudiocd/CMakeLists.txt index de7caeb..0a6e11e 100644 --- a/kcmaudiocd/CMakeLists.txt +++ b/kcmaudiocd/CMakeLists.txt @@ -1,3 +1,5 @@ +add_definitions(-DTRANSLATION_DOMAIN=\"kcmaudiocd\") + include_directories( ${CMAKE_CURRENT_SOURCE_DIR}/../plugins ${CMAKE_BINARY_DIR}/kioslave/audiocd/kcmaudiocd @@ -7,11 +9,12 @@ include_directories( set(kcm_audiocd_PART_SRCS kcmaudiocd.cpp) -qt5_wrap_ui(kcm_audiocd_PART_SRCS audiocdconfig.ui) +ki18n_wrap_ui(kcm_audiocd_PART_SRCS audiocdconfig.ui) add_library(kcm_audiocd ${kcm_audiocd_PART_SRCS}) target_link_libraries(kcm_audiocd + KF5::I18n KF5::KDELibs4Support audiocdplugins ) diff --git a/kcmaudiocd/kcmaudiocd.cpp b/kcmaudiocd/kcmaudiocd.cpp index 923f4f9..bc7cec7 100644 --- a/kcmaudiocd/kcmaudiocd.cpp +++ b/kcmaudiocd/kcmaudiocd.cpp @@ -22,7 +22,7 @@ #include #include -#include +#include #include #include #include diff --git a/plugins/flac/CMakeLists.txt b/plugins/flac/CMakeLists.txt index 73bfc9e..453a1ea 100644 --- a/plugins/flac/CMakeLists.txt +++ b/plugins/flac/CMakeLists.txt @@ -1,3 +1,5 @@ +add_definitions(-DTRANSLATION_DOMAIN=\"audiocd_encoder_flac\") + include_directories(${CMAKE_CURRENT_SOURCE_DIR}/.. ${FLAC_INCLUDE_DIR} ) ########### next target ############### @@ -7,7 +9,7 @@ add_definitions(-DHAVE_LIBFLAC) set(audiocd_encoder_flac_PART_SRCS encoderflac.cpp ) -qt5_wrap_ui(audiocd_encoder_flac_PART_SRCS encoderflacconfig.ui) +ki18n_wrap_ui(audiocd_encoder_flac_PART_SRCS encoderflacconfig.ui) kconfig_add_kcfg_files(audiocd_encoder_flac_PART_SRCS audiocd_flac_encoder.kcfgc) @@ -16,6 +18,7 @@ set_target_properties(audiocd_encoder_flac PROPERTIES PREFIX "${CMAKE_SHARED_LIB target_link_libraries(audiocd_encoder_flac ${FLAC_LIBRARIES} + KF5::I18n KF5::Cddb audiocdplugins ) diff --git a/plugins/flac/Messages.sh b/plugins/flac/Messages.sh new file mode 100644 index 0000000..a08fa6b --- /dev/null +++ b/plugins/flac/Messages.sh @@ -0,0 +1,3 @@ +#! /bin/sh +$EXTRACTRC *.ui *.kcfg >> rc.cpp +$XGETTEXT *.cpp -o $podir/audiocd_encoder_flac.pot diff --git a/plugins/flac/encoderflac.cpp b/plugins/flac/encoderflac.cpp index f04cea2..148f209 100644 --- a/plugins/flac/encoderflac.cpp +++ b/plugins/flac/encoderflac.cpp @@ -120,8 +120,6 @@ QWidget* EncoderFLAC::getConfigureWidget(KConfigSkeleton** manager) const { return NULL; #else (*manager) = Settings::self(); - // TODO: https://community.kde.org/Frameworks/Porting_Notes - //KGlobal::locale()->insertCatalog( QLatin1String( "audiocd_encoder_flac" )); return new EncoderFLACConfig(); #endif } diff --git a/plugins/lame/CMakeLists.txt b/plugins/lame/CMakeLists.txt index b378423..87f578c 100644 --- a/plugins/lame/CMakeLists.txt +++ b/plugins/lame/CMakeLists.txt @@ -1,3 +1,5 @@ +add_definitions(-DTRANSLATION_DOMAIN=\"audiocd_encoder_lame\") + include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..) FIND_PROGRAM(LAME_EXECUTABLE NAMES lame) @@ -10,7 +12,7 @@ endif(NOT LAME_EXECUTABLE) set(audiocd_encoder_lame_PART_SRCS encoderlame.cpp ) -qt5_wrap_ui(audiocd_encoder_lame_PART_SRCS encoderlameconfig.ui) +ki18n_wrap_ui(audiocd_encoder_lame_PART_SRCS encoderlameconfig.ui) kconfig_add_kcfg_files(audiocd_encoder_lame_PART_SRCS audiocd_lame_encoder.kcfgc) @@ -18,6 +20,7 @@ add_library(audiocd_encoder_lame ${audiocd_encoder_lame_PART_SRCS}) set_target_properties(audiocd_encoder_lame PROPERTIES PREFIX "${CMAKE_SHARED_LIBRARY_PREFIX}") target_link_libraries(audiocd_encoder_lame + KF5::I18n KF5::Cddb audiocdplugins ) diff --git a/plugins/vorbis/CMakeLists.txt b/plugins/vorbis/CMakeLists.txt index fad3845..8a07e93 100644 --- a/plugins/vorbis/CMakeLists.txt +++ b/plugins/vorbis/CMakeLists.txt @@ -1,10 +1,12 @@ +add_definitions(-DTRANSLATION_DOMAIN=\"audiocd_encoder_vorbis\") + include_directories(${CMAKE_CURRENT_SOURCE_DIR}/.. ${OGGVORBIS_INCLUDE_DIR} ${VORBIS_INCLUDE_DIR}) ########### next target ############### set(audiocd_encoder_vorbis_PART_SRCS encodervorbis.cpp) -qt5_wrap_ui(audiocd_encoder_vorbis_PART_SRCS encodervorbisconfig.ui) +ki18n_wrap_ui(audiocd_encoder_vorbis_PART_SRCS encodervorbisconfig.ui) kconfig_add_kcfg_files(audiocd_encoder_vorbis_PART_SRCS audiocd_vorbis_encoder.kcfgc) @@ -13,6 +15,7 @@ set_target_properties(audiocd_encoder_vorbis PROPERTIES PREFIX "${CMAKE_SHARED_L target_link_libraries(audiocd_encoder_vorbis ${OGGVORBIS_LIBRARIES} + KF5::I18n KF5::Cddb audiocdplugins ) From aacid at kde.org Sun Dec 11 22:31:41 2016 From: aacid at kde.org (Albert Astals Cid) Date: Sun, 11 Dec 2016 23:31:41 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: References: <1544539.SQJqS6oqim@linux-t46v.suse> <1973112.fCljAcmqW1@martin-desktop> Message-ID: <2648012.SHJdWvSsWe@xps> El dissabte, 10 de desembre de 2016, a les 13:03:56 CET, Tobias C. Berner va escriure: > Hi there > > There are still conflicts with the localization files, for example: > > pkg-static: nb-kde5-l10n-16.12.0 conflicts with kf5-ki18n-5.29.0 (installs > files into the same place). Problematic file: > /usr/local/share/locale/nb/LC_SCRIPTS/ki18n5/ki18n5.js I would appreaciate if you could use proper tarball names when reporting a conflict, there's nothing called nb-kde5-l10n-16.12.0 Cheers, Albert P.S: Yes, I'm smart enough to figure out the real tarball name, but if you do it right, saves everyone trouble when trying to it out. P.S.S: Yes, I'll fix it. From aacid at kde.org Sun Dec 11 23:43:00 2016 From: aacid at kde.org (Albert Astals Cid) Date: Mon, 12 Dec 2016 00:43:00 +0100 Subject: KDE Applications 16.12.0 packages available for packagers In-Reply-To: <1540435.zciKPnytZj@xps> References: <1540435.zciKPnytZj@xps> Message-ID: <1868353.DcuLvlzPUr@xps> El divendres, 9 de desembre de 2016, a les 12:18:19 CET, Albert Astals Cid va escriure: > At the usual location. > > Haven't had time to compile yet, will start now. > > REVISIONS_AND_HASHES file at https://paste.kde.org/paclv5d4w > > Public release next week thursday. > > Cheers, > Albert From aacid at kde.org Sun Dec 11 23:44:23 2016 From: aacid at kde.org (Albert Astals Cid) Date: Mon, 12 Dec 2016 00:44:23 +0100 Subject: new kde-l10n-nn and kde-l10n-nb pacakges - was - Re: KDE Applications 16.12.0 packages available for packagers In-Reply-To: <1540435.zciKPnytZj@xps> References: <1540435.zciKPnytZj@xps> Message-ID: <12557568.JOpecADumg@xps> New tarballs since it was wrongly contained some frameworks files. svn revision 1476806 8b7d178742429a59e97ff887ab42a3cc4b3eba775790227e01d189536e527bbb sources/kde-l10n/kde-l10n-nn-16.12.0.tar.xz svn revision 1476806 66c3915c4b600f3e6df02f2de0ded042e917bc5754af3069c2e651c9a692ba9a sources/kde-l10n/kde-l10n-nb-16.12.0.tar.xz Cheers, Albert El divendres, 9 de desembre de 2016, a les 12:18:19 CET, Albert Astals Cid va escriure: > At the usual location. > > Haven't had time to compile yet, will start now. > > REVISIONS_AND_HASHES file at https://paste.kde.org/paclv5d4w > > Public release next week thursday. > > Cheers, > Albert From aacid at kde.org Sun Dec 11 23:47:15 2016 From: aacid at kde.org (Albert Astals Cid) Date: Mon, 12 Dec 2016 00:47:15 +0100 Subject: new audiocd-kio tarball - was - Re: KDE Applications 16.12.0 packages available for packagers In-Reply-To: <1540435.zciKPnytZj@xps> References: <1540435.zciKPnytZj@xps> Message-ID: <2092047.3XfZ31VN8E@xps> Contains i18n improvements audiocd-kio Applications/16.12 3c56cb0a133f61a6cfbb034ab3eb483783c33740 e29c59512850aebdde476394713a58a9b1a1ead4a08d822d3ce0172bc720a391 sources/audiocd-kio-16.12.0.tar.xz Cheers, Albert El divendres, 9 de desembre de 2016, a les 12:18:19 CET, Albert Astals Cid va escriure: > At the usual location. > > Haven't had time to compile yet, will start now. > > REVISIONS_AND_HASHES file at https://paste.kde.org/paclv5d4w > > Public release next week thursday. > > Cheers, > Albert From luigi.toscano at tiscali.it Mon Dec 12 01:15:40 2016 From: luigi.toscano at tiscali.it (Luigi Toscano) Date: Mon, 12 Dec 2016 02:15:40 +0100 Subject: new audiocd-kio tarball - was - Re: KDE Applications 16.12.0 packages available for packagers In-Reply-To: <2092047.3XfZ31VN8E@xps> References: <1540435.zciKPnytZj@xps> <2092047.3XfZ31VN8E@xps> Message-ID: <584DFA3C.9080805@tiscali.it> Albert Astals Cid ha scritto: > Contains i18n improvements > > audiocd-kio Applications/16.12 Sorry for the last minute change: as briefly discussed on IRC, I lowered the version of libkcompactdisc, libkcddb and audiocd-kio to 5.0.0 instead of 16.07/16.08 (and related high soversion, which would have made impossible to lower it later). Everything seems to compile; please repackage those tarballs to the tip of Applications/16.12. Ciao -- Luigi From kfunk at kde.org Mon Dec 12 08:19:30 2016 From: kfunk at kde.org (Kevin Funk) Date: Mon, 12 Dec 2016 09:19:30 +0100 Subject: kconfig_compiler (Re: KDE Frameworks 5.29.0) In-Reply-To: <84FC09ED-CCAA-4074-96A7-29081EA698C5@gmail.com> References: <1544539.SQJqS6oqim@linux-t46v.suse> <98762080.QIbLjeVbFo@linux-t46v.suse> <84FC09ED-CCAA-4074-96A7-29081EA698C5@gmail.com> Message-ID: <4200494.YuXGXbmV1q@kerberos> On Saturday, 10 December 2016 17:17:10 CET Nicolás Alvarez wrote: > > El 10 dic 2016, a las 17:10, David Faure escribió: > >> On samedi 10 décembre 2016 19:49:07 CET Martin Graesslin wrote: > >> So from my point of view breaking the incorrect behavior could be > >> acceptable here. > > > > Yes, but after the next kdevplatform release, then, to avoid breaking > > compilation of released code. > > > > Is the kdevplatform bugfix getting into the final 16.12 release? > > If I read > > https://community.kde.org/Schedules/Applications/16.12_Release_Schedule > > correctly, there's still time to sneak it in if needed, before Dec 15. > > KDevPlatform and KDevelop are extragear ;) > > The fix is already in the 5.0 branch, I guess we could release a v5.0.4 soon > if needed. +1 We could do this in 1-2 weeks (would fit our schedule). I don't think we want to rush and release v5.0.4 right now though. That would be an almost identical release to v5.0.3. Cheers, Kevin -- Kevin Funk | kfunk at kde.org | http://kfunk.org -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 163 bytes Desc: This is a digitally signed message part. URL: From faure at kde.org Mon Dec 12 10:05:14 2016 From: faure at kde.org (David Faure) Date: Mon, 12 Dec 2016 11:05:14 +0100 Subject: kconfig_compiler (Re: KDE Frameworks 5.29.0) In-Reply-To: <4200494.YuXGXbmV1q@kerberos> References: <1544539.SQJqS6oqim@linux-t46v.suse> <84FC09ED-CCAA-4074-96A7-29081EA698C5@gmail.com> <4200494.YuXGXbmV1q@kerberos> Message-ID: <3086260.NFSYpqBn7M@linux-t46v.suse> On lundi 12 décembre 2016 09:19:30 CET Kevin Funk wrote: > On Saturday, 10 December 2016 17:17:10 CET Nicolás Alvarez wrote: > > > El 10 dic 2016, a las 17:10, David Faure escribió: > > >> On samedi 10 décembre 2016 19:49:07 CET Martin Graesslin wrote: > > >> So from my point of view breaking the incorrect behavior could be > > >> acceptable here. > > > > > > Yes, but after the next kdevplatform release, then, to avoid breaking > > > compilation of released code. > > > > > > Is the kdevplatform bugfix getting into the final 16.12 release? > > > If I read > > > https://community.kde.org/Schedules/Applications/16.12_Release_Schedule > > > correctly, there's still time to sneak it in if needed, before Dec 15. > > > > KDevPlatform and KDevelop are extragear ;) > > > > The fix is already in the 5.0 branch, I guess we could release a v5.0.4 > > soon if needed. > > +1 > > We could do this in 1-2 weeks (would fit our schedule). I don't think we > want to rush and release v5.0.4 right now though. That would be an almost > identical release to v5.0.3. You have one month, even ;) -- David Faure, faure at kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 From bugzilla_noreply at kde.org Mon Dec 12 23:27:19 2016 From: bugzilla_noreply at kde.org (Albert Astals Cid) Date: Mon, 12 Dec 2016 23:27:19 +0000 Subject: [kalzium] [Bug 373565] the name of libs have 'SOVERSION' (literally) in the name In-Reply-To: References: Message-ID: https://bugs.kde.org/show_bug.cgi?id=373565 Albert Astals Cid changed: What |Removed |Added ---------------------------------------------------------------------------- CC|aacid at kde.org |release-team at kde.org -- You are receiving this mail because: You are on the CC list for the bug. From aacid at kde.org Mon Dec 12 23:48:36 2016 From: aacid at kde.org (Albert Astals Cid) Date: Tue, 13 Dec 2016 00:48:36 +0100 Subject: new audiocd-kio tarball - was - Re: KDE Applications 16.12.0 packages available for packagers In-Reply-To: <584DFA3C.9080805@tiscali.it> References: <1540435.zciKPnytZj@xps> <2092047.3XfZ31VN8E@xps> <584DFA3C.9080805@tiscali.it> Message-ID: <1568163.IqQMMUeypf@xps> El dilluns, 12 de desembre de 2016, a les 2:15:40 CET, Luigi Toscano va escriure: > Albert Astals Cid ha scritto: > > Contains i18n improvements > > > > audiocd-kio Applications/16.12 > > Sorry for the last minute change: as briefly discussed on IRC, I lowered the > version of libkcompactdisc, libkcddb and audiocd-kio to 5.0.0 instead of > 16.07/16.08 (and related high soversion, which would have made impossible > to lower it later). > > Everything seems to compile; please repackage those tarballs to the tip of > Applications/16.12. The three tarballs have been re-rolled as suggested by Luigi. libkcompactdisc Applications/16.12 a6f253301ca25b88493829bb13649add5e6748e6 37f33c8e6e94e0fdadd844f4a0bb5de37fdabec5e457567652b24f24947d0652 sources/libkcompactdisc-16.12.0.tar.xz libkcddb Applications/16.12 705b0e737d257f18fe191fda6978d204d79a4f8d 4fe3ca97ad626ccee7e1e33b237df49c793ba058dbd48c623d4445d9da132b39 sources/libkcddb-16.12.0.tar.xz audiocd-kio Applications/16.12 b72ca04323f904aa60a10467734326babec3acac 9ed15f05176913e6bb235f5d01d7b1129d60da9be1328b0f8ad89beb54c48542 sources/audiocd-kio-16.12.0.tar.xz Cheers, Albert > > Ciao From aacid at kde.org Mon Dec 12 23:49:51 2016 From: aacid at kde.org (Albert Astals Cid) Date: Tue, 13 Dec 2016 00:49:51 +0100 Subject: new kgpg tarball - was - Re: KDE Applications 16.12.0 packages available for packagers In-Reply-To: <1540435.zciKPnytZj@xps> References: <1540435.zciKPnytZj@xps> Message-ID: <7975758.mxXgLvH1Hc@xps> The KF5 requirement was set too low compared to what the code needed. It's been updated. kgpg Applications/16.12 fee6927a7396bbf1a6a8d1ad04f3fe6a81881d08 1a0f5128919f0082be9b6818f095029abe1380976598ee30b9bc47e1480ec5ca sources/kgpg-16.12.0.tar.xz El divendres, 9 de desembre de 2016, a les 12:18:19 CET, Albert Astals Cid va escriure: > At the usual location. > > Haven't had time to compile yet, will start now. > > REVISIONS_AND_HASHES file at https://paste.kde.org/paclv5d4w > > Public release next week thursday. > > Cheers, > Albert From bugzilla_noreply at kde.org Tue Dec 13 00:00:03 2016 From: bugzilla_noreply at kde.org (Luigi Toscano) Date: Tue, 13 Dec 2016 00:00:03 +0000 Subject: [kalzium] [Bug 373565] the name of libs have 'SOVERSION' (literally) in the name In-Reply-To: References: Message-ID: https://bugs.kde.org/show_bug.cgi?id=373565 Luigi Toscano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |luigi.toscano at tiscali.it Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 --- Comment #2 from Luigi Toscano --- Both libraries use GENERIC_LIB_VERSION and GENERIC_LIB_SOVERSION, which were exported by kdelibs4. The fix could be easy. -- You are receiving this mail because: You are on the CC list for the bug. From luigi.toscano at tiscali.it Tue Dec 13 00:06:16 2016 From: luigi.toscano at tiscali.it (Luigi Toscano) Date: Tue, 13 Dec 2016 00:06:16 -0000 Subject: Review Request 129646: Fix the soname of kalzium internal libraries Message-ID: <20161213000616.16852.64777@mimi.kde.org> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129646/ ----------------------------------------------------------- Review request for KDE Edu, Release Team, Aleix Pol Gonzalez, and Andreas Cord-Landwehr. Bugs: 373565 http://bugs.kde.org/show_bug.cgi?id=373565 Repository: kalzium Description ------- GENERIC_LIB_VERSION and GENERIC_LIB_SOVERSION where exported by kdelibs4. Define local variables for the version of the libraries. Diffs ----- CMakeLists.txt 9844a34 compoundviewer/CMakeLists.txt 2109d84 libscience/CMakeLists.txt d7c23a4 Diff: https://git.reviewboard.kde.org/r/129646/diff/ Testing ------- Compiles, and now: -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0 -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5 -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so -- Set runtime path of "/opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0" to "/opt/kf5/lib/x86_64-linux-gnu" I could not test the other library (I should compile avogadro) but I suspect that it should be the same. Thanks, Luigi Toscano -------------- next part -------------- An HTML attachment was scrubbed... URL: From aleixpol at kde.org Tue Dec 13 00:19:36 2016 From: aleixpol at kde.org (Aleix Pol Gonzalez) Date: Tue, 13 Dec 2016 00:19:36 -0000 Subject: Review Request 129646: Fix the soname of kalzium internal libraries In-Reply-To: <20161213000616.16852.64777@mimi.kde.org> References: <20161213000616.16852.64777@mimi.kde.org> Message-ID: <20161213001936.16852.62762@mimi.kde.org> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129646/#review101400 ----------------------------------------------------------- CMakeLists.txt (line 66) This will need updating. How about using: ``` # KDE Application Version, managed by release script set (KDE_APPLICATIONS_VERSION_MAJOR "16") set (KDE_APPLICATIONS_VERSION_MINOR "12") set (KDE_APPLICATIONS_VERSION_MICRO "0") ``` Then have `set(LIBSOVERSION "${KDE_APPLICATIONS_VERSION_MAJOR}${KDE_APPLICATIONS_VERSION_MINOR}")` Sounds good to me if it's okay to keep track of changes. - Aleix Pol Gonzalez On Dec. 13, 2016, 1:06 a.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129646/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 1:06 a.m.) > > > Review request for KDE Edu, Release Team, Aleix Pol Gonzalez, and Andreas Cord-Landwehr. > > > Bugs: 373565 > http://bugs.kde.org/show_bug.cgi?id=373565 > > > Repository: kalzium > > > Description > ------- > > GENERIC_LIB_VERSION and GENERIC_LIB_SOVERSION where exported by kdelibs4. > Define local variables for the version of the libraries. > > > Diffs > ----- > > CMakeLists.txt 9844a34 > compoundviewer/CMakeLists.txt 2109d84 > libscience/CMakeLists.txt d7c23a4 > > Diff: https://git.reviewboard.kde.org/r/129646/diff/ > > > Testing > ------- > > Compiles, and now: > > -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0 > -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5 > -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so > -- Set runtime path of "/opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0" to "/opt/kf5/lib/x86_64-linux-gnu" > > I could not test the other library (I should compile avogadro) but I suspect that it should be the same. > > > Thanks, > > Luigi Toscano > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From luigi.toscano at tiscali.it Tue Dec 13 00:24:21 2016 From: luigi.toscano at tiscali.it (Luigi Toscano) Date: Tue, 13 Dec 2016 00:24:21 -0000 Subject: Review Request 129646: Fix the soname of kalzium internal libraries In-Reply-To: <20161213001936.16852.62762@mimi.kde.org> References: <20161213001936.16852.62762@mimi.kde.org> Message-ID: <20161213002421.16852.38062@mimi.kde.org> > On Dic. 13, 2016, 1:19 a.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 66 > > > > > > This will need updating. > > > > How about using: > > ``` > > # KDE Application Version, managed by release script > > set (KDE_APPLICATIONS_VERSION_MAJOR "16") > > set (KDE_APPLICATIONS_VERSION_MINOR "12") > > set (KDE_APPLICATIONS_VERSION_MICRO "0") > > ``` > > > > Then have > > `set(LIBSOVERSION "${KDE_APPLICATIONS_VERSION_MAJOR}${KDE_APPLICATIONS_VERSION_MINOR}")` I did the exactly opposite change on few kdemultimedia modules. It is true that it's more likely for those libraries to became part of Frameworks than those internal ones, and that starting with 16 (soon 17) means complications to go back to 5. But... not sure. - Luigi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129646/#review101400 ----------------------------------------------------------- On Dic. 13, 2016, 1:06 a.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129646/ > ----------------------------------------------------------- > > (Updated Dic. 13, 2016, 1:06 a.m.) > > > Review request for KDE Edu, Release Team, Aleix Pol Gonzalez, and Andreas Cord-Landwehr. > > > Bugs: 373565 > http://bugs.kde.org/show_bug.cgi?id=373565 > > > Repository: kalzium > > > Description > ------- > > GENERIC_LIB_VERSION and GENERIC_LIB_SOVERSION where exported by kdelibs4. > Define local variables for the version of the libraries. > > > Diffs > ----- > > CMakeLists.txt 9844a34 > compoundviewer/CMakeLists.txt 2109d84 > libscience/CMakeLists.txt d7c23a4 > > Diff: https://git.reviewboard.kde.org/r/129646/diff/ > > > Testing > ------- > > Compiles, and now: > > -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0 > -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5 > -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so > -- Set runtime path of "/opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0" to "/opt/kf5/lib/x86_64-linux-gnu" > > I could not test the other library (I should compile avogadro) but I suspect that it should be the same. > > > Thanks, > > Luigi Toscano > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From aleixpol at kde.org Tue Dec 13 00:38:14 2016 From: aleixpol at kde.org (Aleix Pol Gonzalez) Date: Tue, 13 Dec 2016 00:38:14 -0000 Subject: Review Request 129646: Fix the soname of kalzium internal libraries In-Reply-To: <20161213001936.16852.62762@mimi.kde.org> References: <20161213001936.16852.62762@mimi.kde.org> Message-ID: <20161213003814.16852.19971@mimi.kde.org> > On Dec. 13, 2016, 1:19 a.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 66 > > > > > > This will need updating. > > > > How about using: > > ``` > > # KDE Application Version, managed by release script > > set (KDE_APPLICATIONS_VERSION_MAJOR "16") > > set (KDE_APPLICATIONS_VERSION_MINOR "12") > > set (KDE_APPLICATIONS_VERSION_MICRO "0") > > ``` > > > > Then have > > `set(LIBSOVERSION "${KDE_APPLICATIONS_VERSION_MAJOR}${KDE_APPLICATIONS_VERSION_MINOR}")` > > Luigi Toscano wrote: > I did the exactly opposite change on few kdemultimedia modules. It is true that it's more likely for those libraries to became part of Frameworks than those internal ones, and that starting with 16 (soon 17) means complications to go back to 5. > But... not sure. If it becomes an actual framework the library will adopt the KF5 prefix (e.g. libKF5CoreAddons.so.5.28.0). - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129646/#review101400 ----------------------------------------------------------- On Dec. 13, 2016, 1:06 a.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129646/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 1:06 a.m.) > > > Review request for KDE Edu, Release Team, Aleix Pol Gonzalez, and Andreas Cord-Landwehr. > > > Bugs: 373565 > http://bugs.kde.org/show_bug.cgi?id=373565 > > > Repository: kalzium > > > Description > ------- > > GENERIC_LIB_VERSION and GENERIC_LIB_SOVERSION where exported by kdelibs4. > Define local variables for the version of the libraries. > > > Diffs > ----- > > CMakeLists.txt 9844a34 > compoundviewer/CMakeLists.txt 2109d84 > libscience/CMakeLists.txt d7c23a4 > > Diff: https://git.reviewboard.kde.org/r/129646/diff/ > > > Testing > ------- > > Compiles, and now: > > -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0 > -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5 > -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so > -- Set runtime path of "/opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0" to "/opt/kf5/lib/x86_64-linux-gnu" > > I could not test the other library (I should compile avogadro) but I suspect that it should be the same. > > > Thanks, > > Luigi Toscano > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From aleixpol at kde.org Tue Dec 13 00:45:35 2016 From: aleixpol at kde.org (Aleix Pol Gonzalez) Date: Tue, 13 Dec 2016 00:45:35 -0000 Subject: Review Request 129646: Fix the soname of kalzium internal libraries In-Reply-To: <20161213000616.16852.64777@mimi.kde.org> References: <20161213000616.16852.64777@mimi.kde.org> Message-ID: <20161213004535.16852.32036@mimi.kde.org> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129646/#review101403 ----------------------------------------------------------- Ship it! After discussing in IRC, let's do this. We can review the versioning depending on how development goes over time. - Aleix Pol Gonzalez On Dec. 13, 2016, 1:06 a.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129646/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 1:06 a.m.) > > > Review request for KDE Edu, Release Team, Aleix Pol Gonzalez, and Andreas Cord-Landwehr. > > > Bugs: 373565 > http://bugs.kde.org/show_bug.cgi?id=373565 > > > Repository: kalzium > > > Description > ------- > > GENERIC_LIB_VERSION and GENERIC_LIB_SOVERSION where exported by kdelibs4. > Define local variables for the version of the libraries. > > > Diffs > ----- > > CMakeLists.txt 9844a34 > compoundviewer/CMakeLists.txt 2109d84 > libscience/CMakeLists.txt d7c23a4 > > Diff: https://git.reviewboard.kde.org/r/129646/diff/ > > > Testing > ------- > > Compiles, and now: > > -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0 > -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5 > -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so > -- Set runtime path of "/opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0" to "/opt/kf5/lib/x86_64-linux-gnu" > > I could not test the other library (I should compile avogadro) but I suspect that it should be the same. > > > Thanks, > > Luigi Toscano > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla_noreply at kde.org Tue Dec 13 00:49:10 2016 From: bugzilla_noreply at kde.org (Unknown) Date: Tue, 13 Dec 2016 00:49:10 +0000 Subject: [kalzium] [Bug 373565] the name of libs have 'SOVERSION' (literally) in the name In-Reply-To: References: Message-ID: https://bugs.kde.org/show_bug.cgi?id=373565 Unknown changed: What |Removed |Added ---------------------------------------------------------------------------- Latest Commit| |https://commits.kde.org/kal | |zium/e16b0159acc01efcdc8b51 | |b04b8eb6303b16b0db Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #3 from Unknown --- Git commit e16b0159acc01efcdc8b51b04b8eb6303b16b0db by Luigi Toscano. Committed on 13/12/2016 at 00:05. Pushed by ltoscano into branch 'Applications/16.12'. Fix the soname of kalzium internal libraries GENERIC_LIB_VERSION and GENERIC_LIB_SOVERSION where exported by kdelibs4. Define local variables for the version of the libraries. M +5 -0 CMakeLists.txt M +2 -2 compoundviewer/CMakeLists.txt M +1 -1 libscience/CMakeLists.txt https://commits.kde.org/kalzium/e16b0159acc01efcdc8b51b04b8eb6303b16b0db -- You are receiving this mail because: You are on the CC list for the bug. From luigi.toscano at tiscali.it Tue Dec 13 00:51:15 2016 From: luigi.toscano at tiscali.it (Luigi Toscano) Date: Tue, 13 Dec 2016 00:51:15 -0000 Subject: Review Request 129646: Fix the soname of kalzium internal libraries In-Reply-To: <20161213000616.16852.64777@mimi.kde.org> References: <20161213000616.16852.64777@mimi.kde.org> Message-ID: <20161213005115.16852.48188@mimi.kde.org> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129646/ ----------------------------------------------------------- (Updated Dec. 13, 2016, 1:51 a.m.) Status ------ This change has been marked as submitted. Review request for KDE Edu, Release Team, Aleix Pol Gonzalez, and Andreas Cord-Landwehr. Bugs: 373565 http://bugs.kde.org/show_bug.cgi?id=373565 Repository: kalzium Description ------- GENERIC_LIB_VERSION and GENERIC_LIB_SOVERSION where exported by kdelibs4. Define local variables for the version of the libraries. Diffs ----- CMakeLists.txt 9844a34 compoundviewer/CMakeLists.txt 2109d84 libscience/CMakeLists.txt d7c23a4 Diff: https://git.reviewboard.kde.org/r/129646/diff/ Testing ------- Compiles, and now: -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0 -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so.5 -- Installing: /opt/kf5/lib/x86_64-linux-gnu/libscience.so -- Set runtime path of "/opt/kf5/lib/x86_64-linux-gnu/libscience.so.5.0.0" to "/opt/kf5/lib/x86_64-linux-gnu" I could not test the other library (I should compile avogadro) but I suspect that it should be the same. Thanks, Luigi Toscano -------------- next part -------------- An HTML attachment was scrubbed... URL: From pali.rohar at gmail.com Tue Dec 13 01:37:09 2016 From: pali.rohar at gmail.com (Pali =?utf-8?q?Roh=C3=A1r?=) Date: Tue, 13 Dec 2016 02:37:09 +0100 Subject: 16.12 release - correct Kopete version Message-ID: <201612130237.09883@pali> Hi! Now I pushed commit into kopete Application/16.12 branch which increase version from RC 1.10.90 to final 1.11.0. -- Pali Rohár pali.rohar at gmail.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part. URL: From xiang.zhai at i-soft.com.cn Tue Dec 13 06:45:29 2016 From: xiang.zhai at i-soft.com.cn (Leslie Zhai) Date: Tue, 13 Dec 2016 14:45:29 +0800 Subject: KDE Frameworks 5.29.0 Message-ID: <584F9909.1090609@i-soft.com.cn> Hi David, services/lex.l: In function 'KTraderParse_initFlex': services/lex.l:160:3: error: implicit declaration of function 'yy_switch_to_buffer' [-Werror=implicit-function-declaration] services/lex.l:160:24: error: implicit declaration of function 'yy_scan_string' [-Werror=implicit-function-declaration] services/lex.l: In function 'kiotraderwrap': services/lex.l:166:3: error: implicit declaration of function 'yy_delete_buffer' [-Werror=implicit-function-declaration] -- Regards, Leslie Zhai - a KDE developer https://git.reviewboard.kde.org/users/lesliezhai/ From xiang.zhai at i-soft.com.cn Tue Dec 13 07:15:56 2016 From: xiang.zhai at i-soft.com.cn (Leslie Zhai) Date: Tue, 13 Dec 2016 15:15:56 +0800 Subject: KDE Frameworks 5.29.0 In-Reply-To: <584F9909.1090609@i-soft.com.cn> References: <584F9909.1090609@i-soft.com.cn> Message-ID: please ignore it! unreproducable for ArchLinux! -- Regards, Leslie Zhai - a KDE developer https://git.reviewboard.kde.org/users/lesliezhai/ From xiang.zhai at i-soft.com.cn Tue Dec 13 07:52:12 2016 From: xiang.zhai at i-soft.com.cn (Leslie Zhai) Date: Tue, 13 Dec 2016 15:52:12 +0800 Subject: KDE Frameworks 5.29.0 Message-ID: <584FA8AC.4000802@i-soft.com.cn> It might be flex-2.6.2's issue https://github.com/westes/flex/issues/134 ArchLinux use flex-2.6.1 and it is OK for kservice-5.29.0 -- Regards, Leslie Zhai - a KDE developer https://git.reviewboard.kde.org/users/lesliezhai/ From mail at heiko-becker.de Tue Dec 13 08:35:33 2016 From: mail at heiko-becker.de (Heiko Becker) Date: Tue, 13 Dec 2016 09:35:33 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: <584FA8AC.4000802@i-soft.com.cn> References: <584FA8AC.4000802@i-soft.com.cn> Message-ID: Hello, On 12/13/16 08:52, Leslie Zhai wrote: > It might be flex-2.6.2's issue https://github.com/westes/flex/issues/134 > ArchLinux use flex-2.6.1 and it is OK for kservice-5.29.0 yeah, 2.6.2 broke quite a number of other packages: https://github.com/westes/flex/issues/113 Regards, Heiko From aacid at kde.org Tue Dec 13 11:39:55 2016 From: aacid at kde.org (Albert Astals Cid) Date: Tue, 13 Dec 2016 11:39:55 +0000 (UTC) Subject: 16.12 release - correct Kopete version In-Reply-To: <201612130237.09883@pali> References: <201612130237.09883@pali> Message-ID: <1954369009.3284299.1481629195153@mail.yahoo.com> Are you asking for the tarball to be recreated? Cheers,   Albert  On dt., des. 13, 2016 at 2:37, Pali Rohár wrote: Hi! Now I pushed commit into kopete Application/16.12 branch which increase version from RC 1.10.90 to final 1.11.0.-- Pali Rohár pali.rohar at gmail.com  -------------- next part -------------- An HTML attachment was scrubbed... URL: From aacid at kde.org Tue Dec 13 11:39:55 2016 From: aacid at kde.org (Albert Astals Cid) Date: Tue, 13 Dec 2016 11:39:55 +0000 (UTC) Subject: 16.12 release - correct Kopete version In-Reply-To: <201612130237.09883@pali> References: <201612130237.09883@pali> Message-ID: <1954369009.3284299.1481629195153@mail.yahoo.com> Are you asking for the tarball to be recreated? Cheers,   Albert  On dt., des. 13, 2016 at 2:37, Pali Rohár wrote: Hi! Now I pushed commit into kopete Application/16.12 branch which increase version from RC 1.10.90 to final 1.11.0.-- Pali Rohár pali.rohar at gmail.com  -------------- next part -------------- An HTML attachment was scrubbed... URL: From pali.rohar at gmail.com Tue Dec 13 12:34:31 2016 From: pali.rohar at gmail.com (Pali =?utf-8?q?Roh=C3=A1r?=) Date: Tue, 13 Dec 2016 13:34:31 +0100 Subject: 16.12 release - correct Kopete version In-Reply-To: <1954369009.3284299.1481629195153@mail.yahoo.com> References: <201612130237.09883@pali> <1954369009.3284299.1481629195153@mail.yahoo.com> Message-ID: <201612131334.31133@pali> Yes! On Tuesday 13 December 2016 12:39:55 Albert Astals Cid wrote: > Are you asking for the tarball to be recreated? > Cheers, Albert > On dt., des. 13, 2016 at 2:37, Pali Rohár > > wrote: Hi! Now I pushed commit into kopete > Application/16.12 branch which increase version from RC 1.10.90 to > final 1.11.0.-- > Pali Rohár > pali.rohar at gmail.com -- Pali Rohár pali.rohar at gmail.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part. URL: From aacid at kde.org Tue Dec 13 20:55:48 2016 From: aacid at kde.org (Albert Astals Cid) Date: Tue, 13 Dec 2016 21:55:48 +0100 Subject: 16.12 release - correct Kopete version In-Reply-To: <201612131334.31133@pali> References: <201612130237.09883@pali> <1954369009.3284299.1481629195153@mail.yahoo.com> <201612131334.31133@pali> Message-ID: <4557017.uCHoELsJWZ@xps> El dimarts, 13 de desembre de 2016, a les 13:34:31 CET, Pali Rohár va escriure: > Yes! Please make sure you update the version on time next time. It makes everyone lifes easier. Cheers, Albert > > On Tuesday 13 December 2016 12:39:55 Albert Astals Cid wrote: > > Are you asking for the tarball to be recreated? > > Cheers, Albert > > On dt., des. 13, 2016 at 2:37, Pali Rohár > > > > wrote: Hi! Now I pushed commit into kopete > > Application/16.12 branch which increase version from RC 1.10.90 to > > final 1.11.0.-- > > Pali Rohár > > pali.rohar at gmail.com From aacid at kde.org Tue Dec 13 21:01:25 2016 From: aacid at kde.org (Albert Astals Cid) Date: Tue, 13 Dec 2016 22:01:25 +0100 Subject: new kalzium tarball -was - Re: KDE Applications 16.12.0 packages available for packagers In-Reply-To: <1540435.zciKPnytZj@xps> References: <1540435.zciKPnytZj@xps> Message-ID: <3017441.tryo36uMq0@xps> The soversion was all weird, fixed now. Cheers, Albert El divendres, 9 de desembre de 2016, a les 12:18:19 CET, Albert Astals Cid va escriure: > At the usual location. > > Haven't had time to compile yet, will start now. > > REVISIONS_AND_HASHES file at https://paste.kde.org/paclv5d4w > > Public release next week thursday. > > Cheers, > Albert From aacid at kde.org Tue Dec 13 21:02:27 2016 From: aacid at kde.org (Albert Astals Cid) Date: Tue, 13 Dec 2016 22:02:27 +0100 Subject: new kopete tarball - was - Re: KDE Applications 16.12.0 packages available for packagers In-Reply-To: <1540435.zciKPnytZj@xps> References: <1540435.zciKPnytZj@xps> Message-ID: <2302090.Ipb6vYBSs4@xps> version was wrong, fixed now. kopete Applications/16.12 c44bd4588c332d348d8bc82659ce4800fc4b007f c0ecf2c7d2bb679f523d043b27f51120846a812fad8aabfcc6b33c81718f2789 sources/kopete-16.12.0.tar.xz Cheers, Albert El divendres, 9 de desembre de 2016, a les 12:18:19 CET, Albert Astals Cid va escriure: > At the usual location. > > Haven't had time to compile yet, will start now. > > REVISIONS_AND_HASHES file at https://paste.kde.org/paclv5d4w > > Public release next week thursday. > > Cheers, > Albert From aacid at kde.org Tue Dec 13 21:03:03 2016 From: aacid at kde.org (Albert Astals Cid) Date: Tue, 13 Dec 2016 22:03:03 +0100 Subject: new kalzium tarball -was - Re: KDE Applications 16.12.0 packages available for packagers In-Reply-To: <3017441.tryo36uMq0@xps> References: <1540435.zciKPnytZj@xps> <3017441.tryo36uMq0@xps> Message-ID: <3734811.Czgoo813MJ@xps> El dimarts, 13 de desembre de 2016, a les 22:01:25 CET, Albert Astals Cid va escriure: > The soversion was all weird, fixed now. Forgot this kalzium Applications/16.12 e16b0159acc01efcdc8b51b04b8eb6303b16b0db 50050c85fb1760a99b7bbd0ed0f1047b4456139eb8d3f012005f6106e16a880e sources/kalzium-16.12.0.tar.xz Cheers, Albert > > Cheers, > Albert > > El divendres, 9 de desembre de 2016, a les 12:18:19 CET, Albert Astals Cid > va > escriure: > > At the usual location. > > > > Haven't had time to compile yet, will start now. > > > > REVISIONS_AND_HASHES file at https://paste.kde.org/paclv5d4w > > > > Public release next week thursday. > > > > Cheers, > > > > Albert From null at kde.org Wed Dec 14 11:01:26 2016 From: null at kde.org (Bhushan Shah) Date: Wed, 14 Dec 2016 11:01:26 +0000 Subject: [kpackage] /: Fix cmake failure when two packages with different type have same id Message-ID: Git commit 26e59d58438cc777873a6afc7817418ec735aaa3 by Bhushan Shah. Committed on 14/12/2016 at 10:58. Pushed by bshah into branch 'master'. Fix cmake failure when two packages with different type have same id Earlier we used to create temporary json in $component-metadata.json, but this failed if we have two packages with same id, for instance in phone there is org.kde.plasma.phone shell package and look-and-feel package. CCMAIL: release-team at kde.org CCMAIL: distributions at kde.org CCMAIL: faure at kde.org Reviewed-by: notmart at gmail.com David, can you please do 5.29 re-tar with this? M +2 -2 KF5PackageMacros.cmake https://commits.kde.org/kpackage/26e59d58438cc777873a6afc7817418ec735aaa3 diff --git a/KF5PackageMacros.cmake b/KF5PackageMacros.cmake index a14ab0b..4a4d081 100644 --- a/KF5PackageMacros.cmake +++ b/KF5PackageMacros.cmake @@ -36,8 +36,8 @@ function(kpackage_install_package dir component) PATTERN Messages.sh EXCLUDE PATTERN dummydata EXCLUDE) - if(NOT EXISTS ${component}-metadata.json) - set(GENERATED_METADATA "${CMAKE_CURRENT_BINARY_DIR}/${component}-metadata.json") + if(NOT EXISTS ${component}-${root}-metadata.json) + set(GENERATED_METADATA "${CMAKE_CURRENT_BINARY_DIR}/${component}-${root}-metadata.json") add_custom_command(OUTPUT ${GENERATED_METADATA} COMMAND KF5::desktoptojson -i ${CMAKE_CURRENT_SOURCE_DIR}/${dir}/metadata.desktop -o ${GENERATED_METADATA}) add_custom_target(${component}-metadata-json ALL DEPENDS ${GENERATED_METADATA}) From null at kde.org Wed Dec 14 11:29:51 2016 From: null at kde.org (Bhushan Shah) Date: Wed, 14 Dec 2016 11:29:51 +0000 Subject: [kpackage] /: Additional fix for packages with different types but same ids Message-ID: Git commit 17915200921836d61266ad93dd6c3b87db1dc9e4 by Bhushan Shah. Committed on 14/12/2016 at 11:25. Pushed by bshah into branch 'master'. Additional fix for packages with different types but same ids Fix in 26e59d5843 implemented fully in this. CCMAIL: release-team at kde.org CCMAIL: distributions at kde.org CCMAIL: faure at kde.org David, sorry, but in addition to 26e59d5843 please include this commit also in new tar M +1 -1 KF5PackageMacros.cmake https://commits.kde.org/kpackage/17915200921836d61266ad93dd6c3b87db1dc9e4 diff --git a/KF5PackageMacros.cmake b/KF5PackageMacros.cmake index 4a4d081..98044b9 100644 --- a/KF5PackageMacros.cmake +++ b/KF5PackageMacros.cmake @@ -40,7 +40,7 @@ function(kpackage_install_package dir component) set(GENERATED_METADATA "${CMAKE_CURRENT_BINARY_DIR}/${component}-${root}-metadata.json") add_custom_command(OUTPUT ${GENERATED_METADATA} COMMAND KF5::desktoptojson -i ${CMAKE_CURRENT_SOURCE_DIR}/${dir}/metadata.desktop -o ${GENERATED_METADATA}) - add_custom_target(${component}-metadata-json ALL DEPENDS ${GENERATED_METADATA}) + add_custom_target(${component}-${root}-metadata-json ALL DEPENDS ${GENERATED_METADATA}) install(FILES ${GENERATED_METADATA} DESTINATION ${KDE_INSTALL_DATADIR}/${install_dir}/${root}/${component} RENAME metadata.json) endif() From faure at kde.org Wed Dec 14 13:49:58 2016 From: faure at kde.org (David Faure) Date: Wed, 14 Dec 2016 14:49:58 +0100 Subject: kpackage-5.29.1 In-Reply-To: References: Message-ID: <2863414.xACffPTQfr@linux-t46v.suse> Done, here's the information about the new tarball. kpackage v5.29.1 b6eafc589fb5da5aa5c98c5fbc0a5ae9d3796c37 91aa6c79f99492eeefb0b03cb1d04cc19f91d5a5c08867141e31ea1b74c17ced sources/kpackage-5.29.1.tar.xz I also committed www/info/source-kf-5.29.1.inc, can you take care of editing www/info/kde-frameworks-2.59.0.php, mention the "known bugs" and include the new info "inc" file under the main one ? -- David Faure, faure at kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 From null at kde.org Wed Dec 14 13:39:43 2016 From: null at kde.org (l10n daemon script) Date: Wed, 14 Dec 2016 13:39:43 +0000 Subject: [kpackage/v5.29.1] /: Additional fix for packages with different types but same ids Message-ID: Git commit 7242e88c634156c38a532637ba04a71c3664b1bd by l10n daemon script, on behalf of Bhushan Shah. Committed on 14/12/2016 at 13:39. Pushed by dfaure into tag 'v5.29.1'. Additional fix for packages with different types but same ids Fix in 26e59d5843 implemented fully in this. CCMAIL: release-team at kde.org CCMAIL: distributions at kde.org CCMAIL: faure at kde.org David, sorry, but in addition to 26e59d5843 please include this commit also in new tar (cherry picked from commit 17915200921836d61266ad93dd6c3b87db1dc9e4) M +1 -1 KF5PackageMacros.cmake https://commits.kde.org/kpackage/7242e88c634156c38a532637ba04a71c3664b1bd diff --git a/KF5PackageMacros.cmake b/KF5PackageMacros.cmake index 4a4d081..98044b9 100644 --- a/KF5PackageMacros.cmake +++ b/KF5PackageMacros.cmake @@ -40,7 +40,7 @@ function(kpackage_install_package dir component) set(GENERATED_METADATA "${CMAKE_CURRENT_BINARY_DIR}/${component}-${root}-metadata.json") add_custom_command(OUTPUT ${GENERATED_METADATA} COMMAND KF5::desktoptojson -i ${CMAKE_CURRENT_SOURCE_DIR}/${dir}/metadata.desktop -o ${GENERATED_METADATA}) - add_custom_target(${component}-metadata-json ALL DEPENDS ${GENERATED_METADATA}) + add_custom_target(${component}-${root}-metadata-json ALL DEPENDS ${GENERATED_METADATA}) install(FILES ${GENERATED_METADATA} DESTINATION ${KDE_INSTALL_DATADIR}/${install_dir}/${root}/${component} RENAME metadata.json) endif() From null at kde.org Wed Dec 14 13:39:43 2016 From: null at kde.org (l10n daemon script) Date: Wed, 14 Dec 2016 13:39:43 +0000 Subject: [kpackage/v5.29.1] /: Fix cmake failure when two packages with different type have same id Message-ID: Git commit 58aec5c1f7005caa307408a36ab6e82456e6aa75 by l10n daemon script, on behalf of Bhushan Shah. Committed on 14/12/2016 at 13:39. Pushed by dfaure into tag 'v5.29.1'. Fix cmake failure when two packages with different type have same id Earlier we used to create temporary json in $component-metadata.json, but this failed if we have two packages with same id, for instance in phone there is org.kde.plasma.phone shell package and look-and-feel package. CCMAIL: release-team at kde.org CCMAIL: distributions at kde.org CCMAIL: faure at kde.org Reviewed-by: notmart at gmail.com David, can you please do 5.29 re-tar with this? (cherry picked from commit 26e59d58438cc777873a6afc7817418ec735aaa3) M +2 -2 KF5PackageMacros.cmake https://commits.kde.org/kpackage/58aec5c1f7005caa307408a36ab6e82456e6aa75 diff --git a/KF5PackageMacros.cmake b/KF5PackageMacros.cmake index a14ab0b..4a4d081 100644 --- a/KF5PackageMacros.cmake +++ b/KF5PackageMacros.cmake @@ -36,8 +36,8 @@ function(kpackage_install_package dir component) PATTERN Messages.sh EXCLUDE PATTERN dummydata EXCLUDE) - if(NOT EXISTS ${component}-metadata.json) - set(GENERATED_METADATA "${CMAKE_CURRENT_BINARY_DIR}/${component}-metadata.json") + if(NOT EXISTS ${component}-${root}-metadata.json) + set(GENERATED_METADATA "${CMAKE_CURRENT_BINARY_DIR}/${component}-${root}-metadata.json") add_custom_command(OUTPUT ${GENERATED_METADATA} COMMAND KF5::desktoptojson -i ${CMAKE_CURRENT_SOURCE_DIR}/${dir}/metadata.desktop -o ${GENERATED_METADATA}) add_custom_target(${component}-metadata-json ALL DEPENDS ${GENERATED_METADATA}) From bshah at kde.org Wed Dec 14 14:48:58 2016 From: bshah at kde.org (Bhushan Shah) Date: Wed, 14 Dec 2016 20:18:58 +0530 Subject: kpackage-5.29.1 In-Reply-To: <2863414.xACffPTQfr@linux-t46v.suse> References: <2863414.xACffPTQfr@linux-t46v.suse> Message-ID: <20161214144858.GA19043@archbox> On Wed, Dec 14, 2016 at 02:49:58PM +0100, David Faure wrote: > Done, here's the information about the new tarball. > > kpackage v5.29.1 > b6eafc589fb5da5aa5c98c5fbc0a5ae9d3796c37 > 91aa6c79f99492eeefb0b03cb1d04cc19f91d5a5c08867141e31ea1b74c17ced sources/kpackage-5.29.1.tar.xz > > I also committed www/info/source-kf-5.29.1.inc, can you take care of editing > www/info/kde-frameworks-2.59.0.php, mention the "known bugs" and include > the new info "inc" file under the main one ? Um.. I don't have super powers to write to www on svn.. however attached patch for it. -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D -------------- next part -------------- Index: kde-frameworks-5.29.0.php =================================================================== --- kde-frameworks-5.29.0.php (revision 1476986) +++ kde-frameworks-5.29.0.php (working copy) @@ -22,7 +22,7 @@ surfacing after the release was packaged:

    -
  • No significant bugs.
  • +
  • KPackage: Generates compile time error if applicaiton using two packages with different type but similar id. Fixed in 5.29.1

Please check the bug database @@ -60,6 +60,9 @@ + From aacid at kde.org Wed Dec 14 18:52:18 2016 From: aacid at kde.org (Albert Astals Cid) Date: Wed, 14 Dec 2016 19:52:18 +0100 Subject: kpackage-5.29.1 In-Reply-To: <20161214144858.GA19043@archbox> References: <2863414.xACffPTQfr@linux-t46v.suse> <20161214144858.GA19043@archbox> Message-ID: <1842638.0GWxN2lQdO@xps> El dimecres, 14 de desembre de 2016, a les 20:18:58 CET, Bhushan Shah va escriure: > On Wed, Dec 14, 2016 at 02:49:58PM +0100, David Faure wrote: > > Done, here's the information about the new tarball. > > > > kpackage v5.29.1 > > b6eafc589fb5da5aa5c98c5fbc0a5ae9d3796c37 > > 91aa6c79f99492eeefb0b03cb1d04cc19f91d5a5c08867141e31ea1b74c17ced > > sources/kpackage-5.29.1.tar.xz > > > > I also committed www/info/source-kf-5.29.1.inc, can you take care of > > editing www/info/kde-frameworks-2.59.0.php, mention the "known bugs" and > > include the new info "inc" file under the main one ? > > Um.. I don't have super powers to write to www on svn.. however attached > patch for it. David commited it. I fixed the applicaiton -> application typo. Cheers, Albert From aacid at kde.org Wed Dec 14 18:59:49 2016 From: aacid at kde.org (Albert Astals Cid) Date: Wed, 14 Dec 2016 18:59:49 +0000 Subject: www/sites/www/announcements Message-ID: SVN commit 1477002 by aacid: Fix supported Qt versions in KF5 CCMAIL: faure at kde.org CCMAIL: release-team at kde.org M +1 -1 kde-frameworks-5.13.0.php M +1 -1 kde-frameworks-5.14.0.php M +1 -1 kde-frameworks-5.15.0.php M +1 -1 kde-frameworks-5.16.0.php M +1 -1 kde-frameworks-5.17.0.php M +1 -1 kde-frameworks-5.18.0.php M +1 -1 kde-frameworks-5.19.0.php M +1 -1 kde-frameworks-5.20.0.php M +1 -1 kde-frameworks-5.21.0.php M +1 -1 kde-frameworks-5.22.0.php M +1 -1 kde-frameworks-5.23.0.php M +1 -1 kde-frameworks-5.24.0.php M +1 -1 kde-frameworks-5.25.0.php M +1 -1 kde-frameworks-5.26.0.php M +1 -1 kde-frameworks-5.27.0.php M +1 -1 kde-frameworks-5.28.0.php M +1 -1 kde-frameworks-5.29.0.php --- trunk/www/sites/www/announcements/kde-frameworks-5.13.0.php #1477001:1477002 @@ -340,7 +340,7 @@ cmake .; make; make install commands. For a single Tier 1 framework, this is often the easiest solution. People interested in contributing to frameworks or tracking progress in development of the entire set are encouraged to use kdesrc-build. Frameworks %2 requires Qt %3. -", "http://kdesrc-build.kde.org/", $release, "5.2");?> +", "http://kdesrc-build.kde.org/", $release, "5.3");?>

cmake .; make; make install commands. For a single Tier 1 framework, this is often the easiest solution. People interested in contributing to frameworks or tracking progress in development of the entire set are encouraged to use kdesrc-build. Frameworks %2 requires Qt %3. -", "http://kdesrc-build.kde.org/", $release, "5.2");?> +", "http://kdesrc-build.kde.org/", $release, "5.3");?>

cmake .; make; make install commands. For a single Tier 1 framework, this is often the easiest solution. People interested in contributing to frameworks or tracking progress in development of the entire set are encouraged to use kdesrc-build. Frameworks %2 requires Qt %3. -", "http://kdesrc-build.kde.org/", $release, "5.2");?> +", "http://kdesrc-build.kde.org/", $release, "5.3");?>

cmake .; make; make install commands. For a single Tier 1 framework, this is often the easiest solution. People interested in contributing to frameworks or tracking progress in development of the entire set are encouraged to use kdesrc-build. Frameworks %2 requires Qt %3. -", "http://kdesrc-build.kde.org/", $release, "5.2");?> +", "http://kdesrc-build.kde.org/", $release, "5.3");?>

cmake .; make; make install commands. For a single Tier 1 framework, this is often the easiest solution. People interested in contributing to frameworks or tracking progress in development of the entire set are encouraged to use kdesrc-build. Frameworks %2 requires Qt %3. -", "http://kdesrc-build.kde.org/", $release, "5.2");?> +", "http://kdesrc-build.kde.org/", $release, "5.3");?>

cmake .; make; make install commands. For a single Tier 1 framework, this is often the easiest solution. People interested in contributing to frameworks or tracking progress in development of the entire set are encouraged to use kdesrc-build. Frameworks %2 requires Qt %3. -", "http://kdesrc-build.kde.org/", $release, "5.2");?> +", "http://kdesrc-build.kde.org/", $release, "5.3");?>

cmake .; make; make install commands. For a single Tier 1 framework, this is often the easiest solution. People interested in contributing to frameworks or tracking progress in development of the entire set are encouraged to use kdesrc-build. Frameworks %2 requires Qt %3. -", "http://kdesrc-build.kde.org/", $release, "5.2");?> +", "http://kdesrc-build.kde.org/", $release, "5.3");?>

cmake .; make; make install commands. For a single Tier 1 framework, this is often the easiest solution. People interested in contributing to frameworks or tracking progress in development of the entire set are encouraged to use kdesrc-build. Frameworks %2 requires Qt %3. -", "http://kdesrc-build.kde.org/", $release, "5.2");?> +", "http://kdesrc-build.kde.org/", $release, "5.3");?>

cmake .; make; make install commands. For a single Tier 1 framework, this is often the easiest solution. People interested in contributing to frameworks or tracking progress in development of the entire set are encouraged to use kdesrc-build. Frameworks %2 requires Qt %3. -", "http://kdesrc-build.kde.org/", $release, "5.2");?> +", "http://kdesrc-build.kde.org/", $release, "5.4");?>

cmake .; make; make install commands. For a single Tier 1 framework, this is often the easiest solution. People interested in contributing to frameworks or tracking progress in development of the entire set are encouraged to use kdesrc-build. Frameworks %2 requires Qt %3. -", "http://kdesrc-build.kde.org/", $release, "5.2");?> +", "http://kdesrc-build.kde.org/", $release, "5.4");?>

cmake .; make; make install commands. For a single Tier 1 framework, this is often the easiest solution. People interested in contributing to frameworks or tracking progress in development of the entire set are encouraged to use kdesrc-build. Frameworks %2 requires Qt %3. -", "http://kdesrc-build.kde.org/", $release, "5.2");?> +", "http://kdesrc-build.kde.org/", $release, "5.4");?>

cmake .; make; make install commands. For a single Tier 1 framework, this is often the easiest solution. People interested in contributing to frameworks or tracking progress in development of the entire set are encouraged to use kdesrc-build. Frameworks %2 requires Qt %3. -", "http://kdesrc-build.kde.org/", $release, "5.2");?> +", "http://kdesrc-build.kde.org/", $release, "5.4");?>

cmake .; make; make install commands. For a single Tier 1 framework, this is often the easiest solution. People interested in contributing to frameworks or tracking progress in development of the entire set are encouraged to use kdesrc-build. Frameworks %2 requires Qt %3. -", "http://kdesrc-build.kde.org/", $release, "5.2");?> +", "http://kdesrc-build.kde.org/", $release, "5.5");?>

cmake .; make; make install commands. For a single Tier 1 framework, this is often the easiest solution. People interested in contributing to frameworks or tracking progress in development of the entire set are encouraged to use kdesrc-build. Frameworks %2 requires Qt %3. -", "http://kdesrc-build.kde.org/", $release, "5.2");?> +", "http://kdesrc-build.kde.org/", $release, "5.5");?>

cmake .; make; make install commands. For a single Tier 1 framework, this is often the easiest solution. People interested in contributing to frameworks or tracking progress in development of the entire set are encouraged to use kdesrc-build. Frameworks %2 requires Qt %3. -", "http://kdesrc-build.kde.org/", $release, "5.2");?> +", "http://kdesrc-build.kde.org/", $release, "5.5");?>

cmake .; make; make install commands. For a single Tier 1 framework, this is often the easiest solution. People interested in contributing to frameworks or tracking progress in development of the entire set are encouraged to use kdesrc-build. Frameworks %2 requires Qt %3. -", "http://kdesrc-build.kde.org/", $release, "5.2");?> +", "http://kdesrc-build.kde.org/", $release, "5.5");?>

cmake .; make; make install commands. For a single Tier 1 framework, this is often the easiest solution. People interested in contributing to frameworks or tracking progress in development of the entire set are encouraged to use kdesrc-build. Frameworks %2 requires Qt %3. -", "http://kdesrc-build.kde.org/", $release, "5.2");?> +", "http://kdesrc-build.kde.org/", $release, "5.5");?>

Message-ID: <20161215165734.2edbe563@giskard.marionegri.it> Il giorno Sun, 04 Dec 2016 00:37:52 +0100 David Faure ha scritto: > KDE Frameworks 5.29.0 has been uploaded to the usual place. I know it's been released, but there's a snag with frameworkintegration: - wrong CMake check (checks for AppStreamQt >= 0.10 but doesn't get detected because the CMake file in 0.10 is called AppstreamQt - lowercase s -,). It's only correct for AppStreamQt 0.10.4+ (why, *why* SIC changes in minor releases!) - even if that is fixed, it uses includes that aren't available in 0.10, so compilation fails. Again, likely available in 0.10.4 or so. Either the version check is fixed, or the code adjusted to actually work on 0.10.0. (/me is not too fond of the constant breakage in AppStreamQt as well) -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: Firma digitale OpenPGP URL: From aacid at kde.org Thu Dec 15 17:58:15 2016 From: aacid at kde.org (Albert Astals Cid) Date: Thu, 15 Dec 2016 18:58:15 +0100 Subject: new dragon tarball - was - Re: KDE Applications 16.12.0 packages available for packagers In-Reply-To: <1540435.zciKPnytZj@xps> References: <1540435.zciKPnytZj@xps> Message-ID: <7819534.ydcXRCUMSG@xps> People had forgotten to merge stable branches to master and bugfixes were lost. dragon Applications/16.12 ccac1eb4227bc6df2ccfe0d899df43c331060421 028fe9e7475dd88d0ebe3a3e5b1e26677886013a4e82457fab880ad17ed34a23 sources/dragon-16.12.0.tar.xz Cheers, Albert El divendres, 9 de desembre de 2016, a les 12:18:19 CET, Albert Astals Cid va escriure: > At the usual location. > > Haven't had time to compile yet, will start now. > > REVISIONS_AND_HASHES file at https://paste.kde.org/paclv5d4w > > Public release next week thursday. > > Cheers, > Albert From aacid at kde.org Thu Dec 15 17:59:13 2016 From: aacid at kde.org (Albert Astals Cid) Date: Thu, 15 Dec 2016 18:59:13 +0100 Subject: Update Dragon 16.12 tarball release In-Reply-To: <2719150.EoeFMS7zca@toni-pc> References: <2719150.EoeFMS7zca@toni-pc> Message-ID: <1629387.RaA59B2yNB@xps> El dijous, 15 de desembre de 2016, a les 6:45:31 CET, Anthony Fieroni va escriure: > I merge branch 16.04 into 16.12, it was forgotten. Hood catch, but please next time try to catch it before the release day. > > https://cgit.kde.org/dragon.git/commit/?h=Applications/16.12 Also next time i'd appreciate if you mailed release-team and not me directly. We have mailing lists for a reason :) Cheers, Albert From aacid at kde.org Thu Dec 15 18:41:51 2016 From: aacid at kde.org (Albert Astals Cid) Date: Thu, 15 Dec 2016 18:41:51 +0000 Subject: www/sites/www Message-ID: SVN commit 1477139 by aacid: KDE Applications 16.12.0 CCMAIL: release-team at kde.org M +0 -10 announcements/announce-applications-16.12.0.php M +7 -1 announcements/index.php M +1 -1 announcements/release_data.php M +32 -0 i18n/pt/www.inc M +32 -0 i18n/uk/www.inc M +4 -8 index.php A info/applications-16.12.0.php A info/source-applications-16.12.0.inc http://websvn.kde.org/?view=rev&revision=1477139 From aacid at kde.org Thu Dec 15 21:14:38 2016 From: aacid at kde.org (Albert Astals Cid) Date: Thu, 15 Dec 2016 22:14:38 +0100 Subject: Dropping the svn kio from kdesdk-kioslaves Message-ID: <3186774.Hvc6M4JW8H@xps> Why? * It doesn't compile with newer libsvn * It's kdelibs4-based Any disagreement on dropping it? Cheers, Albert From kfunk at kde.org Thu Dec 15 22:12:58 2016 From: kfunk at kde.org (Kevin Funk) Date: Thu, 15 Dec 2016 23:12:58 +0100 Subject: Dropping the svn kio from kdesdk-kioslaves In-Reply-To: <3186774.Hvc6M4JW8H@xps> References: <3186774.Hvc6M4JW8H@xps> Message-ID: <2378706.iPFFefHPQL@kerberos> On Thursday, 15 December 2016 22:14:38 CET Albert Astals Cid wrote: > Why? > * It doesn't compile with newer libsvn > * It's kdelibs4-based Heya, I know a few people that use kdesvn, how's the relation to that? I saw that Christian (CC'ed) put quite some effort in porting kdesvn over to a KF5-based kdelibs4support-free code base. If I understand correctly kdesvn.git even contains a copy of the KIO SVN implementation (c.f. kdesvn.git:src/ kiosvn)? Please elaborate :) PS: /me never uses SVN directly usually. Cheers, Kevin > Any disagreement on dropping it? > > Cheers, > Albert -- Kevin Funk | kfunk at kde.org | http://kfunk.org -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 163 bytes Desc: This is a digitally signed message part. URL: From tcberner at gmail.com Thu Dec 15 22:42:11 2016 From: tcberner at gmail.com (Tobias C. Berner) Date: Thu, 15 Dec 2016 23:42:11 +0100 Subject: Dropping the svn kio from kdesdk-kioslaves In-Reply-To: <2378706.iPFFefHPQL@kerberos> References: <3186774.Hvc6M4JW8H@xps> <2378706.iPFFefHPQL@kerberos> Message-ID: On FreeBSD we have this patch https://svnweb.freebsd.org/ports/head/devel/kdesdk4-kioslaves/files/patch-svn_svn.cpp?revision=400399 to make the kioslave build against subversion 1.9. mfg Tobias On 15 December 2016 at 23:12, Kevin Funk wrote: > On Thursday, 15 December 2016 22:14:38 CET Albert Astals Cid wrote: > > Why? > > * It doesn't compile with newer libsvn > > * It's kdelibs4-based > > Heya, > > I know a few people that use kdesvn, how's the relation to that? > > I saw that Christian (CC'ed) put quite some effort in porting kdesvn over > to a > KF5-based kdelibs4support-free code base. If I understand correctly > kdesvn.git > even contains a copy of the KIO SVN implementation (c.f. kdesvn.git:src/ > kiosvn)? > > Please elaborate :) > > PS: /me never uses SVN directly usually. > > Cheers, > Kevin > > > Any disagreement on dropping it? > > > > Cheers, > > Albert > > > -- > Kevin Funk | kfunk at kde.org | http://kfunk.org -------------- next part -------------- An HTML attachment was scrubbed... URL: From aleixpol at kde.org Fri Dec 16 00:39:49 2016 From: aleixpol at kde.org (Aleix Pol) Date: Fri, 16 Dec 2016 01:39:49 +0100 Subject: KDE Frameworks 5.29.0 In-Reply-To: <20161215165734.2edbe563@giskard.marionegri.it> References: <1544539.SQJqS6oqim@linux-t46v.suse> <20161215165734.2edbe563@giskard.marionegri.it> Message-ID: On Thu, Dec 15, 2016 at 4:57 PM, Luca Beltrame wrote: > Il giorno Sun, 04 Dec 2016 00:37:52 +0100 > David Faure ha scritto: > >> KDE Frameworks 5.29.0 has been uploaded to the usual place. > > I know it's been released, but there's a snag with frameworkintegration: > > - wrong CMake check (checks for AppStreamQt >= 0.10 but doesn't get > detected because the CMake file in 0.10 is called AppstreamQt - > lowercase s -,). It's only correct for AppStreamQt 0.10.4+ (why, > *why* SIC changes in minor releases!) > - even if that is fixed, it uses includes that aren't available in > 0.10, so compilation fails. Again, likely available in 0.10.4 or so. > > Either the version check is fixed, or the code adjusted to actually > work on 0.10.0. > > (/me is not too fond of the constant breakage in AppStreamQt as well) https://phabricator.kde.org/D3696 Aleix From Ch.Ehrlicher at gmx.de Fri Dec 16 05:31:46 2016 From: Ch.Ehrlicher at gmx.de (Christian Ehrlicher) Date: Fri, 16 Dec 2016 06:31:46 +0100 Subject: Dropping the svn kio from kdesdk-kioslaves In-Reply-To: <2378706.iPFFefHPQL@kerberos> References: <3186774.Hvc6M4JW8H@xps> <2378706.iPFFefHPQL@kerberos> Message-ID: <9853b246-4e1c-45b2-48c6-90740aa1cad5@gmx.de> Am 15.12.2016 um 23:12 schrieb Kevin Funk: > On Thursday, 15 December 2016 22:14:38 CET Albert Astals Cid wrote: >> Why? >> * It doesn't compile with newer libsvn >> * It's kdelibs4-based > Heya, > > I know a few people that use kdesvn, how's the relation to that? > > I saw that Christian (CC'ed) put quite some effort in porting kdesvn over to a > KF5-based kdelibs4support-free code base. If I understand correctly kdesvn.git > even contains a copy of the KIO SVN implementation (c.f. kdesvn.git:src/ > kiosvn)? > > Please elaborate :) You're correct - kdesvn contains a kioslave for svn and I ported it to KF5 (just released kdesvn 2.0.0 some days ago). I don't know if kdesdk-kioslaves has more functionality but from my point of view it can be dropped. Cheers, Christian From kfunk at kde.org Fri Dec 16 10:32:21 2016 From: kfunk at kde.org (Kevin Funk) Date: Fri, 16 Dec 2016 11:32:21 +0100 Subject: Dropping the svn kio from kdesdk-kioslaves In-Reply-To: <9853b246-4e1c-45b2-48c6-90740aa1cad5@gmx.de> References: <3186774.Hvc6M4JW8H@xps> <2378706.iPFFefHPQL@kerberos> <9853b246-4e1c-45b2-48c6-90740aa1cad5@gmx.de> Message-ID: <1516727.qubFCWHrX7@kerberos> On Friday, 16 December 2016 06:31:46 CET Christian Ehrlicher wrote: > Am 15.12.2016 um 23:12 schrieb Kevin Funk: > > On Thursday, 15 December 2016 22:14:38 CET Albert Astals Cid wrote: > >> Why? > >> > >> * It doesn't compile with newer libsvn > >> * It's kdelibs4-based > > > > Heya, > > > > I know a few people that use kdesvn, how's the relation to that? > > > > I saw that Christian (CC'ed) put quite some effort in porting kdesvn over > > to a KF5-based kdelibs4support-free code base. If I understand correctly > > kdesvn.git even contains a copy of the KIO SVN implementation (c.f. > > kdesvn.git:src/ kiosvn)? > > > > Please elaborate :) > > You're correct - kdesvn contains a kioslave for svn and I ported it to > KF5 (just released kdesvn 2.0.0 some days ago). I don't know if > kdesdk-kioslaves has more functionality but from my point of view it can > be dropped. If the SVN kioslave is standalone, wouldn't it make more sense to actually keep it in a separate repository/package? So users who just want the Dolphin integration can just use that? Wouldn't it make more sense to move your kioslave implementation into kdesdk- kioslaves, replacing the older copy? I'm not sure whether Albert just wants to kill the repository or he's just phasing old unmaintained software. In case of the latter, updating the copy with the better maintained version probably makes more sense. Cheers, Kevin > Cheers, > Christian -- Kevin Funk | kfunk at kde.org | http://kfunk.org -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 163 bytes Desc: This is a digitally signed message part. URL: From null at kde.org Mon Dec 19 12:30:44 2016 From: null at kde.org (David Faure) Date: Mon, 19 Dec 2016 12:30:44 +0000 Subject: [kdepim-runtime/Applications/16.12] resources/shared/singlefileresource: Fix DATA LOSS bug in ical resource which failed to create std.ics if it didn't exist. Message-ID: Git commit 8ae09b6f4afa8ceb2770da67b6dc79c78b86af47 by David Faure. Committed on 19/12/2016 at 12:29. Pushed by dfaure into branch 'Applications/16.12'. Fix DATA LOSS bug in ical resource which failed to create std.ics if it didn't exist. The default setup sets the Path to be a local path, not a URL. => Use QUrl::fromUserInput so that it can deal with both cases, paths and URLs. CCMAIL: smartins at kde.org, release-team at kde.org M +2 -2 resources/shared/singlefileresource/singlefileresource.h https://commits.kde.org/kdepim-runtime/8ae09b6f4afa8ceb2770da67b6dc79c78b86af47 diff --git a/resources/shared/singlefileresource/singlefileresource.h b/resources/shared/singlefileresource/singlefileresource.h index f3c19aaf5..3f4149903 100644 --- a/resources/shared/singlefileresource/singlefileresource.h +++ b/resources/shared/singlefileresource/singlefileresource.h @@ -55,7 +55,7 @@ public: , mSettings(new Settings(config())) { // The resource needs network when the path refers to a non local file. - setNeedsNetwork(!QUrl(mSettings->path()).isLocalFile()); + setNeedsNetwork(!QUrl::fromUserInput(mSettings->path()).isLocalFile()); } ~SingleFileResource() { @@ -82,7 +82,7 @@ public: return; } - mCurrentUrl = QUrl(mSettings->path()); // path already has scheme + mCurrentUrl = QUrl::fromUserInput(mSettings->path()); // the string contains the scheme if remote, doesn't if local path if (mCurrentHash.isEmpty()) { // First call to readFile() lets see if there is a hash stored in a From aacid at kde.org Mon Dec 19 22:01:45 2016 From: aacid at kde.org (Albert Astals Cid) Date: Mon, 19 Dec 2016 23:01:45 +0100 Subject: [kdepim-runtime/Applications/16.12] resources/shared/singlefileresource: Fix DATA LOSS bug in ical resource which failed to create std.ics if it didn't exist. In-Reply-To: References: Message-ID: <82351898.d197Cbyks8@xps> Can you clarify when the data loss happens? Do we need a re-release? Cheers, Albert El dilluns, 19 de desembre de 2016, a les 12:30:44 CET, David Faure va escriure: > Git commit 8ae09b6f4afa8ceb2770da67b6dc79c78b86af47 by David Faure. > Committed on 19/12/2016 at 12:29. > Pushed by dfaure into branch 'Applications/16.12'. > > Fix DATA LOSS bug in ical resource which failed to create std.ics if it > didn't exist. > > The default setup sets the Path to be a local path, not a URL. > => Use QUrl::fromUserInput so that it can deal with both cases, paths and > URLs. > > CCMAIL: smartins at kde.org, release-team at kde.org > > M +2 -2 resources/shared/singlefileresource/singlefileresource.h > > https://commits.kde.org/kdepim-runtime/8ae09b6f4afa8ceb2770da67b6dc79c78b86a > f47 > > diff --git a/resources/shared/singlefileresource/singlefileresource.h > b/resources/shared/singlefileresource/singlefileresource.h index > f3c19aaf5..3f4149903 100644 > --- a/resources/shared/singlefileresource/singlefileresource.h > +++ b/resources/shared/singlefileresource/singlefileresource.h > @@ -55,7 +55,7 @@ public: > , mSettings(new Settings(config())) > { > // The resource needs network when the path refers to a non local > file. - setNeedsNetwork(!QUrl(mSettings->path()).isLocalFile()); > + > setNeedsNetwork(!QUrl::fromUserInput(mSettings->path()).isLocalFile()); } > ~SingleFileResource() > { > @@ -82,7 +82,7 @@ public: > return; > } > > - mCurrentUrl = QUrl(mSettings->path()); // path already has scheme > + mCurrentUrl = QUrl::fromUserInput(mSettings->path()); // the string > contains the scheme if remote, doesn't if local path if > (mCurrentHash.isEmpty()) > { > // First call to readFile() lets see if there is a hash stored > in a From faure at kde.org Mon Dec 19 23:07:25 2016 From: faure at kde.org (David Faure) Date: Tue, 20 Dec 2016 00:07:25 +0100 Subject: [kdepim-runtime/Applications/16.12] resources/shared/singlefileresource: Fix DATA LOSS bug in ical resource which failed to create std.ics if it didn't exist. In-Reply-To: <82351898.d197Cbyks8@xps> References: <82351898.d197Cbyks8@xps> Message-ID: <4121968.pfLXGO043c@asterixp50> On lundi 19 décembre 2016 23:01:45 CET Albert Astals Cid wrote: > Can you clarify when the data loss happens? It happened to me with the default setup as a new user (!) Starting akonadi as a new user, you get a "Personal Calendar" ical resource, configured to point to $HOME/.local/share/apps/korganizer/std.ics (1) This path typically doesn't exist for a new user (the "apps/" part of it is very kde4, korganizer in kf5 uses ~/.local/share/korganizer), and the code to mkpath the parent dir was incorrect before my fix, so the ical resource would fail to save any change. And since saving (in the writeFile() method) happens delayed (2), it's not part of the akonadi job error handling. The resource just failed to save, almost silently, except for two qWarnings: akonadi_ical_resource: writeToFile() mCalendar is 0! akonadi_ical_resource: Error writing to file (1) this comes from kdepim-runtime/defaultsetup/defaultcalendar.desktop (2) see kdepim-runtime/resources/shared/singlefileresource/singlefileresourcebase.cpp If anyone else can test the "new user setup" and either confirm my findings or prove me wrong, I'm very interested. I was creating TODOs with zanshin, but I assume that creating events with korganizer would do the same. > Do we need a re-release? I would say yes, unless I'm missing something that makes this bug happen only to me (e.g. to git master users). But AFAICS it's a consequence of the fix for bug 352693, which happened a year ago. -- David Faure, faure at kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 From sknauss at kde.org Tue Dec 20 09:29:03 2016 From: sknauss at kde.org (Sandro =?ISO-8859-1?Q?Knau=DF?=) Date: Tue, 20 Dec 2016 10:29:03 +0100 Subject: [kdepim-runtime/Applications/16.12] resources/shared/singlefileresource: Fix DATA LOSS bug in ical resource which failed to create std.ics if it didn't exist. In-Reply-To: <4121968.pfLXGO043c@asterixp50> References: <82351898.d197Cbyks8@xps> <4121968.pfLXGO043c@asterixp50> Message-ID: <1782871.7y7jmFglRY@tuxin> Hey, mmh the description of your problem does not match with the commit you have pushed, or do i miss anything. Your patch is "only doing: QUrl(mSettings->path()) -> QUrl::fromUserInput(mSettings->path()); right? that means that we still have the problem with schema prefix in the url? And than mCurrentUrl.isLocalFile() is not true and you'll do not enter that codepath? Because the part that gets the dir you havn't changed... Just a little bit curious, why this is only a problem for a new user? On the other side I do not understand why the default local is import to trigger this bug. Btw. if the default location for korganzier has changed, than please update the defaultcalendar.desktop path. Best Regards, sandro -- Am Dienstag, 20. Dezember 2016, 00:07:25 CET schrieb David Faure: > On lundi 19 décembre 2016 23:01:45 CET Albert Astals Cid wrote: > > Can you clarify when the data loss happens? > > It happened to me with the default setup as a new user (!) > > Starting akonadi as a new user, you get a "Personal Calendar" ical resource, > configured to point to $HOME/.local/share/apps/korganizer/std.ics (1) > > This path typically doesn't exist for a new user (the "apps/" part of it is > very kde4, korganizer in kf5 uses ~/.local/share/korganizer), and the code > to mkpath the parent dir was incorrect before my fix, so the ical resource > would fail to save any change. And since saving (in the writeFile() method) > happens delayed (2), it's not part of the akonadi job error handling. The > resource just failed to save, almost silently, except for two qWarnings: > akonadi_ical_resource: writeToFile() mCalendar is 0! > akonadi_ical_resource: Error writing to file > > (1) this comes from kdepim-runtime/defaultsetup/defaultcalendar.desktop > (2) see > kdepim-runtime/resources/shared/singlefileresource/singlefileresourcebase.c > pp > > If anyone else can test the "new user setup" and either confirm my findings > or prove me wrong, I'm very interested. > > I was creating TODOs with zanshin, but I assume that creating events with > korganizer would do the same. > > Do we need a re-release? > > I would say yes, unless I'm missing something that makes this bug happen > only to me (e.g. to git master users). But AFAICS it's a consequence of the > fix for bug 352693, which happened a year ago. From Ch.Ehrlicher at gmx.de Tue Dec 20 09:40:44 2016 From: Ch.Ehrlicher at gmx.de (Christian Ehrlicher) Date: Tue, 20 Dec 2016 10:40:44 +0100 Subject: Dropping the svn kio from kdesdk-kioslaves In-Reply-To: <1516727.qubFCWHrX7@kerberos> References: <3186774.Hvc6M4JW8H@xps> <2378706.iPFFefHPQL@kerberos> <9853b246-4e1c-45b2-48c6-90740aa1cad5@gmx.de> <1516727.qubFCWHrX7@kerberos> Message-ID: <5e0238e7-934e-6ba5-dd82-35810380b1e7@gmx.de> Am 16.12.2016 um 11:32 schrieb Kevin Funk: > If the SVN kioslave is standalone, wouldn't it make more sense to actually > keep it in a separate repository/package? So users who just want the Dolphin > integration can just use that? > > Wouldn't it make more sense to move your kioslave implementation into kdesdk- > kioslaves, replacing the older copy? > > I'm not sure whether Albert just wants to kill the repository or he's just > phasing old unmaintained software. In case of the latter, updating the copy > with the better maintained version probably makes more sense. I took a look into kdesdk-kioslaves - the code for svn there is completely different from kdesvn kioslave. Therefore I would suggest to remove kdesdk-kioslaves/svn because I won't maintain two different implementations for one protocol. A distro packager can separate the kdesvn kioslave into a separate package, at least this is what I would expect looking at the kdesvn code. Christian From faure at kde.org Tue Dec 20 20:24:16 2016 From: faure at kde.org (David Faure) Date: Tue, 20 Dec 2016 21:24:16 +0100 Subject: [kdepim-runtime/Applications/16.12] resources/shared/singlefileresource: Fix DATA LOSS bug in ical resource which failed to create std.ics if it didn't exist. In-Reply-To: <1782871.7y7jmFglRY@tuxin> References: <4121968.pfLXGO043c@asterixp50> <1782871.7y7jmFglRY@tuxin> Message-ID: <7806444.SMD64hJD1G@asterixp50> On mardi 20 décembre 2016 10:29:03 CET Sandro Knauß wrote: > Hey, > > mmh the description of your problem does not match with the commit you have > pushed, or do i miss anything. The latter, I think ;) > Your patch is "only doing: > QUrl(mSettings->path()) -> QUrl::fromUserInput(mSettings->path()); > right? Right. > that means that we still have the problem with schema prefix in the url? No, fromUserInput supports both absolute paths and URLs, see API docs. > And than mCurrentUrl.isLocalFile() is not true and you'll do not enter that > codepath? isLocalFile() will be true for local files and false for remote URLs, I don't see a problem here. > Just a little bit curious, why this is only a problem for a new user? Well, anyone without a ~/.local/share/apps/korganizer/ subdir, which certainly includes new users. > On the other side I do not understand why the default local is import to > trigger this bug. Parse error at "default local is import". Can you rephrase? > Btw. if the default location for korganzier has changed, than please update > the defaultcalendar.desktop path. And break "Personal Calendar" for all users who copy their home dir (but not their akonadi setup) to another computer? Seems too dangerous to me, for zero gain. The korganizer in the path is historical anyhow, korganizer no longer accesses std.ics directly, ever since akonadi 1 came into play. -- David Faure, faure at kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 From aacid at kde.org Fri Dec 23 18:26:29 2016 From: aacid at kde.org (Albert Astals Cid) Date: Fri, 23 Dec 2016 19:26:29 +0100 Subject: [kdepim-runtime/Applications/16.12] resources/shared/singlefileresource: Fix DATA LOSS bug in ical resource which failed to create std.ics if it didn't exist. In-Reply-To: <7806444.SMD64hJD1G@asterixp50> References: <1782871.7y7jmFglRY@tuxin> <7806444.SMD64hJD1G@asterixp50> Message-ID: <4094495.rKjsmaqygT@xps> So i guess we're in agreement that we need a new tarball? Or can we just tell distro packagers to patch it? My issue with a new tarball is that i will need to call it 16.12.0.1 (since i don't want to do 16.12.1 with just kderuntime-changes) and then distros are going to complain since it has one extra version, and since it's not a whole new release we again basically depend on distros picking up the new tarball. So may as well just ask them to patch it in? Cheers, Albert El dimarts, 20 de desembre de 2016, a les 21:24:16 CET, David Faure va escriure: > On mardi 20 décembre 2016 10:29:03 CET Sandro Knauß wrote: > > Hey, > > > > mmh the description of your problem does not match with the commit you > > have > > pushed, or do i miss anything. > > The latter, I think ;) > > > Your patch is "only doing: > > QUrl(mSettings->path()) -> QUrl::fromUserInput(mSettings->path()); > > right? > > Right. > > > that means that we still have the problem with schema prefix in the url? > > No, fromUserInput supports both absolute paths and URLs, see API docs. > > > And than mCurrentUrl.isLocalFile() is not true and you'll do not enter > > that > > codepath? > > isLocalFile() will be true for local files and false for remote URLs, I > don't see a problem here. > > > Just a little bit curious, why this is only a problem for a new user? > > Well, anyone without a ~/.local/share/apps/korganizer/ subdir, > which certainly includes new users. > > > On the other side I do not understand why the default local is import to > > trigger this bug. > > Parse error at "default local is import". Can you rephrase? > > > Btw. if the default location for korganzier has changed, than please > > update > > the defaultcalendar.desktop path. > > And break "Personal Calendar" for all users who copy their home dir (but not > their akonadi setup) to another computer? Seems too dangerous to me, for > zero gain. The korganizer in the path is historical anyhow, korganizer no > longer accesses std.ics directly, ever since akonadi 1 came into play. From faure at kde.org Fri Dec 23 19:59:25 2016 From: faure at kde.org (David Faure) Date: Fri, 23 Dec 2016 20:59:25 +0100 Subject: [kdepim-runtime/Applications/16.12] resources/shared/singlefileresource: Fix DATA LOSS bug in ical resource which failed to create std.ics if it didn't exist. In-Reply-To: <4094495.rKjsmaqygT@xps> References: <7806444.SMD64hJD1G@asterixp50> <4094495.rKjsmaqygT@xps> Message-ID: <4545140.d1cgH4srhd@asterixp50> On vendredi 23 décembre 2016 19:26:29 CET Albert Astals Cid wrote: > So i guess we're in agreement that we need a new tarball? Or can we just > tell distro packagers to patch it? > > My issue with a new tarball is that i will need to call it 16.12.0.1 (since > i don't want to do 16.12.1 with just kderuntime-changes) and then distros > are going to complain since it has one extra version, and since it's not a > whole new release we again basically depend on distros picking up the new > tarball. > > So may as well just ask them to patch it in? I don't mind either way, ask them if they're ok with a patch ;) -- David Faure, faure at kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 From sknauss at kde.org Fri Dec 23 20:04:52 2016 From: sknauss at kde.org (Sandro =?ISO-8859-1?Q?Knau=DF?=) Date: Fri, 23 Dec 2016 21:04:52 +0100 Subject: [kdepim-runtime/Applications/16.12] resources/shared/singlefileresource: Fix DATA LOSS bug in ical resource which failed to create std.ics if it didn't exist. In-Reply-To: <4545140.d1cgH4srhd@asterixp50> References: <4094495.rKjsmaqygT@xps> <4545140.d1cgH4srhd@asterixp50> Message-ID: <2918353.mcmRY2p6PO@tuxin> Hey, > > So i guess we're in agreement that we need a new tarball? Or can we just > > tell distro packagers to patch it? jepp - either way is okay for me. Best Reagrds, sandro From bcooksley at kde.org Sat Dec 24 02:05:15 2016 From: bcooksley at kde.org (Ben Cooksley) Date: Sat, 24 Dec 2016 15:05:15 +1300 Subject: [kdepim-runtime/Applications/16.12] resources/shared/singlefileresource: Fix DATA LOSS bug in ical resource which failed to create std.ics if it didn't exist. In-Reply-To: <4094495.rKjsmaqygT@xps> References: <1782871.7y7jmFglRY@tuxin> <7806444.SMD64hJD1G@asterixp50> <4094495.rKjsmaqygT@xps> Message-ID: On Sat, Dec 24, 2016 at 7:26 AM, Albert Astals Cid wrote: > So i guess we're in agreement that we need a new tarball? Or can we just tell > distro packagers to patch it? > > My issue with a new tarball is that i will need to call it 16.12.0.1 (since i > don't want to do 16.12.1 with just kderuntime-changes) and then distros are > going to complain since it has one extra version, and since it's not a whole > new release we again basically depend on distros picking up the new tarball. Whichever one works easiest for the packagers I guess. Considering the severity of this issue though (silent data loss) we should probably make an advisory in about a month's time of which distributions have failed to patch/upgrade their packages so users are aware of the risk they are taking. > > So may as well just ask them to patch it in? > > Cheers, > Albert Cheers, Ben > > El dimarts, 20 de desembre de 2016, a les 21:24:16 CET, David Faure va > escriure: >> On mardi 20 décembre 2016 10:29:03 CET Sandro Knauß wrote: >> > Hey, >> > >> > mmh the description of your problem does not match with the commit you >> > have >> > pushed, or do i miss anything. >> >> The latter, I think ;) >> >> > Your patch is "only doing: >> > QUrl(mSettings->path()) -> QUrl::fromUserInput(mSettings->path()); >> > right? >> >> Right. >> >> > that means that we still have the problem with schema prefix in the url? >> >> No, fromUserInput supports both absolute paths and URLs, see API docs. >> >> > And than mCurrentUrl.isLocalFile() is not true and you'll do not enter >> > that >> > codepath? >> >> isLocalFile() will be true for local files and false for remote URLs, I >> don't see a problem here. >> >> > Just a little bit curious, why this is only a problem for a new user? >> >> Well, anyone without a ~/.local/share/apps/korganizer/ subdir, >> which certainly includes new users. >> >> > On the other side I do not understand why the default local is import to >> > trigger this bug. >> >> Parse error at "default local is import". Can you rephrase? >> >> > Btw. if the default location for korganzier has changed, than please >> > update >> > the defaultcalendar.desktop path. >> >> And break "Personal Calendar" for all users who copy their home dir (but not >> their akonadi setup) to another computer? Seems too dangerous to me, for >> zero gain. The korganizer in the path is historical anyhow, korganizer no >> longer accesses std.ics directly, ever since akonadi 1 came into play. > > From jr at jriddell.org Tue Dec 27 12:48:03 2016 From: jr at jriddell.org (Jonathan Riddell) Date: Tue, 27 Dec 2016 12:48:03 +0000 Subject: Plasma 5.8.5 Message-ID: Plasma 5.8.5 is now released https://www.kde.org/announcements/plasma-5.8.5.php From aacid at kde.org Wed Dec 28 11:14:12 2016 From: aacid at kde.org (Albert Astals Cid) Date: Wed, 28 Dec 2016 12:14:12 +0100 Subject: [kdepim-runtime/Applications/16.12] resources/shared/singlefileresource: Fix DATA LOSS bug in ical resource which failed to create std.ics if it didn't exist. In-Reply-To: References: <4094495.rKjsmaqygT@xps> Message-ID: <14547006.mbdgdMWApL@xps> El dissabte, 24 de desembre de 2016, a les 15:05:15 CET, Ben Cooksley va escriure: > On Sat, Dec 24, 2016 at 7:26 AM, Albert Astals Cid wrote: > > So i guess we're in agreement that we need a new tarball? Or can we just > > tell distro packagers to patch it? > > > > My issue with a new tarball is that i will need to call it 16.12.0.1 > > (since i don't want to do 16.12.1 with just kderuntime-changes) and then > > distros are going to complain since it has one extra version, and since > > it's not a whole new release we again basically depend on distros picking > > up the new tarball. > Whichever one works easiest for the packagers I guess. > > Considering the severity of this issue though (silent data loss) we > should probably make an advisory in about a month's time of which > distributions have failed to patch/upgrade their packages so users are > aware of the risk they are taking. We only have security advisories AFAIK https://www.kde.org/info/security/ What kind of advisory/way to make the world now were you thinking about? Cheers, Albert > > > So may as well just ask them to patch it in? > > > > Cheers, > > > > Albert > > Cheers, > Ben > > > El dimarts, 20 de desembre de 2016, a les 21:24:16 CET, David Faure va > > > > escriure: > >> On mardi 20 décembre 2016 10:29:03 CET Sandro Knauß wrote: > >> > Hey, > >> > > >> > mmh the description of your problem does not match with the commit you > >> > have > >> > pushed, or do i miss anything. > >> > >> The latter, I think ;) > >> > >> > Your patch is "only doing: > >> > QUrl(mSettings->path()) -> QUrl::fromUserInput(mSettings->path()); > >> > right? > >> > >> Right. > >> > >> > that means that we still have the problem with schema prefix in the > >> > url? > >> > >> No, fromUserInput supports both absolute paths and URLs, see API docs. > >> > >> > And than mCurrentUrl.isLocalFile() is not true and you'll do not enter > >> > that > >> > codepath? > >> > >> isLocalFile() will be true for local files and false for remote URLs, I > >> don't see a problem here. > >> > >> > Just a little bit curious, why this is only a problem for a new user? > >> > >> Well, anyone without a ~/.local/share/apps/korganizer/ subdir, > >> which certainly includes new users. > >> > >> > On the other side I do not understand why the default local is import > >> > to > >> > trigger this bug. > >> > >> Parse error at "default local is import". Can you rephrase? > >> > >> > Btw. if the default location for korganzier has changed, than please > >> > update > >> > the defaultcalendar.desktop path. > >> > >> And break "Personal Calendar" for all users who copy their home dir (but > >> not their akonadi setup) to another computer? Seems too dangerous to me, > >> for zero gain. The korganizer in the path is historical anyhow, > >> korganizer no longer accesses std.ics directly, ever since akonadi 1 > >> came into play. From sknauss at kde.org Wed Dec 28 23:31:00 2016 From: sknauss at kde.org (Sandro =?ISO-8859-1?Q?Knau=DF?=) Date: Thu, 29 Dec 2016 00:31:00 +0100 Subject: libkdav In-Reply-To: <7488865.cTG6kGkpQy@tuxin> References: <14819448.3HmizyNruI@tuxin> <3682462.nLaBPmAJY7@odin> <7488865.cTG6kGkpQy@tuxin> Message-ID: <1827080.CrBZHg2jGj@tuxin> Hey, We now have a new created repository named pim/kdav ( a DAV library for GroupDAV, CalDav and CardDav). That we split out kdepim-runtime. This library is now in ready for review. It builds already and together with hefee/dev/kdav branch in kdepim-runtime and is a functional replacement. At the moment kdepim-runtime is not taking any usage of kdav. Some outlines: everything is GPL2+ dependencies: QtCore, QtGui, QtXml and KioCore It is planned to release kdav within 17.04. But this is not a formal mail to add this repo to the list of released repos. Rough future plan: * make sure kdav compiles at CI * merge hefee/dev/kdav branch and make sure it works with a owncloud resource * streamline version numbers with KDEPIM & send a fromal mail to release team to add kdav. Some remakes: * version number is not streamlines with KDEPIM ( this will be done if we switch kdepim-runtime ti actually use it) * @i18n-team: no need to copy strings to other repos, they will stay in kdepim-runtime (but in other files) * I don't want to put this into the KF5 namespace, because it is not a Frameworks, and I think we as PIMsters were wrong in pushing this into that namespace. * CI support will come and is already requested :) Best Regards, sandro -- Am Montag, 19. Dezember 2016, 12:29:03 CET schrieb Sandro Knauß: > Hey, > > > > moved Akonadi parts already into own files, that can be enter into > > > kdepim-runtime. > > > > Are you willing to port the dav resource to KDAV, once its released? > > I'll to the porrting and it will compile and work afterwards. But I will not > do the logic change(s). I think here at the switch form QString -> DavUrl > (see below) some function in settings could be removed are not needed > anymore. I don't want to change the logic in settings because it has the > potential to break the resource and I do not want to digg into the resource > internal logic, how the QString -> DavUrl replacement is handled inside > settings. > > > Yep, I certainly think making DavCollection::url() return a QUrl is the > > right way to go. > > not QUrl we use DavUrl, because we also need the protocoll setting of > DavUrl. > > Any chance you could backport your patch to kdepim-runtime 16.12? > > Well this is not a bug in Applicatinos/16.12. The DAV resource it self has > function to do the transistion: > Settings::configuredDavUrl > Settings::davUrlFromCollectionUrl > > This issue only one, because I create a seperate library, that should be > self contained. For Applications/16.12 it is only a not nice logic > seperation... > > Best Regards, > > sandro -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: This is a digitally signed message part. URL: From montel at kde.org Thu Dec 29 05:57:01 2016 From: montel at kde.org (laurent Montel) Date: Thu, 29 Dec 2016 06:57:01 +0100 Subject: libkdav In-Reply-To: <1827080.CrBZHg2jGj@tuxin> References: <14819448.3HmizyNruI@tuxin> <7488865.cTG6kGkpQy@tuxin> <1827080.CrBZHg2jGj@tuxin> Message-ID: <7099067.Ho2AmuCX7h@linux-5nvn> Hi, You still install export fileinclude in /include/KF5/libkdav_version.h You still create a KF5:: namespaced lib "Add_library(KF5::kdav SHARED IMPORTED)" You generate pri file with ecm_generate_pri_file(BASE_NAME kdav LIB_NAME kdav FILENAME_VAR PRI_FILENAME INCLUDE_INSTALL_DIR $ {KDE_INSTALL_INCLUDEDIR_KF5}/KDAV ) Toplevel CmakeList needs cleanup ############### KDEPIM-Runtime version ################ # KDEPIM_RUNTIME_VERSION # Version scheme: "x.y.z build". # # x is the version number. # y is the major release number. # z is the minor release number. # # "x.y.z" follow the kdelibs version kdepim is released with. # # If "z" is 0, it the version is "x.y" # # KDEPIM_RUNTIME_DEV_VERSION # is empty for final versions. For development versions "build" is # something like "pre", "alpha1", "alpha2", "beta1", "beta2", "rc1", "rc2". # # Examples in chronological order: # # 3.0 # 3.0.1 # 3.1 alpha1 # 3.1 beta1 # 3.1 beta2 # 3.1 rc1 # 3.1 # 3.1.1 # 3.2 pre # 3.2 alpha1 And set(CMAKE_MODULE_PATH ${kdepim-runtime_SOURCE_DIR}/cmake/modules $ {ECM_MODULE_PATH}) I can't see an autotest directory ? I think that it will good to have some autotest for a lib. Regards Le jeudi 29 décembre 2016, 00:31:00 CET Sandro Knauß a écrit : > Hey, > > We now have a new created repository named pim/kdav ( a DAV library for > GroupDAV, CalDav and CardDav). That we split out kdepim-runtime. This > library is now in ready for review. It builds already and together with > hefee/dev/kdav branch in kdepim-runtime and is a functional replacement. At > the moment kdepim-runtime is not taking any usage of kdav. > > Some outlines: > everything is GPL2+ > dependencies: QtCore, QtGui, QtXml and KioCore > > It is planned to release kdav within 17.04. But this is not a formal mail to > add this repo to the list of released repos. > > Rough future plan: > * make sure kdav compiles at CI > * merge hefee/dev/kdav branch and make sure it works with a owncloud > resource * streamline version numbers with KDEPIM & send a fromal mail to > release team to add kdav. > > Some remakes: > * version number is not streamlines with KDEPIM ( this will be done if we > switch kdepim-runtime ti actually use it) > * @i18n-team: no need to copy strings to other repos, they will stay in > kdepim-runtime (but in other files) > * I don't want to put this into the KF5 namespace, because it is not a > Frameworks, and I think we as PIMsters were wrong in pushing this into that > namespace. > * CI support will come and is already requested :) > > Best Regards, > > sandro > > -- > > Am Montag, 19. Dezember 2016, 12:29:03 CET schrieb Sandro Knauß: > > Hey, > > > > > > moved Akonadi parts already into own files, that can be enter into > > > > kdepim-runtime. > > > > > > Are you willing to port the dav resource to KDAV, once its released? > > > > I'll to the porrting and it will compile and work afterwards. But I will > > not do the logic change(s). I think here at the switch form QString -> > > DavUrl (see below) some function in settings could be removed are not > > needed anymore. I don't want to change the logic in settings because it > > has the potential to break the resource and I do not want to digg into > > the resource internal logic, how the QString -> DavUrl replacement is > > handled inside settings. > > > > > Yep, I certainly think making DavCollection::url() return a QUrl is the > > > right way to go. > > > > not QUrl we use DavUrl, because we also need the protocoll setting of > > DavUrl. > > > > > Any chance you could backport your patch to kdepim-runtime 16.12? > > > > Well this is not a bug in Applicatinos/16.12. The DAV resource it self has > > function to do the transistion: > > Settings::configuredDavUrl > > Settings::davUrlFromCollectionUrl > > > > This issue only one, because I create a seperate library, that should be > > self contained. For Applications/16.12 it is only a not nice logic > > seperation... > > > > Best Regards, > > > > sandro -- Laurent Montel | laurent.montel at kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software solutions From bcooksley at kde.org Fri Dec 30 05:36:51 2016 From: bcooksley at kde.org (Ben Cooksley) Date: Fri, 30 Dec 2016 18:36:51 +1300 Subject: [kdepim-runtime/Applications/16.12] resources/shared/singlefileresource: Fix DATA LOSS bug in ical resource which failed to create std.ics if it didn't exist. In-Reply-To: <14547006.mbdgdMWApL@xps> References: <4094495.rKjsmaqygT@xps> <14547006.mbdgdMWApL@xps> Message-ID: On Thu, Dec 29, 2016 at 12:14 AM, Albert Astals Cid wrote: > El dissabte, 24 de desembre de 2016, a les 15:05:15 CET, Ben Cooksley va > escriure: >> On Sat, Dec 24, 2016 at 7:26 AM, Albert Astals Cid wrote: >> > So i guess we're in agreement that we need a new tarball? Or can we just >> > tell distro packagers to patch it? >> > >> > My issue with a new tarball is that i will need to call it 16.12.0.1 >> > (since i don't want to do 16.12.1 with just kderuntime-changes) and then >> > distros are going to complain since it has one extra version, and since >> > it's not a whole new release we again basically depend on distros picking >> > up the new tarball. >> Whichever one works easiest for the packagers I guess. >> >> Considering the severity of this issue though (silent data loss) we >> should probably make an advisory in about a month's time of which >> distributions have failed to patch/upgrade their packages so users are >> aware of the risk they are taking. > > We only have security advisories AFAIK > https://www.kde.org/info/security/ > > What kind of advisory/way to make the world now were you thinking about? A press release of some description would do the job I think. I'll admit i'm not sure of the form it should take though. > > Cheers, > Albert Cheers, Ben > >> >> > So may as well just ask them to patch it in? >> > >> > Cheers, >> > >> > Albert >> >> Cheers, >> Ben >> >> > El dimarts, 20 de desembre de 2016, a les 21:24:16 CET, David Faure va >> > >> > escriure: >> >> On mardi 20 décembre 2016 10:29:03 CET Sandro Knauß wrote: >> >> > Hey, >> >> > >> >> > mmh the description of your problem does not match with the commit you >> >> > have >> >> > pushed, or do i miss anything. >> >> >> >> The latter, I think ;) >> >> >> >> > Your patch is "only doing: >> >> > QUrl(mSettings->path()) -> QUrl::fromUserInput(mSettings->path()); >> >> > right? >> >> >> >> Right. >> >> >> >> > that means that we still have the problem with schema prefix in the >> >> > url? >> >> >> >> No, fromUserInput supports both absolute paths and URLs, see API docs. >> >> >> >> > And than mCurrentUrl.isLocalFile() is not true and you'll do not enter >> >> > that >> >> > codepath? >> >> >> >> isLocalFile() will be true for local files and false for remote URLs, I >> >> don't see a problem here. >> >> >> >> > Just a little bit curious, why this is only a problem for a new user? >> >> >> >> Well, anyone without a ~/.local/share/apps/korganizer/ subdir, >> >> which certainly includes new users. >> >> >> >> > On the other side I do not understand why the default local is import >> >> > to >> >> > trigger this bug. >> >> >> >> Parse error at "default local is import". Can you rephrase? >> >> >> >> > Btw. if the default location for korganzier has changed, than please >> >> > update >> >> > the defaultcalendar.desktop path. >> >> >> >> And break "Personal Calendar" for all users who copy their home dir (but >> >> not their akonadi setup) to another computer? Seems too dangerous to me, >> >> for zero gain. The korganizer in the path is historical anyhow, >> >> korganizer no longer accesses std.ics directly, ever since akonadi 1 >> >> came into play. > >