<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111610/">http://git.reviewboard.kde.org/r/111610/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 29th, 2013, 8:30 a.m. UTC, <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">not sure way, I cannot see your patch. Impossible to review this.</pre>
</blockquote>
<p>On July 30th, 2013, 4:58 p.m. UTC, <b>Diego Soenens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, when I try reuploading it the same thing happens :(. Maybe a bug in reviewboard?
It's very small/simple though: http://pastebin.com/FHqk22Hs</pre>
</blockquote>
<p>On July 30th, 2013, 8:10 p.m. UTC, <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think you should expose the problem in kde-core-devel mailing list, asking for the need of such old compatibility feature in ktabbar. Please, add there link to ktabbar code and explain the problems you are encountering cause of that.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yup, I sent them a mail, thanks.</pre>
<br />
<p>- Diego</p>
<br />
<p>On July 19th, 2013, 9:55 p.m. UTC, Diego Soenens wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Diego Soenens.</div>
<p style="color: grey;"><i>Updated July 19, 2013, 9:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If the mouse moves even 1 pixel while the middle mouse button is being pressed/clicked to close a tab it causes KTabBar to not emit mouseMiddleClick() if isMovable() == true.
As a result the tab doesn't get closed and the user has to try again and this can happen a few times in a row if the mouse has a "hard" middle mouse button. Quite annoying :(.
See: http://api.kde.org/4.10-api/kdelibs-apidocs/kdeui/html/ktabbar_8cpp_source.html#l00209
According to the comment it's a "compatibility feature for old middle mouse tab moving" so I'm not exactly sure if this should even be fixed to begin with and whether Rekonq is the place to do it in this case.
Edit: not sure why my diff isn't working?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Been running this patch for a few hours. Everything seems to work as intended.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/tabwindow/tabbar.cpp <span style="color: grey">(eb062bf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111610/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>