<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102402/">http://git.reviewboard.kde.org/r/102402/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 28th, 2011, 3:23 p.m. UTC, <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It is really improved from the first version tried :)
Anyway, I think its behavior has to modified. In fact Firefox/Chrom* don't have a loading animation on their urlbar, so I really think this feature should work just on loadFinished (and probably also moved there). I mean that during page load, everything should be normal and "coloring" activated just on loadFinished.</pre>
</blockquote>
<p>On August 28th, 2011, 5:59 p.m. UTC, <b>Johannes Tröscher</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should be just an easy check on progr. i'll post an updated version</pre>
</blockquote>
<p>On July 30th, 2013, 4:34 p.m. UTC, <b>Bernd Oliver Sünderhauf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why would it be so important that the coloring only comes into place on loadFinished? Don't see where it would conflict, and finally it's a security related feature, so we want the user to be informed as soon as possible of the actual domain they landed on.
Possibly the gray should be quite a bit darker to improve readability, not only but especially in private mode.
Also, now that the urlbar doesn't turn greenish anymore, the "https:" protocol should turn green the way it does in Chromium.
But then the coloring IMHO should be fine enough for now.
@Johannes:
Are you still ready to post an updated version, or should somebody continue working on it?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is not working as expected and I found no way to fix in a proper way. At least with my knowledge in a Qt4/QPainter world. This review request is still open because... Johannes is dead. One year ago. In a tragic accident.
I'll try to implement this feature in a different way as soon as we'll move to Qt5.
Regards. </pre>
<br />
<p>- Andrea</p>
<br />
<p>On August 27th, 2011, 5:24 p.m. UTC, Johannes Tröscher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Johannes Tröscher.</div>
<p style="color: grey;"><i>Updated Aug. 27, 2011, 5:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">highlight host in urlbar like in firefox.
this patch isn't finished yet.
this code also evaluates the actual textrect including all margins, so the "empty-progress==0" message will be drawn in the "real" center.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles and works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/urlbar/urlbar.cpp <span style="color: grey">(04d9698)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102402/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102402/s/238/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/08/21/highlightHost_400x100.png" style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/102402/s/239/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/08/21/highlightHost1_400x100.png" style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>