<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109942/">http://git.reviewboard.kde.org/r/109942/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 10th, 2013, 10:38 p.m. UTC, <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
<p>On April 10th, 2013, 10:41 p.m. UTC, <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is really nice, thanks :)
I'm just wondering about a possible "global" location for this shared code. This and some other shared one.</pre>
</blockquote>
<p>On April 11th, 2013, 9:47 a.m. UTC, <b>Harald Sitter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Best be brought up on the kde-frameworks-devel list. Usually I'd say a new library kwebbrowser, but at least the filetype snippet could be done in a generic fashion (I actually was surprised that there was no KMimeType::shouldEmbed()), so I believe for this particular case kmimetype may actually be best (or a related class to kmimetype in kdecore).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">uhm... if I remember it well, kmimetype is one of the KDE5 deprecated k-classes... :(</pre>
<br />
<p>- Andrea</p>
<br />
<p>On April 11th, 2013, 9:51 a.m. UTC, Harald Sitter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated April 11, 2013, 9:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> honor filetyperc setting WRT embedding
there are 3 distinct states a filetype can have WRT kpart embedding
- always embed
- never embed
- do whatever the parent node does (e.g. application/foo would take the
setting of application)
since the logic to determine which of those it is going to be we are using
a bit of code imported from konqueror deciding in a boolean fashion
whether or not we are supposed to embed or not. this is particularly non-
intrusive to the existing code as the decision directly relates to whether
a kpart should be created, if not the file will simply be krun'.
this change is using static functions for the imported code. rationale being
that they are in fact static and not having them reflected in the header makes
them all the easier to remove should a better solution arise in the future.
with that in mind: while the code is copy'n'pastable it seems like a good idea to move this
into some shared library in the long term such that konqueror and rekonq (and any other kpart
enabled app) can use the same code.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- swaped through aforementioned embed states for .pdf
- .deb are no longer opened using ark in a kpart</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="/show_bug.cgi?id=240400">240400</a>,
<a href="/show_bug.cgi?id=279423">279423</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/webtab/webpage.cpp <span style="color: grey">(479997e4e6f421c76f31ddec7ede1cc9aaf33edb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109942/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>