<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108888/">http://git.reviewboard.kde.org/r/108888/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq and Dimitrios Christidis.</div>
<div>By Dimitrios Christidis.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When right-clicking on the main toolbar, items "Bookmarks Toolbar" and "Configure Main ToolBar" appear multiple times. To be precise, they appear once for every tab that is currently open.
This bug was introduced in commit 2d8de46a. Each WebWindow creates a new collection, so the loop in MainToolBar::showCustomContextMenu() finds the actions mentioned above multiple times.
I'm attaching a simple diff as a proof-of-concept. Please advise me on what is the correct way to address this issue. Then, I'll create a proper commit patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/webwindow/maintoolbar.cpp <span style="color: grey">(ee667ec)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108888/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>