<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108801/">http://git.reviewboard.kde.org/r/108801/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 10th, 2013, 12:35 p.m. EET, <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Dimitrios, and many thanks for your patches. I had a terrible cold this week, so that I needed some time more than usual to review. You probably just noticed your first patch has just been merged. About this... I think you reverted the "settings" logic. You should add a "add tabs in the foreground" option, disabled by default, so that user wanting it, enable it! I think it's the easiest set. Can you take care of it or should I do it for you, given your patch?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Andrea,
I tried to add this option the way Konqueror does it, but I now see the inconsistency in my patch. Your way is better, so I'll be uploading a new patch shortly.
I hope you're feeling better. I should send a "Get Well" card; rekonq is awesome!</pre>
<br />
<p>- Dimitrios</p>
<br />
<p>On February 6th, 2013, 1:47 p.m. EET, Dimitrios Christidis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq and Dimitrios Christidis.</div>
<div>By Dimitrios Christidis.</div>
<p style="color: grey;"><i>Updated Feb. 6, 2013, 1:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds a new configuration option (disabled by default) to open links in new tabs in the foreground.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are multiple calls to TabWindow::loadUrl() with Rekonq::NewTab, but I think I got them all. Tested with the new setting enabled and disabled.
+ click on link with middle mouse button
+ right-click on link, then open in new tab
+ same actions on the bookmarks toolbar and about: pages
+ right-click on image, middle-click on "View Image"
Loading an external URL always focuses the new tab. Same with middle-clicking on a link in the search bar.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="/show_bug.cgi?id=313794">313794</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/rekonq.kcfg <span style="color: grey">(6303dcd)</span></li>
<li>src/settings/settings_tabs.ui <span style="color: grey">(5b367a8)</span></li>
<li>src/tabwindow/tabwindow.cpp <span style="color: grey">(d0e6dbc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108801/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>