<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108152/">http://git.reviewboard.kde.org/r/108152/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 7th, 2013, 10:23 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">/SW/SRC/rekonq/src/urlbar/newresourcedialog.cpp: In member function ‘void Nepomuk2::NewResourceDialog::newResourceSlot()’:
/SW/SRC/rekonq/src/urlbar/newresourcedialog.cpp:94:21: error: ‘class Nepomuk2::Resource’ has no member named ‘addSymbol’
/SW/SRC/rekonq/src/urlbar/newresourcedialog.cpp:100:21: error: ‘class Nepomuk2::Resource’ has no member named ‘addSymbol’
/SW/SRC/rekonq/src/urlbar/newresourcedialog.cpp:106:21: error: ‘class Nepomuk2::Resource’ has no member named ‘addSymbol’
/SW/SRC/rekonq/src/urlbar/newresourcedialog.cpp:112:21: error: ‘class Nepomuk2::Resource’ has no member named ‘addSymbol’
/SW/SRC/rekonq/src/urlbar/newresourcedialog.cpp:118:21: error: ‘class Nepomuk2::Resource’ has no member named ‘addSymbol’
make[2]: *** [src/CMakeFiles/kdeinit_rekonq.dir/urlbar/newresourcedialog.cpp.o] Error 1
make[1]: *** [src/CMakeFiles/kdeinit_rekonq.dir/all] Error 2
make: *** [all] Error 2
</pre>
</blockquote>
<p>On January 8th, 2013, 5:25 a.m., <b>David Narváez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">My bad, the code requires NepomukCore >= 4.10. If that imposes too much of a constrain, then I could patch it to require either Nepomuk or NepomukCore >= 4.10, let me know what's best.</pre>
</blockquote>
<p>On January 8th, 2013, 2:56 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you are requiring to depends on the unreleased nepomukcore 4.10, I vote for reverting this and stay with nepomuk1 until kde 4.10 has been released.
After that, move to nepomuk2 and let it compile just if >= 4.10 is available.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Reverted patch with commit 14299bca3471225 to let rekonq compile again against 4.9.x</pre>
<br />
<p>- Andrea</p>
<br />
<p>On January 4th, 2013, 4:56 a.m., David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq and Vishesh Handa.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Jan. 4, 2013, 4:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As we move forward with Rekonq 2 I think it is a good opportunity to jump to Nepomuk2. I had to copy some models that are not (yet?) available in Nepomuk2 and I'm including Vishesh who knows best about the migration process.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Tagged a bookmark using Rekonq 2 before this patch
2. Recompiled and reinstalled Rekonq 2 with this patch
3. Confirmed the old bookmark is kept, with the correct tags
4. Added a new bookmark and tagged it
5. Checked that both tags are available in the tag dialog elsewhere in my KDE Desktop</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(11015c5)</span></li>
<li>config-nepomuk.h.cmake <span style="color: grey">(fe7364f)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(143f9dc)</span></li>
<li>src/bookmarks/bookmarkowner.h <span style="color: grey">(6a18c23)</span></li>
<li>src/bookmarks/bookmarkowner.cpp <span style="color: grey">(ba2d8f6)</span></li>
<li>src/bookmarks/bookmarkscontextmenu.cpp <span style="color: grey">(69cde75)</span></li>
<li>src/nepomuk/utils/nepomukutils_export.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/nepomuk/utils/resourcemodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/nepomuk/utils/resourcemodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/nepomuk/utils/simpleresourcemodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/nepomuk/utils/simpleresourcemodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/urlbar/bookmarkwidget.h <span style="color: grey">(39f6fbd)</span></li>
<li>src/urlbar/bookmarkwidget.cpp <span style="color: grey">(e266a07)</span></li>
<li>src/urlbar/newresourcedialog.h <span style="color: grey">(651c631)</span></li>
<li>src/urlbar/newresourcedialog.cpp <span style="color: grey">(39cffc3)</span></li>
<li>src/urlbar/resourcelinkdialog.h <span style="color: grey">(e628aa1)</span></li>
<li>src/urlbar/resourcelinkdialog.cpp <span style="color: grey">(799171f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108152/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>