<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106912/">http://git.reviewboard.kde.org/r/106912/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 3011d175e9c116d7448cd1b00db59e6be35c9501 by Ivan Čukić to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On October 21st, 2012, 9:29 a.m., Ivan Čukić wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq and Andrea Diamantini.</div>
<div>By Ivan Čukić.</div>
<p style="color: grey;"><i>Updated Oct. 21, 2012, 9:29 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rekonq reports the open/close document events to activity manager daemon.
By knowing which window contains which documents and which one is in focus, we can do the following:
- collect the statistics about visited pages. Further, this provides a score for each document visited, that depends on the number of times it was open, the time the user spent on that location, and the time passed since the last visit.
- availability of a global/workspace applet that allows sharing the current document via e-mail, social networks; bookmarking and rating the link, or connecting it to the current activity. (advantage of this is a unified UI for sharing/rating/linking that works with any application)
- jump-lists (not impl. yet in plasma) to list top rated documents on a launcher icon or in the task manager applet
- krunner can sort the documents based on the score
- more things that I haven't thought of yet
There is no need to *use* ativities to have these benefits. Activities just serve as manual data clustering to provide more useful scores compared to the one-activity approach.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The event reporting was watched in two ways:
- by using the SLC applet (planned to be included in 4.10, currently plasma-mobile) - when rekonq opens a url, the icons light-up and when clicking on an icon, it show whether it reports the document properly
- by using sqlite3 to browse the .kde/share/apps/activitymanager/resources/database - 'select * from nuao_DesktopEvent;'
The tests consisted of using rekonq in two modes - the single-window and multiple-window mode. They consisted of switching between different webpages back-and-forth.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(030f0fb)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(6c27376)</span></li>
<li>src/mainview.h <span style="color: grey">(89ee36e)</span></li>
<li>src/mainview.cpp <span style="color: grey">(b71a81e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106912/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>