<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106417/">http://git.reviewboard.kde.org/r/106417/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit b2b2692bf2a24ef4a588c0f94cffde0dbe3c94ac by Lindsay Mathieson to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 13th, 2012, 11:44 a.m., Lindsay Mathieson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq, Andrea Diamantini and Lindsay Mathieson.</div>
<div>By Lindsay Mathieson.</div>
<p style="color: grey;"><i>Updated Sept. 13, 2012, 11:44 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds integrated spell checking to rekonq.
- inline spell highlighter. This requires WebKit 2.3 to be present and loaded to work. But rekonq will still run without it. Use:
export LD_LIBRARY_PATH=${WEBKITDIR}/WebKitBuild/Release/lib
To use the WebKit 2.3 libs
- Addition of a suggested replacement word list to the context menu, for the word right clicked on
- A standard modeless spell check dialog that works on the current editable text (or selection). Heavily cribbed from Dawit's work on kdewebkitpart.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with WebKit 2.3 trunk against a variety of websites. Forums such as slashdot etc to get a wide variety of text postings.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(c794539)</span></li>
<li>src/kspellplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kspellplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qwebkitplatformplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/rekonq.kcfg <span style="color: grey">(1fb3c1c)</span></li>
<li>src/settings/settings_advanced.ui <span style="color: grey">(9457ca2)</span></li>
<li>src/webview.h <span style="color: grey">(0141925)</span></li>
<li>src/webview.cpp <span style="color: grey">(7272e2c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106417/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106417/s/725/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/10/rekonq-Spell_400x100.png" style="border: 1px black solid;" alt="Inline spell highlight" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>