<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105938/">http://git.reviewboard.kde.org/r/105938/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Closing as submitted. If you'd like to go again for your last commit, please open another request. Thanks.</pre>
<br />
<p>- Andrea</p>
<br />
<p>On August 8th, 2012, 9:43 p.m., Yoann Laissus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Yoann Laissus.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2012, 9:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The branch is here : http://github.com/Arakmar/rekonq/tree/tabBarRefactoring
The original goal of this merge request was to (finally) fix all problems we have with the interaction between the tabbar and KMessageWidget.
While investigating for this problem, I also cleaned and fixed some bugs with the add tab button and tab previews which was hidden by the previous implementation
That's why I decided to split that in independant parts. Only the last one depends on the first two. Those two parts can be safely backported in the 1.0 branch as it's only fixes.
First part : add tab button refactoring (6f291145ba8a4)
This commit clean the updateTabBar method by splitting it in two methods (updateAddTabButton and updateTabBarVisibility) as it's two things very different.
The position of the new tab button is now updated only on layout change of the tab bar.
This method has the benefit to not call the slot in every method which add a tab.
It also fixes bug 304325 and some nasty bugs with KMessageWidget due to non updated position.
Second part : Tab preview refactoring (b83d6a, 7e3158, f5f69)
This part is mainly here to prepare the last one.
Those commits introduce a fixed size (200px) for tab previews to fix issues with too big preview on very high ratio. (eg : preview of tabs for a 200x900 window)
200 can be discussed but it's the default size of a tab. (The size hint of the mainview is always the same, even on a resolution change ...)
Third part : Tab width refactoring (2cf613)
The problem is described here :
https://git.reviewboard.kde.org/r/102651/
When a KTabWidget appears, the tab width grows up. And without the first part of this MR, the add tab button isn't even updated.
The previous fix has been removed by some refactoring of Application and MainWindow.
But I think we can't rely on this solution anymore, it's not the proper way to fix that.
That's why I have replaced the existing solution by a more configurable one.
There is now the choice between two options (in the Tab section) :
- Fixed configurable size (Default to 200 and minimum 100)
It's the replacement of the previous behaviour.
We can't rely on MainView::tabSizeHint() as it's the same value no matter the resolution of the screen.
Moreover, all major browsers use a fixed (configurable) size (Firefox - 250 px, Chrome - 200 px)
So I think it's a lot safer to use that.
- Automatic size depending on the title size:
It's the default behaviour of KTabBar (Konqueror)
(Sorry for this big description :D )</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on multiple computers with different resolutions.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="/show_bug.cgi?id=304325">304325</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/application.cpp <span style="color: grey">(2127ca9)</span></li>
<li>src/mainview.h <span style="color: grey">(9378f4b)</span></li>
<li>src/mainview.cpp <span style="color: grey">(861a6b1)</span></li>
<li>src/rekonq.kcfg <span style="color: grey">(1fb3c1c)</span></li>
<li>src/settings/settings_tabs.ui <span style="color: grey">(4e19545)</span></li>
<li>src/settings/tabswidget.h <span style="color: grey">(056f030)</span></li>
<li>src/settings/tabswidget.cpp <span style="color: grey">(67829f8)</span></li>
<li>src/tabbar.h <span style="color: grey">(161612c)</span></li>
<li>src/tabbar.cpp <span style="color: grey">(ac257d1)</span></li>
<li>src/tabpreviewpopup.h <span style="color: grey">(5c62102)</span></li>
<li>src/tabpreviewpopup.cpp <span style="color: grey">(63ff542)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105938/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105938/s/665/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/08/tab_1_400x100.png" style="border: 1px black solid;" alt="Automatic width" /></a>
<a href="http://git.reviewboard.kde.org/r/105938/s/666/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/08/tab_2_400x100.png" style="border: 1px black solid;" alt="Fixed width" /></a>
<a href="http://git.reviewboard.kde.org/r/105938/s/667/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/08/tab_settings_400x100.png" style="border: 1px black solid;" alt="Tab settings" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>