<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105732/">http://git.reviewboard.kde.org/r/105732/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 26th, 2012, 8:27 a.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't understand your changes: this is my kuriikwsfilterrc file.
---
[$Version]
update_info=kuriikwsfilter.upd:post-kde3.1/cvs
[General]
DefaultSearchEngine=google
EnableWebShortcuts=true
FavoriteSearchEngines=youtube,google,wikipedia,wikit
KeywordDelimiter=:
UseSelectedProvidersOnly=true
---
Moreover, I'm using ArchLinux and search engines are working here.
To really fix and improve this code you should REMOVE deprecated access to config file and use KUriFilterData API instead.
The other fix needs to be posted in a different request and just better tested.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Moreover, the problem reported here in Chakra (https://bugs.kde.org/show_bug.cgi?id=303872) "autoresolved" itself.</pre>
<br />
<p>- Andrea</p>
<br />
<p>On July 25th, 2012, 10:39 p.m., Johannes Tröscher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq and Andrea Diamantini.</div>
<div>By Johannes Tröscher.</div>
<p style="color: grey;"><i>Updated July 25, 2012, 10:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the names of two entries in the code parsing the config file for search engines seem to be wrong. rekonq will not find the default search engine and the favored ones because of this. i've changed the code to use the right entries.
furthermore there seems to be a bug that causes the completition widget only to be shown from the time on it lost it's focus once and gained it again. i've addressed that as well and changed the code to show the completition widget also on keypress events.i hope that's ok ;)
bugs occurred in chakra linux and where also confirmed by arch-users.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles and works</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="/show_bug.cgi?id=303872">303872</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/opensearch/searchengine.cpp <span style="color: grey">(aef06a7)</span></li>
<li>src/urlbar/urlbar.cpp <span style="color: grey">(21debce)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105732/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>