<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104647/">http://git.reviewboard.kde.org/r/104647/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 19th, 2012, 3:58 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't understand these changes. Why aren't we doing inline spell check on strings? I think that it is the unique way to let people use spellcheck. Just check on keyPressEvent if you are on an INPUT/TEXTAREA element on content editable text and if so, check words before spaces.</pre>
</blockquote>
<p>On April 19th, 2012, 5:04 p.m., <b>Siteshwar Vashisht</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess we had already discussed this issue. Support for inline spell check will require us to modify QtWebkit sources. I just followed the way KWebKitPart does it. I am not sure how helpful your current suggestion would be in providing full fledged inline spell check.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As Siteshwar said, it can only be done in the QtWebKit sources and has been, but is very unlikely to make its way into KDE. See this discussion here:
https://lists.webkit.org/pipermail/webkit-qt/2012-February/002429.html</pre>
<br />
<p>- Lindsay</p>
<br />
<p>On April 17th, 2012, 4:59 p.m., Siteshwar Vashisht wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Siteshwar Vashisht.</div>
<p style="color: grey;"><i>Updated April 17, 2012, 4:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adding support for spellcheck in Rekonq using Sonnet. Right now spellcheck is not inline and you need to right click text box and select "Spellcheck" to perform checks.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/webview.h <span style="color: grey">(3ae9b7e)</span></li>
<li>src/webview.cpp <span style="color: grey">(d2e351c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104647/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>