<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103905/">http://git.reviewboard.kde.org/r/103905/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 10th, 2012, 9:03 a.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103905/diff/1/?file=49059#file49059line208" style="color: black; font-weight: bold; text-decoration: underline;">src/application.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int Application::newInstance()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">208</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">mainWindow</span><span class="p">()</span><span class="o">-></span><span class="n">currentTab</span><span class="p">()</span><span class="o">-></span><span class="n">showMessageBar</span><span class="p">();</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry Yoann, I yet cannot reproduce your bug. Anyway, I'd like to not propose again the "bugged habit" to postLaunch things. Can't we just let showMessageBar a private slot and singleShot it with 1 second of delay?
PS: please, rebase branches before committing to master, to let history be clean.</pre>
</blockquote>
<p>On February 11th, 2012, 1:58 p.m., <b>Yoann Laissus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It seems to be a Kubuntu related issue. I can reproduce the bug on Kubuntu 11.10 (KDE 4.7 and another PC with KDE 4.8) but not on Fedora (KDE 4.7) ...
I'll try to make a better and less intrusive patch without the need of a timer.
Oops sorry for master, forget the --rebase.</pre>
</blockquote>
<p>On February 11th, 2012, 10:46 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do you think a change like this can work also there?
----- patch start here -----
diff --git a/src/application.cpp b/src/application.cpp
index d8044e2..1bf7b55 100644
--- a/src/application.cpp
+++ b/src/application.cpp
@@ -205,7 +205,7 @@ int Application::newInstance()
if (isRekonqCrashed && isFirstLoad)
{
loadUrl(KUrl("about:closedTabs"), Rekonq::NewWindow);
- mainWindow()->currentTab()->showMessageBar();
+ QTimer::singleShot(1000, mainWindow()->currentTab(), SLOT(showMessageBar()));
}
if (areThereArguments)
diff --git a/src/webtab.h b/src/webtab.h
index ccbd7a8..b875e4f 100644
--- a/src/webtab.h
+++ b/src/webtab.h
@@ -93,7 +93,6 @@ public:
void setPart(KParts::ReadOnlyPart *p, const KUrl &u);
- void showMessageBar();
private Q_SLOTS:
void updateProgress(int progress);
@@ -103,6 +102,8 @@ private Q_SLOTS:
void showRSSInfo(const QPoint &pos);
void showSearchEngine(const QPoint &pos);
void openSearchEngineAdded();
+
+ void showMessageBar();
Q_SIGNALS:
void loadProgressing();
----- patch ends here -----</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, I forgot this review request.
The patch you have committed works just fine :)</pre>
<br />
<p>- Yoann</p>
<br />
<p>On February 10th, 2012, 7:42 a.m., Yoann Laissus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Yoann Laissus.</div>
<p style="color: grey;"><i>Updated Feb. 10, 2012, 7:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Restore the old method to fix the recover on crash bar if rekonq is maximised at startup.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/application.h <span style="color: grey">(2689e3f)</span></li>
<li>src/application.cpp <span style="color: grey">(18d19d9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103905/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103905/s/428/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/02/10/bugrekonq_400x100.png" style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>