<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103880/">http://git.reviewboard.kde.org/r/103880/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 7th, 2012, 8:40 a.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is obviously 0.10 material, isn't it?</pre>
</blockquote>
<p>On February 7th, 2012, 8:45 a.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It seems I'm a bit distract this morning, sorry. Taking a look to the patch. Thanks for it.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I took a look at the patch and to Chrome/Firefox/Konqueror behavior. Chrome/Konqueror works in the same way you implemented here, while Firefox proposes a "print" menu, showing more options (print, print preview, page setup). On the other hand, the print preview option was requested in the early rekonq days and was something I am really used, too. I think that 90% of users when press print wanna just check a first preview and then press ok/cancel.
So, I would NOT completely remove the print preview. IMHO we have two choices here:
1) add a menu (like firefox) leaving the actual print action as default (the CTRL+P triggered) and providing a "print setup" option as you implemented
2) implement a new dialog, showing preview and a button to select KDE print option.</pre>
<br />
<p>- Andrea</p>
<br />
<p>On February 6th, 2012, 11:03 p.m., Johannes Tröscher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq and Andrea Diamantini.</div>
<div>By Johannes Tröscher.</div>
<p style="color: grey;"><i>Updated Feb. 6, 2012, 11:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this patch would add advanced printing options, like having several pages on one sheet but remove the print preview.
i've found no solution of having both, because the advanced options are added through kde printing system and QPrintPreviewDialog has no option to add those advance dialogs. furthermore there would be kde's own print-preview, but this one is very limited and you can't even print directly from it.
so what to do?
i just did this patch because a user on irc was complaining that he can't print several pages on one sheet.
the decision on whether to include this is up to you.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles and works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/mainwindow.cpp <span style="color: grey">(97f4d94)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103880/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>