<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103652/">http://git.reviewboard.kde.org/r/103652/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 10th, 2012, 6:05 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To say the truth I prefer actual logic, where the "guessing part" is when user types, while when he clicks he just knows what url will be loaded. </pre>
</blockquote>
<p>On January 10th, 2012, 7:23 p.m., <b>Furkan Üzümcü</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You still know wht will be loaded. The old way kind of restricts user. He has to press down a few times to load the URL he/she wants. Just try it for yourself. This really annoys me.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, I don't understand. This is what user sees typing "kde.org": http://wstaw.org/m/2012/01/12/kde_org_actual.png , while this is what he sees with your patch: http://wstaw.org/m/2012/01/12/kde_org_furkan.png . Who has to move to find the URL he/she wants? I guess the second one. Please consider that just typing "k" and until the thing you write IS an url, you see relevant urls before: http://wstaw.org/m/2012/01/12/k_actual.png .
As said, in the actual version the "guessing" part works while user types, with this patch user press enter and yet does not know what url will be loaded. So, I yet vote for actual code. Please, present a meaningful use case to show why your patch is better than actual behavior.</pre>
<br />
<p>- Andrea</p>
<br />
<p>On January 10th, 2012, 10:27 a.m., Furkan Üzümcü wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Furkan Üzümcü.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2012, 10:27 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently, when you type something in the URL bar the completetion widget pops up and activates the first item. And you can't load the URL typed in when you hit enter. Rekonq loads the actvated item. This patch fixes that issue. When you reached the index zero if you go up again the last item gets deactivated and you can load the typed string.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles and works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/urlbar/completionwidget.h <span style="color: grey">(517a7ea)</span></li>
<li>src/urlbar/completionwidget.cpp <span style="color: grey">(b349041)</span></li>
<li>src/urlbar/urlbar.h <span style="color: grey">(2d158ff)</span></li>
<li>src/urlbar/urlresolver.h <span style="color: grey">(167ee28)</span></li>
<li>src/urlbar/urlresolver.cpp <span style="color: grey">(5bf2ee6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103652/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>