<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103451/">http://git.reviewboard.kde.org/r/103451/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 9th, 2012, 6:11 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code seems ok now, but I tested your patch and I cannot really understand why we should apply such changes. Chromium and Firefox both show such actions in tabbar contextual menu, so I think you should spend some words to explain why you are suggesting such changes.</pre>
</blockquote>
<p>On January 9th, 2012, 8:15 p.m., <b>Furkan Üzümcü</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"Open Last Closed Tab" and "Closed Tabs" actions are in both empty are context menu and tab context menu. User doesn't need it in both places just one is enough. For Chromium, it doesn't have the same actions in both areas. I think this takes up too much space and doesn't really seem good, imho.
Actually I just reconsidered the new tab context menu it's not really needed. But, it's ok if we have it though. :)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If we remove some actions from tabbar contextual menu and move them in blank space, we need an option to launch them where blank space is "nothing" (i.e. full tabbar), so new tab context menu is useful in this case. But this seems to me just a way to complicate things. I'd really like to hear Yusuf's reasons for such a change.</pre>
<br />
<p>- Andrea</p>
<br />
<p>On January 7th, 2012, 2:28 p.m., Yusuf TEZCAN wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Yusuf TEZCAN.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2012, 2:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed the "Open The Last Closed Tab" and "Closed Tabs" actions and set ""New Tab"" button's context menu to the empty area context menu on TabBar.
I am a GCI-Student who wrote this patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/mainview.cpp <span style="color: grey">(6285159)</span></li>
<li>src/tabbar.cpp <span style="color: grey">(4834095)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103451/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>