<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103428/">http://git.reviewboard.kde.org/r/103428/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 16th, 2011, 9:17 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The "open in new tab feature" has been explicitely requested times ago. Why are you going to "force" it? Moreover, you probably just need to add the home button in the (actual) urlbar via the "configure toolbars" contextual menu.
I don't see the need for this change.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stupid me, IRC discussion explained me everything and now I see the bug when setting a custom shortcut for the "home" containing CTRL.</pre>
<br />
<p>- Andrea</p>
<br />
<p>On December 16th, 2011, 1:43 p.m., Thomas Murach wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Thomas Murach.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2011, 1:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Functionality: see summary.
Concerning the code: As far as I've seen, there is no "go to home page" button or anything like that. So the only way to visit the home page is to use a shortcut or to configure this as new tab action. Therefore it's not necessary anymore to care about middle mouse clicks or Ctrl+... events. That's why I also changed the argument list of MainWindow::homePage().
If I'm mistaken on that, please correct me.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/mainwindow.h <span style="color: grey">(8d827b0)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(6b15385)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103428/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>