<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102839/">http://git.reviewboard.kde.org/r/102839/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 13th, 2011, 4:55 p.m., <b>Tirtha Chatterjee</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the idea of having pinned tabs kind of collides and makes redundant my work on tab grouping using sessions. I'd request to wait to merge this feature till 0.8 is released. After that, we can discuss in detail how to merge this smoothly while having tab-grouping.</pre>
</blockquote>
<p>On October 13th, 2011, 5:37 p.m., <b>Furkan Üzümcü</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If so, this patch becomes useless. :)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, I wouldn't say useless, actually quite helpful. I think we can integrate this in a nice way with the tab-grouping thing. So I'll try to use this code, and merge these into my work. Thanks for the patch.</pre>
<br />
<p>- Tirtha</p>
<br />
<p>On October 13th, 2011, 2:47 p.m., Furkan Üzümcü wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Furkan Üzümcü.</div>
<p style="color: grey;"><i>Updated Oct. 13, 2011, 2:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This feature has become a "must have" for any browser. So I thought I could do something about it. The patch works fine except a few glitches which I'm hoping you can help me about. I do believe this patch isn't perfect. So please help me improve it.
There are 2 problems.
1- Open 2 tabs. While on the first tab pin the second one. And you'll se the problem. This is the best way to tell you.
2- Icons aren't shown right after pinning a tab.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles and works except some glitches.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/application.cpp <span style="color: grey">(6f9df43)</span></li>
<li>src/mainview.cpp <span style="color: grey">(0cd61dd)</span></li>
<li>src/rekonq.kcfg <span style="color: grey">(d29a5a3)</span></li>
<li>src/tabbar.h <span style="color: grey">(b4c816b)</span></li>
<li>src/tabbar.cpp <span style="color: grey">(ea01ef9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102839/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>