<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102330/">http://git.reviewboard.kde.org/r/102330/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 18th, 2011, 10:57 p.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't like this change.
First, I couldn't find a similar option in Firefox or Chromium: they continued opening external links in new tabs. The only way to change it (just on Firefox) is to change exactly the same settings rekonq has. It seems impossible to provide this behavior on Chromium.
Second, I usually open a lot of links from external tabs (eg: akregator, kmail). Why should I find them in different windows?
</pre>
</blockquote>
<p>On August 19th, 2011, 8:17 a.m., <b>Thomas Zander</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Jumping in as this is a very similar subject to the other one I was talking about on the rekonq mailinglist;
people use virtual desktops and activities to separate out their work into discrete sections.
Consider this usecase; (not uncommon!)
A personal activity runs kmail while at work, a work activity runs rekonq with gmail for work emails.
The user clicks on a link in kmail to show a webpage that is clearly for his personal activity; maybe a facebook link...
Current behavior is that on his work activity, on another virtual desktop, a tab is added next to his work gmail tab.
With this patch (if I understand correctly) the click in kmail, on his personal activity, opens a window in that same activity and on the same virtual desktop. Which is much more predictable and in line with the concepts that both virtual desktops and activities promote.
ps. did you know you can suspend an activity and that quits all windows there? They save session and restarting the activity will restore that session. Consider this with the above suggested behavior.
Bottom line; if I understand this patch correctly, I like it!</pre>
</blockquote>
<p>On August 19th, 2011, 8:51 a.m., <b>Heinz Wiesinger</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Going about this from a user's perspective. Current behaviour, please correct me if I'm wrong, is that when open urls in new tabs is set and you open a url, it will open it in a new tab in the rekonq window on the current virtual desktop. If there is no rekonq on the current virtual desktop it will look for a rekonq window on another virtual desktop and open it there, and if there is no rekonq open, it will open a new window. If you want to split opened urls semantically between multiple virtual desktops you can decisively start up a new rekonq instance on your virtual desktop of choice.
IMHO this is acceptable behaviour for the above described scenario. However, an optimal solution would probably be to have a setting that only the first url opened per virtual desktop opens a new window, while the next ones will open in a new tab in that window.
Now looking at it from the perspective of Activities. Activities are something KDE specific, so naturally neither firefox nor chrome would know how to deal with them. But rekonq as KDE application could. Activities are meant to separate different tasks from each other. While I would still want urls to be opened by the same rekonq instance, that instance should ignore the fact that there is another rekonq instance running in another activity. It again would boil down to something like I explained for the previous scenario, only the first url opened per activity opens a new window.
My 0.02$</pre>
</blockquote>
<p>On August 21st, 2011, 5 p.m., <b>Pali Rohár</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But it is/was standard Konqueror behavior. Problem is that if I have opened rekonq on other desktop and if I start rekonq (from kmail) it open me link in existing rekonq window. Which is on other desktop.
We should discuss about this option! It does not change default behaviour of application. And reason that it is not supported by other browsers, why rekonq must has same configurable features like other browsers?</pre>
</blockquote>
<p>On August 21st, 2011, 8:45 p.m., <b>Heinz Wiesinger</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As far as I understood your patch adds an option that creates a new window every time you click a link in an external application. So if I'm in akregator and want to open 10 entries in rekonq to read more about them, or comment on them, I get 10 rekonq windows. I'm sorry, but I don't see how that is useful in any way.
What's wrong with opening those 10 akregator entries in the same window, new if there's none on the current desktop or the existing one if there is?</pre>
</blockquote>
<p>On August 22nd, 2011, 6:31 a.m., <b>Pali Rohár</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I use desktop 1 for activity 1 (where is open rekonq with a lot of tabs) and desktop 2 for activity 2 (where is no rekonq window) and on desktop 2 I have KMail. And I do not want to mix links opened from desktop 2 with desktop 1.
Or If I have in KMail 10 different mails and if I need open links from these different mails in new windows.</pre>
</blockquote>
<p>On August 23rd, 2011, 9:57 a.m., <b>Andrea Diamantini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pali, you're right saying this: "We should discuss about this option! It does not change default behaviour of application. And reason that it is not supported by other browsers, why rekonq must has same configurable features like other browsers?".
I closed your request by accident and I'm trying to reopen it, to let people discuss about.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I cannot update diff (not uploaded by me), but it should be updated with changes written in diff comment, see line 195.
Ok, what is reason: why not to include this patch?</pre>
<br />
<p>- Pali</p>
<br />
<p>On August 15th, 2011, 3:30 p.m., Johannes Tröscher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Johannes Tröscher.</div>
<p style="color: grey;"><i>Updated Aug. 15, 2011, 3:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">patch by Pali Rohár.
https://bugs.kde.org/show_bug.cgi?id=275477</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles and works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/application.cpp <span style="color: grey">(a62d548)</span></li>
<li>src/rekonq.kcfg <span style="color: grey">(4050c4a)</span></li>
<li>src/settings/settings_tabs.ui <span style="color: grey">(eb775d5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102330/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>