<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101945/">http://git.reviewboard.kde.org/r/101945/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 16th, 2011, 9:10 a.m., <b>Pierre Rossi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah! that's a really cool addition I think. Small usability details we might need to test and see over time: does the favorite have to be bookmarked by default ? (I know it only takes one click to undo, but it also only takes one click to do...)
As an evolution for the right hand side icons, maybe we could have custom context menus for them, or at least add some custom actions to the lineedit's context menu.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The "forced" bookmark question is in fact a weakness of the patch. What do you think about "doubleclick"?</pre>
<br />
<p>- Andrea</p>
<br />
<p>On July 13th, 2011, 4:37 p.m., Andrea Diamantini wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Andrea Diamantini.</div>
<p style="color: grey;"><i>Updated July 13, 2011, 4:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Provide a "click" mechanism to manage favorites
With this commit, you can add a favorite by clicking 2 times in the bookmark icon.
If an URL is a favorite, the favorite icon appears and then you can manage it from there...
Pushed on remote branch: AddFavoriteWithAClick
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(f623adf)</span></li>
<li>src/urlbar/favoritewidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/urlbar/favoritewidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/urlbar/urlbar.h <span style="color: grey">(9ed89da)</span></li>
<li>src/urlbar/urlbar.cpp <span style="color: grey">(078dc6a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101945/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>