<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101782/">http://git.reviewboard.kde.org/r/101782/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 27th, 2011, 9:23 p.m., <b>Pierre Rossi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm a bit surprised this even works, event1 goes out of scope before even calling the parent implementation, which means your event points to some random memory (possibly the local variables for KWebView::keyPressEvent) at the top of the stack. Doesn't look right to me.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">uhm... it seems I was so happy to restart committing and playing that I didn't properly reviewed this. :)
Anyway, I tested this patch for an hour or so and I can ensure it works properly.
Let's see what we can do to clean up the code.
</pre>
<br />
<p>- Andrea</p>
<br />
<p>On June 27th, 2011, 12:39 a.m., Thomas Murach wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for rekonq.</div>
<div>By Thomas Murach.</div>
<p style="color: grey;"><i>Updated June 27, 2011, 12:39 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds shortcuts for scrolling as in vi or konqueror and meets bug #238761.
Things reviewers could check:
- is it wanted to not scroll when shift (or ctrl or other modifiers) is pressed? If so, I could produce another patch for usual scrolling using arrow keys + modifiers.
- would you propose using KActions?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/webview.cpp <span style="color: grey">(ca7f1b7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101782/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>